From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50312) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmiJy-0000Xn-Ut for qemu-devel@nongnu.org; Wed, 21 Sep 2016 10:16:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmiJs-0002RT-9v for qemu-devel@nongnu.org; Wed, 21 Sep 2016 10:16:21 -0400 References: <1474462571-10596-1-git-send-email-kwolf@redhat.com> <1474462571-10596-11-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: Date: Wed, 21 Sep 2016 09:16:08 -0500 MIME-Version: 1.0 In-Reply-To: <1474462571-10596-11-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LRiQWRtoRsS3bOcihcm6orMrL1n9pDQ0c" Subject: Re: [Qemu-devel] [PATCH v3 10/12] block: Avoid printing NULL string in error messages List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LRiQWRtoRsS3bOcihcm6orMrL1n9pDQ0c From: Eric Blake To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, qemu-devel@nongnu.org Message-ID: Subject: Re: [PATCH v3 10/12] block: Avoid printing NULL string in error messages References: <1474462571-10596-1-git-send-email-kwolf@redhat.com> <1474462571-10596-11-git-send-email-kwolf@redhat.com> In-Reply-To: <1474462571-10596-11-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/21/2016 07:56 AM, Kevin Wolf wrote: > Even for nodes that have a BlockBackend attached, bdrv_get_parent_name(= ) > can return NULL if the BB is anonymous (e.g. it belongs to a block job > or a device that was created with a drive=3D option). >=20 > Remove the information from the error message. The user probably knows > already why the node is still in use. >=20 > Signed-off-by: Kevin Wolf > --- > blockdev.c | 9 +++------ > tests/qemu-iotests/085.out | 6 +++--- > 2 files changed, 6 insertions(+), 9 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --LRiQWRtoRsS3bOcihcm6orMrL1n9pDQ0c Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX4pYoAAoJEKeha0olJ0Nq+O8H/2Mwr9ykkiHGj1j8U3II7Sn1 ma6FjKvBdoap+x/2KzKYEuuXarIqloZ3FR0k02+eXEbpedMtIvBl+4ue/RdQRn0i 8GcLZQyTX8/+pFatlSI1JiY7ytUP1vdunHHs/5eYW2VXtLrU+AgQUPCk0KXQNf4D 4PDzmOFbCxoEKA6njIDUI/N05kCa7wo/ZNNX681EF+Hoa7Yk8qVBY0x4zZSyXV+J z24q+L+FI9su26msSMMvghZUZzjTNQg6Rk2Zd4NBIPF1iZ8259PUwgQtIGm/tqL+ XNrVrLnveXUA0bzCjzgBKs2u5jzvXnHUH98aT41cKPRMJTiuejVxtLVnAuTjhmQ= =OJyG -----END PGP SIGNATURE----- --LRiQWRtoRsS3bOcihcm6orMrL1n9pDQ0c--