From: Laszlo Ersek <lersek@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org, kwolf@redhat.com, mreitz@redhat.com,
qemu-block@nongnu.org, qemu-ppc@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 08/10] pflash: Clean up after commit 368a354f02b part 1
Date: Mon, 18 Feb 2019 17:50:01 +0100 [thread overview]
Message-ID: <aa7290ec-34e1-2fe7-8bcb-0a9db90bd418@redhat.com> (raw)
In-Reply-To: <20190218125615.18970-9-armbru@redhat.com>
On 02/18/19 13:56, Markus Armbruster wrote:
> QOMification left parameter @qdev unused in pflash_cfi01_register()
> and pflash_cfi02_register(). All callers pass NULL. Remove.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> hw/arm/collie.c | 4 ++--
> hw/arm/digic_boards.c | 2 +-
> hw/arm/gumstix.c | 4 ++--
> hw/arm/mainstone.c | 2 +-
> hw/arm/musicpal.c | 4 ++--
> hw/arm/omap_sx1.c | 4 ++--
> hw/arm/versatilepb.c | 2 +-
> hw/arm/xilinx_zynq.c | 2 +-
> hw/arm/z2.c | 3 +--
> hw/block/pflash_cfi01.c | 2 +-
> hw/block/pflash_cfi02.c | 2 +-
> hw/i386/pc_sysfw.c | 2 +-
> hw/lm32/lm32_boards.c | 4 ++--
> hw/lm32/milkymist.c | 2 +-
> hw/microblaze/petalogix_ml605_mmu.c | 3 +--
> hw/microblaze/petalogix_s3adsp1800_mmu.c | 2 +-
> hw/mips/mips_malta.c | 2 +-
> hw/mips/mips_r4k.c | 2 +-
> hw/ppc/ppc405_boards.c | 6 +++---
> hw/ppc/sam460ex.c | 2 +-
> hw/ppc/virtex_ml507.c | 2 +-
> hw/sh4/r2d.c | 2 +-
> include/hw/block/flash.h | 4 ++--
> 23 files changed, 31 insertions(+), 33 deletions(-)
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
next prev parent reply other threads:[~2019-02-18 16:50 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 12:56 [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups Markus Armbruster
2019-02-18 12:56 ` [Qemu-devel] [PATCH 01/10] pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02 Markus Armbruster
2019-02-18 16:40 ` Laszlo Ersek
2019-02-19 12:49 ` Philippe Mathieu-Daudé
2019-02-19 13:41 ` Markus Armbruster
2019-02-19 14:33 ` Philippe Mathieu-Daudé
2019-02-21 9:15 ` Markus Armbruster
2019-02-21 16:41 ` Philippe Mathieu-Daudé
2019-02-21 15:07 ` Alex Bennée
2019-02-18 12:56 ` [Qemu-devel] [PATCH 02/10] pflash: Macro PFLASH_BUG() is used just once, expand Markus Armbruster
2019-02-18 16:43 ` Laszlo Ersek
2019-02-18 17:35 ` Markus Armbruster
2019-02-19 12:40 ` Philippe Mathieu-Daudé
2019-02-19 13:11 ` Peter Maydell
2019-02-19 13:46 ` Markus Armbruster
2019-02-21 9:22 ` Markus Armbruster
2019-02-21 9:38 ` Peter Maydell
2019-02-21 12:07 ` Laszlo Ersek
2019-02-21 12:38 ` Peter Maydell
2019-02-21 12:46 ` Laszlo Ersek
2019-02-21 16:39 ` Philippe Mathieu-Daudé
2019-02-21 16:55 ` Laszlo Ersek
2019-02-21 16:19 ` Philippe Mathieu-Daudé
2019-02-21 17:03 ` Markus Armbruster
2019-02-21 18:50 ` Alex Bennée
2019-02-22 7:17 ` Markus Armbruster
2019-02-21 15:08 ` Alex Bennée
2019-02-18 12:56 ` [Qemu-devel] [PATCH 03/10] hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2} Markus Armbruster
2019-02-18 16:45 ` Laszlo Ersek
2019-02-19 12:41 ` Philippe Mathieu-Daudé
2019-02-21 15:09 ` Alex Bennée
2019-02-18 12:56 ` [Qemu-devel] [PATCH 04/10] sam460ex: Don't size flash memory to match backing image Markus Armbruster
2019-02-18 16:36 ` [Qemu-devel] [Qemu-ppc] " BALATON Zoltan
2019-02-18 17:57 ` Markus Armbruster
2019-02-19 1:19 ` BALATON Zoltan
2019-02-19 5:43 ` Markus Armbruster
2019-02-19 11:34 ` BALATON Zoltan
2019-02-18 12:56 ` [Qemu-devel] [PATCH 05/10] ppc405_boards: " Markus Armbruster
2019-02-19 3:55 ` David Gibson
2019-02-19 15:28 ` [Qemu-devel] [Qemu-ppc] " BALATON Zoltan
2019-02-19 15:55 ` Markus Armbruster
2019-02-21 15:20 ` [Qemu-devel] " Alex Bennée
2019-02-21 16:31 ` Markus Armbruster
2019-02-21 22:18 ` David Gibson
2019-02-22 7:23 ` Markus Armbruster
2019-02-18 12:56 ` [Qemu-devel] [PATCH 06/10] r2d: Flash memory creation is confused about size, mark FIXME Markus Armbruster
2019-02-19 14:03 ` Peter Maydell
2019-02-19 15:45 ` Markus Armbruster
2019-02-19 15:53 ` Philippe Mathieu-Daudé
2019-02-19 17:30 ` Markus Armbruster
2019-03-04 4:57 ` Magnus Damm
2019-03-04 7:25 ` Markus Armbruster
2019-03-04 11:43 ` Philippe Mathieu-Daudé
2019-03-04 15:33 ` Markus Armbruster
2019-03-05 17:21 ` Philippe Mathieu-Daudé
2019-03-05 17:25 ` Peter Maydell
2019-03-05 21:50 ` Philippe Mathieu-Daudé
2019-03-06 6:03 ` Markus Armbruster
2019-03-06 14:11 ` Markus Armbruster
2019-02-19 16:02 ` Philippe Mathieu-Daudé
2019-02-19 16:21 ` Peter Maydell
2019-02-19 17:53 ` Markus Armbruster
2019-02-19 18:11 ` Peter Maydell
2019-02-18 12:56 ` [Qemu-devel] [PATCH 07/10] mips_malta: Clean up definition of flash memory size somewhat Markus Armbruster
2019-02-19 13:02 ` Philippe Mathieu-Daudé
2019-02-19 13:43 ` Markus Armbruster
2019-02-19 16:10 ` Philippe Mathieu-Daudé
2019-02-21 15:27 ` Alex Bennée
2019-02-18 12:56 ` [Qemu-devel] [PATCH 08/10] pflash: Clean up after commit 368a354f02b part 1 Markus Armbruster
2019-02-18 16:50 ` Laszlo Ersek [this message]
2019-02-19 16:12 ` Philippe Mathieu-Daudé
2019-02-21 15:57 ` Alex Bennée
2019-02-18 12:56 ` [Qemu-devel] [PATCH 09/10] pflash: Clean up after commit 368a354f02b part 2 Markus Armbruster
2019-02-18 17:01 ` Laszlo Ersek
2019-02-18 17:56 ` Laszlo Ersek
2019-02-19 5:44 ` Markus Armbruster
2019-02-21 16:51 ` Alex Bennée
2019-02-21 17:18 ` Markus Armbruster
2019-02-21 17:36 ` BALATON Zoltan
2019-02-21 18:18 ` Markus Armbruster
2019-02-18 12:56 ` [Qemu-devel] [PATCH 10/10] hw/arm hw/xtensa: De-duplicate pflash creation code some Markus Armbruster
2019-02-18 17:12 ` Laszlo Ersek
2019-02-19 8:43 ` Max Filippov
2019-02-19 13:01 ` Markus Armbruster
2019-02-19 14:13 ` Peter Maydell
2019-02-19 15:46 ` Markus Armbruster
2019-02-18 13:31 ` [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups no-reply
2019-02-18 17:16 ` no-reply
2019-02-18 17:39 ` no-reply
2019-02-19 4:39 ` no-reply
2019-02-19 4:43 ` no-reply
2019-02-19 13:06 ` no-reply
2019-02-19 13:49 ` no-reply
2019-02-19 13:53 ` no-reply
2019-02-19 16:43 ` no-reply
2019-02-27 15:26 ` no-reply
2019-02-27 17:41 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa7290ec-34e1-2fe7-8bcb-0a9db90bd418@redhat.com \
--to=lersek@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).