Re: [Qemu-devel] [Patch] AltGr on vnc and adding extra keys with no compiling

[Ricardo <ricardo.ribalda@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1718 bytes --]

Hi

  I attach the new patch. PLEASE REMOVE THE OLD ONE!!!, I sent a
completely wrong file :S (sorry).

  I have downloaded de cvs version and patched with this new file, wich solves:

  a) ISO_Level_3 is now correctly reconized as alt gr on vnc mode
  b) User can add its own keysym by number
  c) My sdl library gives two events for cap lock (press and release).
Now it is recognized correctly
  d) Some minor changes in order to compile correctly the program

  Everything has been tested with DOS 7.2 as target.


   Sorry again for the first mistake and congratulations again for a
GREAT program


               Regards

ps: please cc me
On 8/26/07, Thiemo Seufer <ths@networkno.de> wrote:
> Ricardo wrote:
> > Hi
> >
> > On my keyboard Alt Gr is mapped to ISO_Level3_Shift. Using sdl it
> > worked fine without any modification, but using vnc I was unable to
> > use Alt Gr.
> > I added a line on /usr/share/keymaps/modifiers refering to my key:
> >
> > ISO_Level3_Shift 0xb8
> >
> > But, unfortunately it didn't work....
> >
> > Surfing on the qemu code, I realized that the ISO_Level3_Shitf wasn't
> > declared on the vnc_keysym.h file. So I added this line to that file:
> >
> > {"ISO_Level3_Shift", 0xfe03}, /* ISO_Level3
> >
> > And finally Alt Gr worked!
> >
> >
> > I think that it should be a good idea to allow the user to add keysym
> > manually by number and name. Instead of just name. This will allow to
> > add keysyms with no qemu recompiling. this can be done very easilly.
> > Just modfying get_keysym on keymaps.c
> >
> >
> > I attach a pacth with this two improves.
>
> Thanks. Please update it for current CVS and resend.
>
>
> Thiemo
>


-- 
Ricardo Ribalda
http://www.ii.uam.es/~rribalda/

[-- Attachment #2: altgr-capslock-numkeysym.patch --]
[-- Type: text/x-patch, Size: 1448 bytes --]

Index: keymaps.c
===================================================================
RCS file: /sources/qemu/qemu/keymaps.c,v
retrieving revision 1.2
diff -r1.2 keymaps.c
26a27
>     unsigned int keysym;
27a29,34
>    
>     //User numerical added keysyms
>     if (1==sscanf(name,"0x%x",&keysym))
>             return keysym;
>     
>     //Normal ones
Index: sdl.c
===================================================================
RCS file: /sources/qemu/qemu/sdl.c,v
retrieving revision 1.42
diff -r1.42 sdl.c
204,206c204,206
<         /* SDL does not send the key up event, so we generate it */
<         kbd_put_keycode(keycode);
<         kbd_put_keycode(keycode | 0x80);
---
>     	if (ev->type == SDL_KEYUP)
> 		kbd_put_keycode(keycode | 0x80);
> 	else kbd_put_keycode(keycode);	
Index: vnc_keysym.h
===================================================================
RCS file: /sources/qemu/qemu/vnc_keysym.h,v
retrieving revision 1.2
diff -r1.2 vnc_keysym.h
217a218
> {"ISO_Level3_Shift", 0xfe03}, /* ISO_Level3
Index: keymaps/es
===================================================================
RCS file: /sources/qemu/qemu/keymaps/es,v
retrieving revision 1.1
diff -r1.1 es
73a74,75
> 0xfff1 0x27
> 0xffd1 0x27 shift
Index: keymaps/modifiers
===================================================================
RCS file: /sources/qemu/qemu/keymaps/modifiers,v
retrieving revision 1.2
diff -r1.2 modifiers
5a6
> ISO_Level3_Shift 0xb8