From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IPk7J-0003n8-Im for qemu-devel@nongnu.org; Mon, 27 Aug 2007 15:19:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IPk7I-0003mv-56 for qemu-devel@nongnu.org; Mon, 27 Aug 2007 15:19:16 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IPk7I-0003ms-0P for qemu-devel@nongnu.org; Mon, 27 Aug 2007 15:19:16 -0400 Received: from fk-out-0910.google.com ([209.85.128.189]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IPk7H-000803-Jh for qemu-devel@nongnu.org; Mon, 27 Aug 2007 15:19:15 -0400 Received: by fk-out-0910.google.com with SMTP id 19so2591237fkr for ; Mon, 27 Aug 2007 12:19:13 -0700 (PDT) Message-ID: Date: Mon, 27 Aug 2007 15:19:13 -0400 From: Ricardo Subject: Re: [Qemu-devel] [Patch] AltGr on vnc and adding extra keys with no compiling In-Reply-To: <20070826174344.GB4499@networkno.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_150586_32185090.1188242353164" References: <20070826174344.GB4499@networkno.de> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thiemo Seufer Cc: qemu-devel@nongnu.org ------=_Part_150586_32185090.1188242353164 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi I attach the new patch. PLEASE REMOVE THE OLD ONE!!!, I sent a completely wrong file :S (sorry). I have downloaded de cvs version and patched with this new file, wich solves: a) ISO_Level_3 is now correctly reconized as alt gr on vnc mode b) User can add its own keysym by number c) My sdl library gives two events for cap lock (press and release). Now it is recognized correctly d) Some minor changes in order to compile correctly the program Everything has been tested with DOS 7.2 as target. Sorry again for the first mistake and congratulations again for a GREAT program Regards ps: please cc me On 8/26/07, Thiemo Seufer wrote: > Ricardo wrote: > > Hi > > > > On my keyboard Alt Gr is mapped to ISO_Level3_Shift. Using sdl it > > worked fine without any modification, but using vnc I was unable to > > use Alt Gr. > > I added a line on /usr/share/keymaps/modifiers refering to my key: > > > > ISO_Level3_Shift 0xb8 > > > > But, unfortunately it didn't work.... > > > > Surfing on the qemu code, I realized that the ISO_Level3_Shitf wasn't > > declared on the vnc_keysym.h file. So I added this line to that file: > > > > {"ISO_Level3_Shift", 0xfe03}, /* ISO_Level3 > > > > And finally Alt Gr worked! > > > > > > I think that it should be a good idea to allow the user to add keysym > > manually by number and name. Instead of just name. This will allow to > > add keysyms with no qemu recompiling. this can be done very easilly. > > Just modfying get_keysym on keymaps.c > > > > > > I attach a pacth with this two improves. > > Thanks. Please update it for current CVS and resend. > > > Thiemo > -- Ricardo Ribalda http://www.ii.uam.es/~rribalda/ ------=_Part_150586_32185090.1188242353164 Content-Type: text/x-patch; name=altgr-capslock-numkeysym.patch; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: base64 X-Attachment-Id: f_f5vcktgk Content-Disposition: attachment; filename="altgr-capslock-numkeysym.patch" SW5kZXg6IGtleW1hcHMuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvc291cmNlcy9xZW11L3FlbXUv a2V5bWFwcy5jLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjIKZGlmZiAtcjEuMiBrZXltYXBzLmMK MjZhMjcKPiAgICAgdW5zaWduZWQgaW50IGtleXN5bTsKMjdhMjksMzQKPiAgICAKPiAgICAgLy9V c2VyIG51bWVyaWNhbCBhZGRlZCBrZXlzeW1zCj4gICAgIGlmICgxPT1zc2NhbmYobmFtZSwiMHgl eCIsJmtleXN5bSkpCj4gICAgICAgICAgICAgcmV0dXJuIGtleXN5bTsKPiAgICAgCj4gICAgIC8v Tm9ybWFsIG9uZXMKSW5kZXg6IHNkbC5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9zb3VyY2VzL3Fl bXUvcWVtdS9zZGwuYyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS40MgpkaWZmIC1yMS40MiBzZGwu YwoyMDQsMjA2YzIwNCwyMDYKPCAgICAgICAgIC8qIFNETCBkb2VzIG5vdCBzZW5kIHRoZSBrZXkg dXAgZXZlbnQsIHNvIHdlIGdlbmVyYXRlIGl0ICovCjwgICAgICAgICBrYmRfcHV0X2tleWNvZGUo a2V5Y29kZSk7CjwgICAgICAgICBrYmRfcHV0X2tleWNvZGUoa2V5Y29kZSB8IDB4ODApOwotLS0K PiAgICAgCWlmIChldi0+dHlwZSA9PSBTRExfS0VZVVApCj4gCQlrYmRfcHV0X2tleWNvZGUoa2V5 Y29kZSB8IDB4ODApOwo+IAllbHNlIGtiZF9wdXRfa2V5Y29kZShrZXljb2RlKTsJCkluZGV4OiB2 bmNfa2V5c3ltLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL3NvdXJjZXMvcWVtdS9xZW11L3ZuY19r ZXlzeW0uaCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4yCmRpZmYgLXIxLjIgdm5jX2tleXN5bS5o CjIxN2EyMTgKPiB7IklTT19MZXZlbDNfU2hpZnQiLCAweGZlMDN9LCAvKiBJU09fTGV2ZWwzCklu ZGV4OiBrZXltYXBzL2VzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9zb3VyY2VzL3FlbXUvcWVtdS9r ZXltYXBzL2VzLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjEKZGlmZiAtcjEuMSBlcwo3M2E3NCw3 NQo+IDB4ZmZmMSAweDI3Cj4gMHhmZmQxIDB4Mjcgc2hpZnQKSW5kZXg6IGtleW1hcHMvbW9kaWZp ZXJzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9zb3VyY2VzL3FlbXUvcWVtdS9rZXltYXBzL21vZGlm aWVycyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4yCmRpZmYgLXIxLjIgbW9kaWZpZXJzCjVhNgo+ IElTT19MZXZlbDNfU2hpZnQgMHhiOAo= ------=_Part_150586_32185090.1188242353164--