From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IPsgc-0002Mm-IV for qemu-devel@nongnu.org; Tue, 28 Aug 2007 00:28:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IPsgb-0002KF-1Q for qemu-devel@nongnu.org; Tue, 28 Aug 2007 00:28:17 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IPsga-0002Jr-Ql for qemu-devel@nongnu.org; Tue, 28 Aug 2007 00:28:16 -0400 Received: from fk-out-0910.google.com ([209.85.128.190]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IPsga-0004yU-6a for qemu-devel@nongnu.org; Tue, 28 Aug 2007 00:28:16 -0400 Received: by fk-out-0910.google.com with SMTP id 19so2796087fkr for ; Mon, 27 Aug 2007 21:28:15 -0700 (PDT) Message-ID: Date: Tue, 28 Aug 2007 00:28:13 -0400 From: Ricardo Subject: Re: [Qemu-devel] [Patch] AltGr on vnc and adding extra keys with no compiling In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_155703_30483803.1188275293598" References: <20070826174344.GB4499@networkno.de> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thiemo Seufer Cc: qemu-devel@nongnu.org ------=_Part_155703_30483803.1188275293598 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi all I find out that in DOS some programs didn't handle correctly the extended keyboard. Attach you will find a new patch with the bugs solved on the previous patch + this new bug. Regards On 8/27/07, Ricardo wrote: > Hi > > I attach the new patch. PLEASE REMOVE THE OLD ONE!!!, I sent a > completely wrong file :S (sorry). > > I have downloaded de cvs version and patched with this new file, wich solves: > > a) ISO_Level_3 is now correctly reconized as alt gr on vnc mode > b) User can add its own keysym by number > c) My sdl library gives two events for cap lock (press and release). > Now it is recognized correctly > d) Some minor changes in order to compile correctly the program > > Everything has been tested with DOS 7.2 as target. > > > Sorry again for the first mistake and congratulations again for a > GREAT program > > > Regards > > ps: please cc me > On 8/26/07, Thiemo Seufer wrote: > > Ricardo wrote: > > > Hi > > > > > > On my keyboard Alt Gr is mapped to ISO_Level3_Shift. Using sdl it > > > worked fine without any modification, but using vnc I was unable to > > > use Alt Gr. > > > I added a line on /usr/share/keymaps/modifiers refering to my key: > > > > > > ISO_Level3_Shift 0xb8 > > > > > > But, unfortunately it didn't work.... > > > > > > Surfing on the qemu code, I realized that the ISO_Level3_Shitf wasn't > > > declared on the vnc_keysym.h file. So I added this line to that file: > > > > > > {"ISO_Level3_Shift", 0xfe03}, /* ISO_Level3 > > > > > > And finally Alt Gr worked! > > > > > > > > > I think that it should be a good idea to allow the user to add keysym > > > manually by number and name. Instead of just name. This will allow to > > > add keysyms with no qemu recompiling. this can be done very easilly. > > > Just modfying get_keysym on keymaps.c > > > > > > > > > I attach a pacth with this two improves. > > > > Thanks. Please update it for current CVS and resend. > > > > > > Thiemo > > > > > -- > Ricardo Ribalda > http://www.ii.uam.es/~rribalda/ > > -- Ricardo Ribalda http://www.ii.uam.es/~rribalda/ ------=_Part_155703_30483803.1188275293598 Content-Type: application/octet-stream; name=altgr-capslock-numkeysym-extendedkb.dff Content-Transfer-Encoding: base64 X-Attachment-Id: f_f5vwbo8t Content-Disposition: attachment; filename="altgr-capslock-numkeysym-extendedkb.dff" PyBiYWNrdXAtMDgyNzIwMDcyMzI2LXByZS1xZW11LnRnego/IGRlc2NyaXB0aW9uLXBhawo/IGRv Yy1wYWsKPyBxZW11XzIwMDcwODI3LTFfaTM4Ni5kZWIKSW5kZXg6IGtleW1hcHMuYwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09ClJDUyBmaWxlOiAvc291cmNlcy9xZW11L3FlbXUva2V5bWFwcy5jLHYKcmV0cmlldmluZyBy ZXZpc2lvbiAxLjIKZGlmZiAtdSAtcjEuMiBrZXltYXBzLmMKLS0tIGtleW1hcHMuYwkzMCBBcHIg MjAwNiAyMToyODozNSAtMDAwMAkxLjIKKysrIGtleW1hcHMuYwkyOCBBdWcgMjAwNyAwNDowODox NyAtMDAwMApAQCAtMjQsNyArMjQsMTQgQEAKIAogc3RhdGljIGludCBnZXRfa2V5c3ltKGNvbnN0 IGNoYXIgKm5hbWUpCiB7CisgICAgdW5zaWduZWQgaW50IGtleXN5bTsKICAgICBuYW1lMmtleXN5 bV90ICpwOworICAgCisgICAgLy9Vc2VyIG51bWVyaWNhbCBhZGRlZCBrZXlzeW1zCisgICAgaWYg KDE9PXNzY2FuZihuYW1lLCIweCV4Iiwma2V5c3ltKSkKKyAgICAgICAgICAgIHJldHVybiBrZXlz eW07CisgICAgCisgICAgLy9Ob3JtYWwgb25lcwogICAgIGZvcihwID0gbmFtZTJrZXlzeW07IHAt Pm5hbWUgIT0gTlVMTDsgcCsrKSB7CiAgICAgICAgIGlmICghc3RyY21wKHAtPm5hbWUsIG5hbWUp KQogICAgICAgICAgICAgcmV0dXJuIHAtPmtleXN5bTsKSW5kZXg6IHNkbC5jCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K UkNTIGZpbGU6IC9zb3VyY2VzL3FlbXUvcWVtdS9zZGwuYyx2CnJldHJpZXZpbmcgcmV2aXNpb24g MS40MgpkaWZmIC11IC1yMS40MiBzZGwuYwotLS0gc2RsLmMJMjEgSnVuIDIwMDcgMjE6MDg6MDIg LTAwMDAJMS40MgorKysgc2RsLmMJMjggQXVnIDIwMDcgMDQ6MDk6MTkgLTAwMDAKQEAgLTIwMSw5 ICsyMDEsOSBAQAogICAgICAgICBicmVhazsKICAgICBjYXNlIDB4NDU6IC8qIG51bSBsb2NrICov CiAgICAgY2FzZSAweDNhOiAvKiBjYXBzIGxvY2sgKi8KLSAgICAgICAgLyogU0RMIGRvZXMgbm90 IHNlbmQgdGhlIGtleSB1cCBldmVudCwgc28gd2UgZ2VuZXJhdGUgaXQgKi8KLSAgICAgICAga2Jk X3B1dF9rZXljb2RlKGtleWNvZGUpOwotICAgICAgICBrYmRfcHV0X2tleWNvZGUoa2V5Y29kZSB8 IDB4ODApOworICAgIAlpZiAoZXYtPnR5cGUgPT0gU0RMX0tFWVVQKQorCQlrYmRfcHV0X2tleWNv ZGUoa2V5Y29kZSB8IDB4ODApOworCWVsc2Uga2JkX3B1dF9rZXljb2RlKGtleWNvZGUpOwkKICAg ICAgICAgcmV0dXJuOwogICAgIH0KIApJbmRleDogdm5jX2tleXN5bS5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNT IGZpbGU6IC9zb3VyY2VzL3FlbXUvcWVtdS92bmNfa2V5c3ltLmgsdgpyZXRyaWV2aW5nIHJldmlz aW9uIDEuMgpkaWZmIC11IC1yMS4yIHZuY19rZXlzeW0uaAotLS0gdm5jX2tleXN5bS5oCTcgSmFu IDIwMDcgMTc6MTI6NDEgLTAwMDAJMS4yCisrKyB2bmNfa2V5c3ltLmgJMjggQXVnIDIwMDcgMDQ6 MTA6MTIgLTAwMDAKQEAgLTIxNSw2ICsyMTUsNyBAQAogeyJTaGlmdF9SIiwgMHhmZmUyfSwgICAv KiBYS19TaGlmdF9SICovCiB7IlN1cGVyX0wiLCAweGZmZWJ9LCAgIC8qIFhLX1N1cGVyX0wgKi8K IHsiU3VwZXJfUiIsIDB4ZmZlY30sICAgLyogWEtfU3VwZXJfUiAqLworeyJJU09fTGV2ZWwzX1No aWZ0IiwgMHhmZTAzfSwgLyogSVNPX0xldmVsMwogCiAgICAgLyogc3BlY2lhbCBrZXlzICovCiB7 IkJhY2tTcGFjZSIsIDB4ZmYwOH0sIC8qIFhLX0JhY2tTcGFjZSAqLwpJbmRleDogaHcvcHMyLmMK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQpSQ1MgZmlsZTogL3NvdXJjZXMvcWVtdS9xZW11L2h3L3BzMi5jLHYKcmV0cmll dmluZyByZXZpc2lvbiAxLjYKZGlmZiAtdSAtcjEuNiBwczIuYwotLS0gaHcvcHMyLmMJMjAgTWFy IDIwMDcgMTY6NDU6MjcgLTAwMDAJMS42CisrKyBody9wczIuYwkyOCBBdWcgMjAwNyAwNDoxMjo0 OCAtMDAwMApAQCAtMTQ2LDE3ICsxNDYsMjQgQEAKICAgICBQUzJTdGF0ZSAqcyA9IChQUzJTdGF0 ZSAqKW9wYXF1ZTsKICAgICBQUzJRdWV1ZSAqcTsKICAgICBpbnQgdmFsLCBpbmRleDsKKyAgICBz dGF0aWMgaW50IGZsYWc9MDsKICAgICAKICAgICBxID0gJnMtPnF1ZXVlOwogICAgIGlmIChxLT5j b3VudCA9PSAwKSB7CisJaWYgKCFmbGFnKXsKKwkgICBpbmRleD1xLT5ycHRyIC0gMTsKKwkgICBm bGFnPTE7CisJfQorCWVsc2UgaW5kZXg9cS0+cnB0ciAtIDI7CiAgICAgICAgIC8qIE5PVEU6IGlm IG5vIGRhdGEgbGVmdCwgd2UgcmV0dXJuIHRoZSBsYXN0IGtleWJvYXJkIG9uZQogICAgICAgICAg ICAobmVlZGVkIGZvciBFTU0zODYpICovCiAgICAgICAgIC8qIFhYWDogbmVlZCBhIHRpbWVyIHRv IGRvIHRoaW5ncyBjb3JyZWN0bHkgKi8KLSAgICAgICAgaW5kZXggPSBxLT5ycHRyIC0gMTsKICAg ICAgICAgaWYgKGluZGV4IDwgMCkKLSAgICAgICAgICAgIGluZGV4ID0gUFMyX1FVRVVFX1NJWkUg LSAxOworICAgICAgICAgICAgaW5kZXggKz0gUFMyX1FVRVVFX1NJWkU7CisKICAgICAgICAgdmFs ID0gcS0+ZGF0YVtpbmRleF07CiAgICAgfSBlbHNlIHsKKwlmbGFnPTA7CiAgICAgICAgIHZhbCA9 IHEtPmRhdGFbcS0+cnB0cl07CiAgICAgICAgIGlmICgrK3EtPnJwdHIgPT0gUFMyX1FVRVVFX1NJ WkUpCiAgICAgICAgICAgICBxLT5ycHRyID0gMDsKSW5kZXg6IGtleW1hcHMvZXMKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQpSQ1MgZmlsZTogL3NvdXJjZXMvcWVtdS9xZW11L2tleW1hcHMvZXMsdgpyZXRyaWV2aW5nIHJl dmlzaW9uIDEuMQpkaWZmIC11IC1yMS4xIGVzCi0tLSBrZXltYXBzL2VzCTEyIERlYyAyMDA0IDE2 OjU2OjMwIC0wMDAwCTEuMQorKysga2V5bWFwcy9lcwkyOCBBdWcgMjAwNyAwNDoxMzo1NyAtMDAw MApAQCAtNzEsNiArNzEsOCBAQAogTHN0cm9rZSAweDI2IHNoaWZ0IGFsdGdyCiBudGlsZGUgMHgy NwogTnRpbGRlIDB4Mjcgc2hpZnQKKzB4ZmZmMSAweDI3CisweGZmZDEgMHgyNyBzaGlmdAogZGVh ZF9kb3VibGVhY3V0ZSAweDI3IHNoaWZ0IGFsdGdyCiBkZWFkX2FjdXRlIDB4MjgKIGRlYWRfZGlh ZXJlc2lzIDB4Mjggc2hpZnQKSW5kZXg6IGtleW1hcHMvbW9kaWZpZXJzCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNT IGZpbGU6IC9zb3VyY2VzL3FlbXUvcWVtdS9rZXltYXBzL21vZGlmaWVycyx2CnJldHJpZXZpbmcg cmV2aXNpb24gMS4yCmRpZmYgLXUgLXIxLjIgbW9kaWZpZXJzCi0tLSBrZXltYXBzL21vZGlmaWVy cwkxIE1hciAyMDA1IDIxOjQzOjQyIC0wMDAwCTEuMgorKysga2V5bWFwcy9tb2RpZmllcnMJMjgg QXVnIDIwMDcgMDQ6MTM6NTkgLTAwMDAKQEAgLTMsNiArMyw3IEBACiAKIEFsdF9SIDB4YjgKIE1v ZGVfc3dpdGNoIDB4YjgKK0lTT19MZXZlbDNfU2hpZnQgMHhiOAogQWx0X0wgMHgzOAogCiBDb250 cm9sX1IgMHg5ZAo= ------=_Part_155703_30483803.1188275293598--