From: Max Reitz <mreitz@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 07/10] file-posix: Forbid trying to change unsupported options during reopen
Date: Wed, 5 Sep 2018 14:49:22 +0200 [thread overview]
Message-ID: <aa77ca0f-2138-5e57-850c-9e9999b538c5@redhat.com> (raw)
In-Reply-To: <5e84c28e4ed8ac259665c7e0c0baa028668ac0b2.1535983918.git.berto@igalia.com>
[-- Attachment #1: Type: text/plain, Size: 765 bytes --]
On 2018-09-03 16:34, Alberto Garcia wrote:
> The file-posix code is used for the "file", "host_device" and
> "host_cdrom" drivers, and it allows reopening images. However the only
> option that is actually processed is "x-check-cache-dropped", and
> changes in all other options (e.g. "filename") are silently ignored:
>
> (qemu) qemu-io virtio0 "reopen -o file.filename=no-such-file"
>
> While we could allow changing some of the other options, let's keep
> things as they are for now but return an error if the user tries to
> change any of them.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
> block/file-posix.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-09-05 12:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 14:33 [Qemu-devel] [PATCH v2 00/10] Misc reopen-related patches Alberto Garcia
2018-09-03 14:33 ` [Qemu-devel] [PATCH v2 01/10] qemu-io: Fix writethrough check in reopen Alberto Garcia
2018-09-03 14:34 ` [Qemu-devel] [PATCH v2 02/10] file-posix: x-check-cache-dropped should default to false on reopen Alberto Garcia
2018-09-03 14:34 ` [Qemu-devel] [PATCH v2 03/10] block: Remove child references from bs->{options, explicit_options} Alberto Garcia
2018-09-05 12:37 ` Max Reitz
2018-09-03 14:34 ` [Qemu-devel] [PATCH v2 04/10] block: Don't look for child references in append_open_options() Alberto Garcia
2018-09-03 14:34 ` [Qemu-devel] [PATCH v2 05/10] block: Allow child references on reopen Alberto Garcia
2018-09-05 12:40 ` Max Reitz
2018-09-03 14:34 ` [Qemu-devel] [PATCH v2 06/10] block: Forbid trying to change unsupported options during reopen Alberto Garcia
2018-09-05 12:48 ` Max Reitz
2018-09-03 14:34 ` [Qemu-devel] [PATCH v2 07/10] file-posix: " Alberto Garcia
2018-09-05 12:49 ` Max Reitz [this message]
2018-09-03 14:34 ` [Qemu-devel] [PATCH v2 08/10] block: Allow changing 'discard' on reopen Alberto Garcia
2018-09-05 12:50 ` Max Reitz
2018-09-05 16:53 ` Alberto Garcia
2018-09-03 14:34 ` [Qemu-devel] [PATCH v2 09/10] block: Allow changing 'detect-zeroes' " Alberto Garcia
2018-09-05 12:52 ` Max Reitz
2018-09-03 14:34 ` [Qemu-devel] [PATCH v2 10/10] block: Allow changing 'force-share' " Alberto Garcia
2018-09-05 12:56 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa77ca0f-2138-5e57-850c-9e9999b538c5@redhat.com \
--to=mreitz@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).