From: Paolo Bonzini <pbonzini@redhat.com>
To: "Max Reitz" <mreitz@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Segfaults in chardev due to races
Date: Sat, 22 Dec 2018 10:17:04 +0100 [thread overview]
Message-ID: <aa77e2fd-d6ac-52a5-0a00-f69c90c27ded@redhat.com> (raw)
In-Reply-To: <f10356c5-c6db-8019-62e4-8ef41e607bf1@redhat.com>
On 21/12/18 23:31, Max Reitz wrote:
> I suppose the issue is that QMP events are sent by one thread, and
> client disconnects are handled by a different one. So if a QMP event is
> sent while a client disconnects concurrently, races may occur; and the
> only protection against concurrent access appears to be the
> chr_write_lock, which I don't think is enough.
I think disconnection (tcp_chr_disconnect) has to take the
chr_write_lock too.
Paolo
next prev parent reply other threads:[~2018-12-22 9:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 22:31 [Qemu-devel] Segfaults in chardev due to races Max Reitz
2018-12-22 9:17 ` Paolo Bonzini [this message]
2019-01-23 15:33 ` Max Reitz
2019-02-06 18:38 ` Marc-André Lureau
2019-02-11 6:13 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa77e2fd-d6ac-52a5-0a00-f69c90c27ded@redhat.com \
--to=pbonzini@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).