From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1728C38145 for ; Thu, 8 Sep 2022 08:58:26 +0000 (UTC) Received: from localhost ([::1]:54876 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oWDMf-00070j-KW for qemu-devel@archiver.kernel.org; Thu, 08 Sep 2022 04:58:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34538) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWDKr-00067X-Bd for qemu-devel@nongnu.org; Thu, 08 Sep 2022 04:56:33 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:37517) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oWDKo-0005MK-DJ for qemu-devel@nongnu.org; Thu, 08 Sep 2022 04:56:33 -0400 Received: by mail-wm1-x32b.google.com with SMTP id c2-20020a1c3502000000b003b2973dafb7so1174021wma.2 for ; Thu, 08 Sep 2022 01:56:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=qoTdlrv10QCxPj+s+B5pycDU3Um/SUWmOLHrVeUmAMo=; b=r+cDbeu0Ao1SNGrywJs2Bdp8sTiirLHcEBI/TyphMolE+Y/QRsf9PsU4kjL4h56cvR vENI4tY+/n9ANLByR9ndjZqwAAnuXIWYPJleRuXTuU3t3aYEFHF0ub6mdIdXp+Ev7efa Fq8lng98UmJJ0dBF8Wm1Ncfnrp1qXw+696AXbZ7X1NLmOqcTgKshdA3FGLYqhhQGqDBg KIl44Ulmv7Cx4UrCUv7FGjmsDbL2Tvgnx1FsJAC5mLOfj5pZMezfu/wBax5+3lD1LG2/ VDQWuwvQ5xFWcboysKRDvIrr0uOI/a2QlUsbiwA8KFzS5T06SKfug0yOvAD8U+v8OGLf Bu9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=qoTdlrv10QCxPj+s+B5pycDU3Um/SUWmOLHrVeUmAMo=; b=PM5r4vyX6Y2+XERnWO46AiUiQSGrLKmPpC0E9UjLuOAMTlw0XbXhEwxG8mFxBjv27E 96I9TWzlMhG0G7UbCJyoghF37GshO20sBxyGqNtPiFjDqG5nfnpYyt+RPVE7TPzWLEK1 vUs2IouObfsmMhs6uneLRuroGy+/4YlRvbjb6Rp/XAVZlUsDiCJ5rn6GN6YGmcN8Zsvf dGHT1RhhE2kTPqLKthKsKjwBrtdzrKDz75lo7oQIRDZZkgWEIadl8PRulkZbgKmlByiW 84dYyICVtVe7RZY3w4+CwJeu2nFVQxAEp0p/NHyLd8hqVTmaFzpnScymtJrJGu6PwHzp tOyg== X-Gm-Message-State: ACgBeo0vtmM3wsnzsAylZi9DP7GD9uAFC9ocPjGjEOY2BB9QMNm6Nah1 lkPbu+67afLSLoWSP9tQYhspYA== X-Google-Smtp-Source: AA6agR6Q0vi3ta1KpENIbqVtiI9ZJ49UKxjVfqRGiXMcW5WOGFYUtsj4t3CJ8W+1m65OrV8yC8QPhQ== X-Received: by 2002:a7b:c045:0:b0:3a5:ff4e:5528 with SMTP id u5-20020a7bc045000000b003a5ff4e5528mr1567622wmc.150.1662627387837; Thu, 08 Sep 2022 01:56:27 -0700 (PDT) Received: from [192.168.1.87] ([109.78.97.14]) by smtp.gmail.com with ESMTPSA id c11-20020a5d528b000000b0021e42e7c7dbsm18946701wrv.83.2022.09.08.01.56.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Sep 2022 01:56:27 -0700 (PDT) Message-ID: Date: Thu, 8 Sep 2022 09:56:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 11/11] RISC-V: Add initial support for T-Head C906 and C910 CPUs Content-Language: en-US To: =?UTF-8?Q?Christoph_M=c3=bcllner?= Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org, Alistair Francis , Bin Meng , Philipp Tomsich , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Palmer Dabbelt , Nelson Chu , Kito Cheng , Cooper Qu , Lifang Xia , Yunhai Shang , Zhiwei Liu References: <20220906122243.1243354-1-christoph.muellner@vrull.eu> <20220906122243.1243354-12-christoph.muellner@vrull.eu> <9eba2b9e-ebe0-bf2d-2dc7-75ae81b0592e@linaro.org> From: Richard Henderson In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -62 X-Spam_score: -6.3 X-Spam_bar: ------ X-Spam_report: (-6.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-4.199, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/8/22 09:23, Christoph Müllner wrote: > > > On Thu, Sep 8, 2022 at 9:46 AM Richard Henderson > wrote: > > On 9/6/22 13:22, Christoph Muellner wrote: > > +    DEFINE_CPU(TYPE_RISCV_CPU_THEAD_C906,       rv64_thead_c906_cpu_init), > > +    DEFINE_CPU(TYPE_RISCV_CPU_THEAD_C910,       rv64_thead_c906_cpu_init), > > Why model both if they're identical? > > > I figured that users might expect that (existence of "thead-c906" and "thead-c910"). > And using "thead-c9xx" feels like it would be regretted in the future. > > Should I drop "thead-c910"? Quite possibly. For Arm, we don't try to supply every cpu model, only those that differ in some substantial way. r~