public inbox for qemu-devel@nongnu.org
 help / color / mirror / Atom feed
* [PATCH 0/4] hw/i386/pc: Remove deprecated 3.0 machines
@ 2026-03-07 15:00 Philippe Mathieu-Daudé
  2026-03-07 15:00 ` [PATCH 1/4] hw/i386/pc: Remove deprecated pc-q35-3.0 and pc-i440fx-3.0 machines Philippe Mathieu-Daudé
                   ` (4 more replies)
  0 siblings, 5 replies; 15+ messages in thread
From: Philippe Mathieu-Daudé @ 2026-03-07 15:00 UTC (permalink / raw)
  To: qemu-devel
  Cc: Michael S. Tsirkin, Paolo Bonzini, Zhao Liu,
	Philippe Mathieu-Daudé, Thomas Huth, Marcelo Tosatti

1 y.o. dust Thomas asked me to post:

The versioned 'pc' and 'q35' machines up to 3.0 been marked
as deprecated two releases ago, and are older than 6 years,
so according to our support policy we can remove them.

Philippe Mathieu-Daudé (4):
  hw/i386/pc: Remove deprecated pc-q35-3.0 and pc-i440fx-3.0 machines
  hw/i386/pc: Remove pc_compat_3_0[] array
  target/i386/kvm: Remove X86CPU::hyperv_synic_kvm_only field
  hw/core/machine: Remove the hw_compat_3_0[] array

 include/hw/core/boards.h |  3 ---
 include/hw/i386/pc.h     |  3 ---
 target/i386/cpu.h        |  1 -
 hw/core/machine.c        |  3 ---
 hw/i386/pc.c             |  7 -------
 hw/i386/pc_piix.c        |  9 ---------
 hw/i386/pc_q35.c         |  9 ---------
 target/i386/cpu.c        |  2 --
 target/i386/kvm/kvm.c    | 15 ++++-----------
 9 files changed, 4 insertions(+), 48 deletions(-)

-- 
2.52.0



^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH 1/4] hw/i386/pc: Remove deprecated pc-q35-3.0 and pc-i440fx-3.0 machines
  2026-03-07 15:00 [PATCH 0/4] hw/i386/pc: Remove deprecated 3.0 machines Philippe Mathieu-Daudé
@ 2026-03-07 15:00 ` Philippe Mathieu-Daudé
  2026-03-08 11:36   ` Thomas Huth
  2026-03-09 13:59   ` Zhao Liu
  2026-03-07 15:00 ` [PATCH 2/4] hw/i386/pc: Remove pc_compat_3_0[] array Philippe Mathieu-Daudé
                   ` (3 subsequent siblings)
  4 siblings, 2 replies; 15+ messages in thread
From: Philippe Mathieu-Daudé @ 2026-03-07 15:00 UTC (permalink / raw)
  To: qemu-devel
  Cc: Michael S. Tsirkin, Paolo Bonzini, Zhao Liu,
	Philippe Mathieu-Daudé, Thomas Huth, Marcelo Tosatti,
	Richard Henderson, Eduardo Habkost, Marcel Apfelbaum

These machines has been supported for a period of more than 6 years.
According to our versioned machine support policy (see commit
ce80c4fa6ff "docs: document special exception for machine type
deprecation & removal") they can now be removed.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/i386/pc_piix.c | 9 ---------
 hw/i386/pc_q35.c  | 9 ---------
 2 files changed, 18 deletions(-)

diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 961432176cf..29c8e997131 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -668,15 +668,6 @@ static void pc_i440fx_machine_3_1_options(MachineClass *m)
 
 DEFINE_I440FX_MACHINE(3, 1);
 
-static void pc_i440fx_machine_3_0_options(MachineClass *m)
-{
-    pc_i440fx_machine_3_1_options(m);
-    compat_props_add(m->compat_props, hw_compat_3_0, hw_compat_3_0_len);
-    compat_props_add(m->compat_props, pc_compat_3_0, pc_compat_3_0_len);
-}
-
-DEFINE_I440FX_MACHINE(3, 0);
-
 #ifdef CONFIG_XEN
 static void xenfv_machine_4_2_options(MachineClass *m)
 {
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index 261d759a223..f102da8e4a1 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -614,12 +614,3 @@ static void pc_q35_machine_3_1_options(MachineClass *m)
 }
 
 DEFINE_Q35_MACHINE(3, 1);
-
-static void pc_q35_machine_3_0_options(MachineClass *m)
-{
-    pc_q35_machine_3_1_options(m);
-    compat_props_add(m->compat_props, hw_compat_3_0, hw_compat_3_0_len);
-    compat_props_add(m->compat_props, pc_compat_3_0, pc_compat_3_0_len);
-}
-
-DEFINE_Q35_MACHINE(3, 0);
-- 
2.52.0



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 2/4] hw/i386/pc: Remove pc_compat_3_0[] array
  2026-03-07 15:00 [PATCH 0/4] hw/i386/pc: Remove deprecated 3.0 machines Philippe Mathieu-Daudé
  2026-03-07 15:00 ` [PATCH 1/4] hw/i386/pc: Remove deprecated pc-q35-3.0 and pc-i440fx-3.0 machines Philippe Mathieu-Daudé
@ 2026-03-07 15:00 ` Philippe Mathieu-Daudé
  2026-03-08 11:36   ` Thomas Huth
  2026-03-09 14:00   ` Zhao Liu
  2026-03-07 15:00 ` [PATCH 3/4] target/i386/kvm: Remove X86CPU::hyperv_synic_kvm_only field Philippe Mathieu-Daudé
                   ` (2 subsequent siblings)
  4 siblings, 2 replies; 15+ messages in thread
From: Philippe Mathieu-Daudé @ 2026-03-07 15:00 UTC (permalink / raw)
  To: qemu-devel
  Cc: Michael S. Tsirkin, Paolo Bonzini, Zhao Liu,
	Philippe Mathieu-Daudé, Thomas Huth, Marcelo Tosatti,
	Richard Henderson, Eduardo Habkost, Marcel Apfelbaum

The pc_compat_3_0[] array was only used by the pc-q35-3.0
and pc-i440fx-3.0 machines, which got removed. Remove it.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/hw/i386/pc.h | 3 ---
 hw/i386/pc.c         | 7 -------
 2 files changed, 10 deletions(-)

diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 113813c07d7..5623660f5dd 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -277,9 +277,6 @@ extern const size_t pc_compat_4_0_len;
 extern GlobalProperty pc_compat_3_1[];
 extern const size_t pc_compat_3_1_len;
 
-extern GlobalProperty pc_compat_3_0[];
-extern const size_t pc_compat_3_0_len;
-
 #define DEFINE_PC_MACHINE(suffix, namestr, initfn, optsfn) \
     static void pc_machine_##suffix##_class_init(ObjectClass *oc, \
                                                  const void *data) \
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 819e729a6e3..a38634e3577 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -214,13 +214,6 @@ GlobalProperty pc_compat_3_1[] = {
 };
 const size_t pc_compat_3_1_len = G_N_ELEMENTS(pc_compat_3_1);
 
-GlobalProperty pc_compat_3_0[] = {
-    { TYPE_X86_CPU, "x-hv-synic-kvm-only", "on" },
-    { "Skylake-Server" "-" TYPE_X86_CPU, "pku", "off" },
-    { "Skylake-Server-IBRS" "-" TYPE_X86_CPU, "pku", "off" },
-};
-const size_t pc_compat_3_0_len = G_N_ELEMENTS(pc_compat_3_0);
-
 /*
  * @PC_FW_DATA:
  * Size of the chunk of memory at the top of RAM for the BIOS ACPI tables
-- 
2.52.0



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 3/4] target/i386/kvm: Remove X86CPU::hyperv_synic_kvm_only field
  2026-03-07 15:00 [PATCH 0/4] hw/i386/pc: Remove deprecated 3.0 machines Philippe Mathieu-Daudé
  2026-03-07 15:00 ` [PATCH 1/4] hw/i386/pc: Remove deprecated pc-q35-3.0 and pc-i440fx-3.0 machines Philippe Mathieu-Daudé
  2026-03-07 15:00 ` [PATCH 2/4] hw/i386/pc: Remove pc_compat_3_0[] array Philippe Mathieu-Daudé
@ 2026-03-07 15:00 ` Philippe Mathieu-Daudé
  2026-03-08 11:38   ` Thomas Huth
  2026-03-09 14:03   ` Zhao Liu
  2026-03-07 15:00 ` [PATCH 4/4] hw/core/machine: Remove the hw_compat_3_0[] array Philippe Mathieu-Daudé
  2026-03-08 21:48 ` [PATCH 0/4] hw/i386/pc: Remove deprecated 3.0 machines Philippe Mathieu-Daudé
  4 siblings, 2 replies; 15+ messages in thread
From: Philippe Mathieu-Daudé @ 2026-03-07 15:00 UTC (permalink / raw)
  To: qemu-devel
  Cc: Michael S. Tsirkin, Paolo Bonzini, Zhao Liu,
	Philippe Mathieu-Daudé, Thomas Huth, Marcelo Tosatti, kvm

The X86CPU::hyperv_synic_kvm_only boolean (see commit 9b4cf107b09
"hyperv: only add SynIC in compatible configurations") was only set
in the pc_compat_3_0[] array, via the 'x-hv-synic-kvm-only=on'
property. We removed all machines using that array, lets remove that
property and all the code around it.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/i386/cpu.h     |  1 -
 target/i386/cpu.c     |  2 --
 target/i386/kvm/kvm.c | 15 ++++-----------
 3 files changed, 4 insertions(+), 14 deletions(-)

diff --git a/target/i386/cpu.h b/target/i386/cpu.h
index f2679cc5b72..2b70d56e9b0 100644
--- a/target/i386/cpu.h
+++ b/target/i386/cpu.h
@@ -2335,7 +2335,6 @@ struct ArchCPU {
 
     uint32_t hyperv_spinlock_attempts;
     char *hyperv_vendor;
-    bool hyperv_synic_kvm_only;
     uint64_t hyperv_features;
     bool hyperv_passthrough;
     OnOffAuto hyperv_no_nonarch_cs;
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 01b64940b17..c77addd2c25 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -10589,8 +10589,6 @@ static const Property x86_cpu_properties[] = {
      * to the specific Windows version being used."
      */
     DEFINE_PROP_INT32("x-hv-max-vps", X86CPU, hv_max_vps, -1),
-    DEFINE_PROP_BOOL("x-hv-synic-kvm-only", X86CPU, hyperv_synic_kvm_only,
-                     false),
     DEFINE_PROP_BOOL("x-intel-pt-auto-level", X86CPU, intel_pt_auto_level,
                      true),
     DEFINE_PROP_BOOL("x-l1-cache-per-thread", X86CPU, l1_cache_per_core, true),
diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
index 27b1b848d6a..a29f757c168 100644
--- a/target/i386/kvm/kvm.c
+++ b/target/i386/kvm/kvm.c
@@ -1278,10 +1278,7 @@ static struct kvm_cpuid2 *get_supported_hv_cpuid_legacy(CPUState *cs)
     }
 
     if (has_msr_hv_synic) {
-        unsigned int cap = cpu->hyperv_synic_kvm_only ?
-            KVM_CAP_HYPERV_SYNIC : KVM_CAP_HYPERV_SYNIC2;
-
-        if (kvm_check_extension(cs->kvm_state, cap) > 0) {
+        if (kvm_check_extension(cs->kvm_state, KVM_CAP_HYPERV_SYNIC2) > 0) {
             entry_feat->eax |= HV_SYNIC_AVAILABLE;
         }
     }
@@ -1543,7 +1540,6 @@ bool kvm_hyperv_expand_features(X86CPU *cpu, Error **errp)
 
     /* Additional dependencies not covered by kvm_hyperv_properties[] */
     if (hyperv_feat_enabled(cpu, HYPERV_FEAT_SYNIC) &&
-        !cpu->hyperv_synic_kvm_only &&
         !hyperv_feat_enabled(cpu, HYPERV_FEAT_VPINDEX)) {
         error_setg(errp, "Hyper-V %s requires Hyper-V %s",
                    kvm_hyperv_properties[HYPERV_FEAT_SYNIC].desc,
@@ -1608,8 +1604,7 @@ static int hyperv_fill_cpuids(CPUState *cs,
     c->eax |= HV_HYPERCALL_AVAILABLE;
 
     /* SynIC and Vmbus devices require messages/signals hypercalls */
-    if (hyperv_feat_enabled(cpu, HYPERV_FEAT_SYNIC) &&
-        !cpu->hyperv_synic_kvm_only) {
+    if (hyperv_feat_enabled(cpu, HYPERV_FEAT_SYNIC)) {
         c->ebx |= HV_POST_MESSAGES | HV_SIGNAL_EVENTS;
     }
 
@@ -1752,16 +1747,14 @@ static int hyperv_init_vcpu(X86CPU *cpu)
     }
 
     if (hyperv_feat_enabled(cpu, HYPERV_FEAT_SYNIC)) {
-        uint32_t synic_cap = cpu->hyperv_synic_kvm_only ?
-            KVM_CAP_HYPERV_SYNIC : KVM_CAP_HYPERV_SYNIC2;
-        ret = kvm_vcpu_enable_cap(cs, synic_cap, 0);
+        ret = kvm_vcpu_enable_cap(cs, KVM_CAP_HYPERV_SYNIC2, 0);
         if (ret < 0) {
             error_report("failed to turn on HyperV SynIC in KVM: %s",
                          strerror(-ret));
             return ret;
         }
 
-        if (!cpu->hyperv_synic_kvm_only && !hyperv_is_synic_enabled()) {
+        if (!hyperv_is_synic_enabled()) {
             ret = hyperv_x86_synic_add(cpu);
             if (ret < 0) {
                 error_report("failed to create HyperV SynIC: %s",
-- 
2.52.0



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 4/4] hw/core/machine: Remove the hw_compat_3_0[] array
  2026-03-07 15:00 [PATCH 0/4] hw/i386/pc: Remove deprecated 3.0 machines Philippe Mathieu-Daudé
                   ` (2 preceding siblings ...)
  2026-03-07 15:00 ` [PATCH 3/4] target/i386/kvm: Remove X86CPU::hyperv_synic_kvm_only field Philippe Mathieu-Daudé
@ 2026-03-07 15:00 ` Philippe Mathieu-Daudé
  2026-03-08 11:39   ` Thomas Huth
  2026-03-09 14:04   ` Zhao Liu
  2026-03-08 21:48 ` [PATCH 0/4] hw/i386/pc: Remove deprecated 3.0 machines Philippe Mathieu-Daudé
  4 siblings, 2 replies; 15+ messages in thread
From: Philippe Mathieu-Daudé @ 2026-03-07 15:00 UTC (permalink / raw)
  To: qemu-devel
  Cc: Michael S. Tsirkin, Paolo Bonzini, Zhao Liu,
	Philippe Mathieu-Daudé, Thomas Huth, Marcelo Tosatti,
	Eduardo Habkost, Marcel Apfelbaum, Yanan Wang

The hw_compat_3_0[] array was only used by the pc-q35-3.0
and pc-i440fx-3.0 machines, which got removed. Remove it.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/hw/core/boards.h | 3 ---
 hw/core/machine.c        | 3 ---
 2 files changed, 6 deletions(-)

diff --git a/include/hw/core/boards.h b/include/hw/core/boards.h
index f4ee68bbea5..9ad2a7d5c97 100644
--- a/include/hw/core/boards.h
+++ b/include/hw/core/boards.h
@@ -871,7 +871,4 @@ extern const size_t hw_compat_4_0_len;
 extern GlobalProperty hw_compat_3_1[];
 extern const size_t hw_compat_3_1_len;
 
-extern GlobalProperty hw_compat_3_0[];
-extern const size_t hw_compat_3_0_len;
-
 #endif
diff --git a/hw/core/machine.c b/hw/core/machine.c
index 4770618b559..162600425b0 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -238,9 +238,6 @@ GlobalProperty hw_compat_3_1[] = {
 };
 const size_t hw_compat_3_1_len = G_N_ELEMENTS(hw_compat_3_1);
 
-GlobalProperty hw_compat_3_0[] = {};
-const size_t hw_compat_3_0_len = G_N_ELEMENTS(hw_compat_3_0);
-
 MachineState *current_machine;
 
 static char *machine_get_kernel(Object *obj, Error **errp)
-- 
2.52.0



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [PATCH 1/4] hw/i386/pc: Remove deprecated pc-q35-3.0 and pc-i440fx-3.0 machines
  2026-03-07 15:00 ` [PATCH 1/4] hw/i386/pc: Remove deprecated pc-q35-3.0 and pc-i440fx-3.0 machines Philippe Mathieu-Daudé
@ 2026-03-08 11:36   ` Thomas Huth
  2026-03-09 13:59   ` Zhao Liu
  1 sibling, 0 replies; 15+ messages in thread
From: Thomas Huth @ 2026-03-08 11:36 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé, qemu-devel
  Cc: Michael S. Tsirkin, Paolo Bonzini, Zhao Liu, Marcelo Tosatti,
	Richard Henderson, Eduardo Habkost, Marcel Apfelbaum

On 07/03/2026 16.00, Philippe Mathieu-Daudé wrote:
> These machines has been supported for a period of more than 6 years.
> According to our versioned machine support policy (see commit
> ce80c4fa6ff "docs: document special exception for machine type
> deprecation & removal") they can now be removed.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   hw/i386/pc_piix.c | 9 ---------
>   hw/i386/pc_q35.c  | 9 ---------
>   2 files changed, 18 deletions(-)
> 
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index 961432176cf..29c8e997131 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -668,15 +668,6 @@ static void pc_i440fx_machine_3_1_options(MachineClass *m)
>   
>   DEFINE_I440FX_MACHINE(3, 1);
>   
> -static void pc_i440fx_machine_3_0_options(MachineClass *m)
> -{
> -    pc_i440fx_machine_3_1_options(m);
> -    compat_props_add(m->compat_props, hw_compat_3_0, hw_compat_3_0_len);
> -    compat_props_add(m->compat_props, pc_compat_3_0, pc_compat_3_0_len);
> -}
> -
> -DEFINE_I440FX_MACHINE(3, 0);
> -
>   #ifdef CONFIG_XEN
>   static void xenfv_machine_4_2_options(MachineClass *m)
>   {
> diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
> index 261d759a223..f102da8e4a1 100644
> --- a/hw/i386/pc_q35.c
> +++ b/hw/i386/pc_q35.c
> @@ -614,12 +614,3 @@ static void pc_q35_machine_3_1_options(MachineClass *m)
>   }
>   
>   DEFINE_Q35_MACHINE(3, 1);
> -
> -static void pc_q35_machine_3_0_options(MachineClass *m)
> -{
> -    pc_q35_machine_3_1_options(m);
> -    compat_props_add(m->compat_props, hw_compat_3_0, hw_compat_3_0_len);
> -    compat_props_add(m->compat_props, pc_compat_3_0, pc_compat_3_0_len);
> -}
> -
> -DEFINE_Q35_MACHINE(3, 0);

Reviewed-by: Thomas Huth <thuth@redhat.com>



^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 2/4] hw/i386/pc: Remove pc_compat_3_0[] array
  2026-03-07 15:00 ` [PATCH 2/4] hw/i386/pc: Remove pc_compat_3_0[] array Philippe Mathieu-Daudé
@ 2026-03-08 11:36   ` Thomas Huth
  2026-03-08 11:39     ` noreply77-demartz@thinocorp.com
  2026-03-09 14:00   ` Zhao Liu
  1 sibling, 1 reply; 15+ messages in thread
From: Thomas Huth @ 2026-03-08 11:36 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé, qemu-devel
  Cc: Michael S. Tsirkin, Paolo Bonzini, Zhao Liu, Marcelo Tosatti,
	Richard Henderson, Eduardo Habkost, Marcel Apfelbaum

On 07/03/2026 16.00, Philippe Mathieu-Daudé wrote:
> The pc_compat_3_0[] array was only used by the pc-q35-3.0
> and pc-i440fx-3.0 machines, which got removed. Remove it.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   include/hw/i386/pc.h | 3 ---
>   hw/i386/pc.c         | 7 -------
>   2 files changed, 10 deletions(-)
> 
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index 113813c07d7..5623660f5dd 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -277,9 +277,6 @@ extern const size_t pc_compat_4_0_len;
>   extern GlobalProperty pc_compat_3_1[];
>   extern const size_t pc_compat_3_1_len;
>   
> -extern GlobalProperty pc_compat_3_0[];
> -extern const size_t pc_compat_3_0_len;
> -
>   #define DEFINE_PC_MACHINE(suffix, namestr, initfn, optsfn) \
>       static void pc_machine_##suffix##_class_init(ObjectClass *oc, \
>                                                    const void *data) \
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 819e729a6e3..a38634e3577 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -214,13 +214,6 @@ GlobalProperty pc_compat_3_1[] = {
>   };
>   const size_t pc_compat_3_1_len = G_N_ELEMENTS(pc_compat_3_1);
>   
> -GlobalProperty pc_compat_3_0[] = {
> -    { TYPE_X86_CPU, "x-hv-synic-kvm-only", "on" },
> -    { "Skylake-Server" "-" TYPE_X86_CPU, "pku", "off" },
> -    { "Skylake-Server-IBRS" "-" TYPE_X86_CPU, "pku", "off" },
> -};
> -const size_t pc_compat_3_0_len = G_N_ELEMENTS(pc_compat_3_0);
> -
>   /*
>    * @PC_FW_DATA:
>    * Size of the chunk of memory at the top of RAM for the BIOS ACPI tables

Reviewed-by: Thomas Huth <thuth@redhat.com>



^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 3/4] target/i386/kvm: Remove X86CPU::hyperv_synic_kvm_only field
  2026-03-07 15:00 ` [PATCH 3/4] target/i386/kvm: Remove X86CPU::hyperv_synic_kvm_only field Philippe Mathieu-Daudé
@ 2026-03-08 11:38   ` Thomas Huth
  2026-03-09 14:03   ` Zhao Liu
  1 sibling, 0 replies; 15+ messages in thread
From: Thomas Huth @ 2026-03-08 11:38 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé, qemu-devel
  Cc: Michael S. Tsirkin, Paolo Bonzini, Zhao Liu, Marcelo Tosatti, kvm

On 07/03/2026 16.00, Philippe Mathieu-Daudé wrote:
> The X86CPU::hyperv_synic_kvm_only boolean (see commit 9b4cf107b09
> "hyperv: only add SynIC in compatible configurations") was only set
> in the pc_compat_3_0[] array, via the 'x-hv-synic-kvm-only=on'
> property. We removed all machines using that array, lets remove that
> property and all the code around it.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/i386/cpu.h     |  1 -
>   target/i386/cpu.c     |  2 --
>   target/i386/kvm/kvm.c | 15 ++++-----------
>   3 files changed, 4 insertions(+), 14 deletions(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>



^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 2/4] hw/i386/pc: Remove pc_compat_3_0[] array
  2026-03-08 11:36   ` Thomas Huth
@ 2026-03-08 11:39     ` noreply77-demartz@thinocorp.com
  0 siblings, 0 replies; 15+ messages in thread
From: noreply77-demartz@thinocorp.com @ 2026-03-08 11:39 UTC (permalink / raw)
  To: Thomas Huth, martz_jose
  Cc: Philippe Mathieu-Daudé, qemu-devel, Michael S. Tsirkin,
	Paolo Bonzini, Zhao Liu, Marcelo Tosatti, Richard Henderson,
	Eduardo Habkost, Marcel Apfelbaum

[-- Attachment #1: Type: text/plain, Size: 2057 bytes --]

   - Philippe propuso eliminar la matriz pc_compat_3_0[] del código i386/pc.
   - Thomas Huth revisó y aprobó el parche propuesto por Philippe.





sales@thinocorp.com

El dom, 8 de mar de 2026, 05:37, Thomas Huth <thuth@redhat.com> escribió:

> On 07/03/2026 16.00, Philippe Mathieu-Daudé wrote:
> > The pc_compat_3_0[] array was only used by the pc-q35-3.0
> > and pc-i440fx-3.0 machines, which got removed. Remove it.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> >   include/hw/i386/pc.h | 3 ---
> >   hw/i386/pc.c         | 7 -------
> >   2 files changed, 10 deletions(-)
> >
> > diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> > index 113813c07d7..5623660f5dd 100644
> > --- a/include/hw/i386/pc.h
> > +++ b/include/hw/i386/pc.h
> > @@ -277,9 +277,6 @@ extern const size_t pc_compat_4_0_len;
> >   extern GlobalProperty pc_compat_3_1[];
> >   extern const size_t pc_compat_3_1_len;
> >
> > -extern GlobalProperty pc_compat_3_0[];
> > -extern const size_t pc_compat_3_0_len;
> > -
> >   #define DEFINE_PC_MACHINE(suffix, namestr, initfn, optsfn) \
> >       static void pc_machine_##suffix##_class_init(ObjectClass *oc, \
> >                                                    const void *data) \
> > diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> > index 819e729a6e3..a38634e3577 100644
> > --- a/hw/i386/pc.c
> > +++ b/hw/i386/pc.c
> > @@ -214,13 +214,6 @@ GlobalProperty pc_compat_3_1[] = {
> >   };
> >   const size_t pc_compat_3_1_len = G_N_ELEMENTS(pc_compat_3_1);
> >
> > -GlobalProperty pc_compat_3_0[] = {
> > -    { TYPE_X86_CPU, "x-hv-synic-kvm-only", "on" },
> > -    { "Skylake-Server" "-" TYPE_X86_CPU, "pku", "off" },
> > -    { "Skylake-Server-IBRS" "-" TYPE_X86_CPU, "pku", "off" },
> > -};
> > -const size_t pc_compat_3_0_len = G_N_ELEMENTS(pc_compat_3_0);
> > -
> >   /*
> >    * @PC_FW_DATA:
> >    * Size of the chunk of memory at the top of RAM for the BIOS ACPI
> tables
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
>
>

[-- Attachment #2: Type: text/html, Size: 3022 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 4/4] hw/core/machine: Remove the hw_compat_3_0[] array
  2026-03-07 15:00 ` [PATCH 4/4] hw/core/machine: Remove the hw_compat_3_0[] array Philippe Mathieu-Daudé
@ 2026-03-08 11:39   ` Thomas Huth
  2026-03-09 14:04   ` Zhao Liu
  1 sibling, 0 replies; 15+ messages in thread
From: Thomas Huth @ 2026-03-08 11:39 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé, qemu-devel
  Cc: Michael S. Tsirkin, Paolo Bonzini, Zhao Liu, Marcelo Tosatti,
	Eduardo Habkost, Marcel Apfelbaum, Yanan Wang

On 07/03/2026 16.00, Philippe Mathieu-Daudé wrote:
> The hw_compat_3_0[] array was only used by the pc-q35-3.0
> and pc-i440fx-3.0 machines, which got removed. Remove it.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   include/hw/core/boards.h | 3 ---
>   hw/core/machine.c        | 3 ---
>   2 files changed, 6 deletions(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>



^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 0/4] hw/i386/pc: Remove deprecated 3.0 machines
  2026-03-07 15:00 [PATCH 0/4] hw/i386/pc: Remove deprecated 3.0 machines Philippe Mathieu-Daudé
                   ` (3 preceding siblings ...)
  2026-03-07 15:00 ` [PATCH 4/4] hw/core/machine: Remove the hw_compat_3_0[] array Philippe Mathieu-Daudé
@ 2026-03-08 21:48 ` Philippe Mathieu-Daudé
  4 siblings, 0 replies; 15+ messages in thread
From: Philippe Mathieu-Daudé @ 2026-03-08 21:48 UTC (permalink / raw)
  To: qemu-devel
  Cc: Michael S. Tsirkin, Paolo Bonzini, Zhao Liu, Thomas Huth,
	Marcelo Tosatti

On 7/3/26 16:00, Philippe Mathieu-Daudé wrote:

> Philippe Mathieu-Daudé (4):
>    hw/i386/pc: Remove deprecated pc-q35-3.0 and pc-i440fx-3.0 machines
>    hw/i386/pc: Remove pc_compat_3_0[] array
>    target/i386/kvm: Remove X86CPU::hyperv_synic_kvm_only field
>    hw/core/machine: Remove the hw_compat_3_0[] array

Queued via hw-misc, thanks.


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 1/4] hw/i386/pc: Remove deprecated pc-q35-3.0 and pc-i440fx-3.0 machines
  2026-03-07 15:00 ` [PATCH 1/4] hw/i386/pc: Remove deprecated pc-q35-3.0 and pc-i440fx-3.0 machines Philippe Mathieu-Daudé
  2026-03-08 11:36   ` Thomas Huth
@ 2026-03-09 13:59   ` Zhao Liu
  1 sibling, 0 replies; 15+ messages in thread
From: Zhao Liu @ 2026-03-09 13:59 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé
  Cc: qemu-devel, Michael S. Tsirkin, Paolo Bonzini, Thomas Huth,
	Marcelo Tosatti, Richard Henderson, Eduardo Habkost,
	Marcel Apfelbaum

On Sat, Mar 07, 2026 at 04:00:39PM +0100, Philippe Mathieu-Daudé wrote:
> Date: Sat,  7 Mar 2026 16:00:39 +0100
> From: Philippe Mathieu-Daudé <philmd@linaro.org>
> Subject: [PATCH 1/4] hw/i386/pc: Remove deprecated pc-q35-3.0 and
>  pc-i440fx-3.0 machines
> X-Mailer: git-send-email 2.52.0
> 
> These machines has been supported for a period of more than 6 years.
> According to our versioned machine support policy (see commit
> ce80c4fa6ff "docs: document special exception for machine type
> deprecation & removal") they can now be removed.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  hw/i386/pc_piix.c | 9 ---------
>  hw/i386/pc_q35.c  | 9 ---------
>  2 files changed, 18 deletions(-)

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>



^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 2/4] hw/i386/pc: Remove pc_compat_3_0[] array
  2026-03-07 15:00 ` [PATCH 2/4] hw/i386/pc: Remove pc_compat_3_0[] array Philippe Mathieu-Daudé
  2026-03-08 11:36   ` Thomas Huth
@ 2026-03-09 14:00   ` Zhao Liu
  1 sibling, 0 replies; 15+ messages in thread
From: Zhao Liu @ 2026-03-09 14:00 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé
  Cc: qemu-devel, Michael S. Tsirkin, Paolo Bonzini, Thomas Huth,
	Marcelo Tosatti, Richard Henderson, Eduardo Habkost,
	Marcel Apfelbaum

On Sat, Mar 07, 2026 at 04:00:40PM +0100, Philippe Mathieu-Daudé wrote:
> Date: Sat,  7 Mar 2026 16:00:40 +0100
> From: Philippe Mathieu-Daudé <philmd@linaro.org>
> Subject: [PATCH 2/4] hw/i386/pc: Remove pc_compat_3_0[] array
> X-Mailer: git-send-email 2.52.0
> 
> The pc_compat_3_0[] array was only used by the pc-q35-3.0
> and pc-i440fx-3.0 machines, which got removed. Remove it.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  include/hw/i386/pc.h | 3 ---
>  hw/i386/pc.c         | 7 -------
>  2 files changed, 10 deletions(-)

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>



^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 3/4] target/i386/kvm: Remove X86CPU::hyperv_synic_kvm_only field
  2026-03-07 15:00 ` [PATCH 3/4] target/i386/kvm: Remove X86CPU::hyperv_synic_kvm_only field Philippe Mathieu-Daudé
  2026-03-08 11:38   ` Thomas Huth
@ 2026-03-09 14:03   ` Zhao Liu
  1 sibling, 0 replies; 15+ messages in thread
From: Zhao Liu @ 2026-03-09 14:03 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé
  Cc: qemu-devel, Michael S. Tsirkin, Paolo Bonzini, Thomas Huth,
	Marcelo Tosatti, kvm

On Sat, Mar 07, 2026 at 04:00:41PM +0100, Philippe Mathieu-Daudé wrote:
> Date: Sat,  7 Mar 2026 16:00:41 +0100
> From: Philippe Mathieu-Daudé <philmd@linaro.org>
> Subject: [PATCH 3/4] target/i386/kvm: Remove X86CPU::hyperv_synic_kvm_only
>  field
> X-Mailer: git-send-email 2.52.0
> 
> The X86CPU::hyperv_synic_kvm_only boolean (see commit 9b4cf107b09
> "hyperv: only add SynIC in compatible configurations") was only set
> in the pc_compat_3_0[] array, via the 'x-hv-synic-kvm-only=on'
> property. We removed all machines using that array, lets remove that
> property and all the code around it.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  target/i386/cpu.h     |  1 -
>  target/i386/cpu.c     |  2 --
>  target/i386/kvm/kvm.c | 15 ++++-----------
>  3 files changed, 4 insertions(+), 14 deletions(-)

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>



^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 4/4] hw/core/machine: Remove the hw_compat_3_0[] array
  2026-03-07 15:00 ` [PATCH 4/4] hw/core/machine: Remove the hw_compat_3_0[] array Philippe Mathieu-Daudé
  2026-03-08 11:39   ` Thomas Huth
@ 2026-03-09 14:04   ` Zhao Liu
  1 sibling, 0 replies; 15+ messages in thread
From: Zhao Liu @ 2026-03-09 14:04 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé
  Cc: qemu-devel, Michael S. Tsirkin, Paolo Bonzini, Thomas Huth,
	Marcelo Tosatti, Eduardo Habkost, Marcel Apfelbaum, Yanan Wang

On Sat, Mar 07, 2026 at 04:00:42PM +0100, Philippe Mathieu-Daudé wrote:
> Date: Sat,  7 Mar 2026 16:00:42 +0100
> From: Philippe Mathieu-Daudé <philmd@linaro.org>
> Subject: [PATCH 4/4] hw/core/machine: Remove the hw_compat_3_0[] array
> X-Mailer: git-send-email 2.52.0
> 
> The hw_compat_3_0[] array was only used by the pc-q35-3.0
> and pc-i440fx-3.0 machines, which got removed. Remove it.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  include/hw/core/boards.h | 3 ---
>  hw/core/machine.c        | 3 ---
>  2 files changed, 6 deletions(-)

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>



^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2026-03-09 13:38 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-07 15:00 [PATCH 0/4] hw/i386/pc: Remove deprecated 3.0 machines Philippe Mathieu-Daudé
2026-03-07 15:00 ` [PATCH 1/4] hw/i386/pc: Remove deprecated pc-q35-3.0 and pc-i440fx-3.0 machines Philippe Mathieu-Daudé
2026-03-08 11:36   ` Thomas Huth
2026-03-09 13:59   ` Zhao Liu
2026-03-07 15:00 ` [PATCH 2/4] hw/i386/pc: Remove pc_compat_3_0[] array Philippe Mathieu-Daudé
2026-03-08 11:36   ` Thomas Huth
2026-03-08 11:39     ` noreply77-demartz@thinocorp.com
2026-03-09 14:00   ` Zhao Liu
2026-03-07 15:00 ` [PATCH 3/4] target/i386/kvm: Remove X86CPU::hyperv_synic_kvm_only field Philippe Mathieu-Daudé
2026-03-08 11:38   ` Thomas Huth
2026-03-09 14:03   ` Zhao Liu
2026-03-07 15:00 ` [PATCH 4/4] hw/core/machine: Remove the hw_compat_3_0[] array Philippe Mathieu-Daudé
2026-03-08 11:39   ` Thomas Huth
2026-03-09 14:04   ` Zhao Liu
2026-03-08 21:48 ` [PATCH 0/4] hw/i386/pc: Remove deprecated 3.0 machines Philippe Mathieu-Daudé

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox