From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92081C04AB5 for ; Thu, 6 Jun 2019 09:31:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 56A0D20684 for ; Thu, 6 Jun 2019 09:31:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56A0D20684 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:57176 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYok5-0001cx-6x for qemu-devel@archiver.kernel.org; Thu, 06 Jun 2019 05:31:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYoiw-0000rm-Bx for qemu-devel@nongnu.org; Thu, 06 Jun 2019 05:30:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYoiv-00061i-DF for qemu-devel@nongnu.org; Thu, 06 Jun 2019 05:30:18 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:42199) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hYoir-0005mL-1R; Thu, 06 Jun 2019 05:30:13 -0400 Received: from [192.168.100.1] ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue011 [213.165.67.103]) with ESMTPSA (Nemesis) id 1MBll6-1hOwH730DU-00CA2V; Thu, 06 Jun 2019 11:29:21 +0200 To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org, qemu-trivial@nongnu.org References: <20190528164020.32250-1-philmd@redhat.com> <20190528164020.32250-2-philmd@redhat.com> From: Laurent Vivier Openpgp: preference=signencrypt Autocrypt: addr=laurent@vivier.eu; prefer-encrypt=mutual; keydata= mQINBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABtCJMYXVyZW50IFZp dmllciA8bGF1cmVudEB2aXZpZXIuZXU+iQI4BBMBAgAiBQJWBTDeAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAAKCRDzDDi9Py++PCEdD/oD8LD5UWxhQrMQCsUgLlXCSM7sxGLkwmmF ozqSSljEGRhffxZvO35wMFcdX9Z0QOabVoFTKrT04YmvbjsErh/dP5zeM/4EhUByeOS7s6Yl HubMXVQTkak9Wa9Eq6irYC6L41QNzz/oTwNEqL1weV1+XC3TNnht9B76lIaELyrJvRfgsp9M rE+PzGPo5h7QHWdL/Cmu8yOtPLa8Y6l/ywEJ040IoiAUfzRoaJs2csMXf0eU6gVBhCJ4bs91 jtWTXhkzdl4tdV+NOwj3j0ukPy+RjqeL2Ej+bomnPTOW8nAZ32dapmu7Fj7VApuQO/BSIHyO NkowMMjB46yohEepJaJZkcgseaus0x960c4ua/SUm/Nm6vioRsxyUmWd2nG0m089pp8LPopq WfAk1l4GciiMepp1Cxn7cnn1kmG6fhzedXZ/8FzsKjvx/aVeZwoEmucA42uGJ3Vk9TiVdZes lqMITkHqDIpHjC79xzlWkXOsDbA2UY/P18AtgJEZQPXbcrRBtdSifCuXdDfHvI+3exIdTpvj BfbgZAar8x+lcsQBugvktlQWPfAXZu4Shobi3/mDYMEDOE92dnNRD2ChNXg2IuvAL4OW40wh gXlkHC1ZgToNGoYVvGcZFug1NI+vCeCFchX+L3bXyLMg3rAfWMFPAZLzn42plIDMsBs+x2yP +bkCDQRWBSYZARAAvFJBFuX9A6eayxUPFaEczlMbGXugs0mazbOYGlyaWsiyfyc3PStHLFPj rSTaeJpPCjBJErwpZUN4BbpkBpaJiMuVO6egrC8Xy8/cnJakHPR2JPEvmj7Gm/L9DphTcE15 92rxXLesWzGBbuYxKsj8LEnrrvLyi3kNW6B5LY3Id+ZmU8YTQ2zLuGV5tLiWKKxc6s3eMXNq wrJTCzdVd6ThXrmUfAHbcFXOycUyf9vD+s+WKpcZzCXwKgm7x1LKsJx3UhuzT8ier1L363RW ZaJBZ9CTPiu8R5NCSn9V+BnrP3wlFbtLqXp6imGhazT9nJF86b5BVKpF8Vl3F0/Y+UZ4gUwL d9cmDKBcmQU/JaRUSWvvolNu1IewZZu3rFSVgcpdaj7F/1aC0t5vLdx9KQRyEAKvEOtCmP4m 38kU/6r33t3JuTJnkigda4+Sfu5kYGsogeYG6dNyjX5wpK5GJIJikEhdkwcLM+BUOOTi+I9u tX03BGSZo7FW/J7S9y0l5a8nooDs2gBRGmUgYKqQJHCDQyYut+hmcr+BGpUn9/pp2FTWijrP inb/Pc96YDQLQA1q2AeAFv3Rx3XoBTGl0RCY4KZ02c0kX/dm3eKfMX40XMegzlXCrqtzUk+N 8LeipEsnOoAQcEONAWWo1HcgUIgCjhJhBEF0AcELOQzitbJGG5UAEQEAAYkCHwQYAQIACQUC VgUmGQIbDAAKCRDzDDi9Py++PCD3D/9VCtydWDdOyMTJvEMRQGbx0GacqpydMEWbE3kUW0ha US5jz5gyJZHKR3wuf1En/3z+CEAEfP1M3xNGjZvpaKZXrgWaVWfXtGLoWAVTfE231NMQKGoB w2Dzx5ivIqxikXB6AanBSVpRpoaHWb06tPNxDL6SVV9lZpUn03DSR6gZEZvyPheNWkvz7bE6 FcqszV/PNvwm0C5Ju7NlJA8PBAQjkIorGnvN/vonbVh5GsRbhYPOc/JVwNNr63P76rZL8Gk/ hb3xtcIEi5CCzab45+URG/lzc6OV2nTj9Lg0SNcRhFZ2ILE3txrmI+aXmAu26+EkxLLfqCVT ohb2SffQha5KgGlOSBXustQSGH0yzzZVZb+HZPEvx6d/HjQ+t9sO1bCpEgPdZjyMuuMp9N1H ctbwGdQM2Qb5zgXO+8ZSzwC+6rHHIdtcB8PH2j+Nd88dVGYlWFKZ36ELeZxD7iJflsE8E8yg OpKgu3nD0ahBDqANU/ZmNNarBJEwvM2vfusmNnWm3QMIwxNuJghRyuFfx694Im1js0ZY3LEU JGSHFG4ZynA+ZFUPA6Xf0wHeJOxGKCGIyeKORsteIqgnkINW9fnKJw2pgk8qHkwVc3Vu+wGS ZiJK0xFusPQehjWTHn9WjMG1zvQ5TQQHxau/2FkP45+nRPco6vVFQe8JmgtRF8WFJA== Message-ID: Date: Thu, 6 Jun 2019 11:29:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190528164020.32250-2-philmd@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:FpxFokUw3inagld2oEoc6zlrENHn41ZtXSf08YusAOqDRM788X/ CQCylP0Gi9FggN/7/9qgz+oabDOGLrq53GGKv7hfgY4TymMT/2Rqi0QiahTTHmxxNBSfC5s NHlf1fhz/hNIsdxqM34IO0/vnQmrtEcVro7uw1R0TGeELv+3AIAjYecm5YyQs9ss/WHgF1R 2TB15d98+/j+Dsbb2bb1g== X-UI-Out-Filterresults: notjunk:1;V03:K0:1U8eLm0kBwU=:pBexdW+h36arjs1w+UakXt k9Y5Cfz7TgwjTAJ0RfVmQ5IeDkVPPlxv98mKm64z77by604r++Ew0mEWrGOtuDaEn/ojMNvWk 1Pu40ZhMYCHKlvzKT+uuGIO3IZGOrk+tN+POS1okUqZJqGY7Q29FBCEeMAZyMA4sssNXRD05a p80/LI9D4STrnyUC/G5KUhdCuf8WX3HioEjUn+0lXipdqkq/C735ijkZuJF843rn+SfW15AO6 u0tMEiG+qxjSu0i3ZrA7kiGbdtJsaL2N61ihscBzSmdhwFAm/0Ptj4Z+GyqH8dZpGFOfn8L/b nhJmT6i969K2/TST9586ONT29nYarvUAEXub0ZaKdPhH3AKMkKthUaL+ju/xoYMyE6nVfMkH+ t7Fpk/wFZqGs8ldALrvI4p9tBFofX10N3KNOjHAfXyj3qg0sGv7JKgKV3rVqcHKonU6AjIF08 vG/PRpSHuaAl2U5aD7wZPeSOoMMHpkzlbygpAVM5FfopYwXKjMab9lMITJ3hjydfuMnv3jd8t XWkBZRfgh3QtxDIlCczSMMJlw0FPIpxpA9Q1prjM1RXvADEDX8ZJSmMHN1CDI7ndOOsGRKSjl 6iMGdbPM+Z+q86rqpmtr+NUYCiSx0d/uQobFt3Kfsh71CqHf0URi8bVg0pqVIfrlrysgAINhH Uj3ELgPTHd+FjNrqhitDjXAIpdtj75MKqLMWI2k/fnXkWHUTbvKvykydlwnA4ItWgHp3CVwFz QtXZxfhGMMa4fHUYGVd3Tpt2H2q+H12Juttq2wLvZqhjrYsO6pFQE/S5/A0= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.133 Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 01/10] hw/scsi/vmw_pvscsi: Use qbus_reset_all() directly X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , Dmitry Fleytman , "Michael S. Tsirkin" , Aleksandar Rikalo , David Hildenbrand , Markus Armbruster , Halil Pasic , qemu-s390x@nongnu.org, Alex Williamson , Michael Walle , Aleksandar Markovic , Cornelia Huck , Paolo Bonzini , Richard Henderson , Christian Borntraeger , Gerd Hoffmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 28/05/2019 à 18:40, Philippe Mathieu-Daudé a écrit : > Since the BusState is accesible from the SCSIBus object, > it is pointless to use qbus_reset_all_fn. > Use qbus_reset_all() directly. > > Signed-off-by: Philippe Mathieu-Daudé > --- > v2: Use BUS() macro (Peter Maydell) > > One step toward removing qbus_reset_all_fn() > --- > hw/scsi/vmw_pvscsi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c > index 584b4be07e..c39e33fa35 100644 > --- a/hw/scsi/vmw_pvscsi.c > +++ b/hw/scsi/vmw_pvscsi.c > @@ -440,7 +440,7 @@ static void > pvscsi_reset_adapter(PVSCSIState *s) > { > s->resetting++; > - qbus_reset_all_fn(&s->bus); > + qbus_reset_all(BUS(&s->bus)); > s->resetting--; > pvscsi_process_completion_queue(s); > assert(QTAILQ_EMPTY(&s->pending_queue)); > @@ -848,7 +848,7 @@ pvscsi_on_cmd_reset_bus(PVSCSIState *s) > trace_pvscsi_on_cmd_arrived("PVSCSI_CMD_RESET_BUS"); > > s->resetting++; > - qbus_reset_all_fn(&s->bus); > + qbus_reset_all(BUS(&s->bus)); > s->resetting--; > return PVSCSI_COMMAND_PROCESSING_SUCCEEDED; > } > Applied to my trivial-patches branch. Thanks, Laurent