From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3056C33CAC for ; Mon, 3 Feb 2020 14:03:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9EAD520CC7 for ; Mon, 3 Feb 2020 14:03:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OaKpAK4F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9EAD520CC7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iycJx-0003WL-Qv for qemu-devel@archiver.kernel.org; Mon, 03 Feb 2020 09:03:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57578) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iycHj-00010Z-52 for qemu-devel@nongnu.org; Mon, 03 Feb 2020 09:01:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iycHh-0004bb-Pf for qemu-devel@nongnu.org; Mon, 03 Feb 2020 09:01:07 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:26287 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iycHh-0004a7-LK for qemu-devel@nongnu.org; Mon, 03 Feb 2020 09:01:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580738464; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T2K7P3shSIytlWN24FuWBQryMjmxMWHPxy/O94Jb/Qk=; b=OaKpAK4FbZwHmOw1kcmQVNWFSY5iUHV5YTVoslB/uAZ8MTYqZ6ziXzx+ucz3P7wDpDPCLi c2LkUD/zZ5xaVd6m9rv1bI4i/w0sNHcZPZV0ibucYFJhO0OcfZDc+Rj0N7s7HBoXHXkBpI NqKOP6nA9Ry3VoGjqkjebYd19zSj6SA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-379-gXpCWI0rND6kduz-dujNbg-1; Mon, 03 Feb 2020 09:00:46 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 47A4A90FF18; Mon, 3 Feb 2020 14:00:42 +0000 (UTC) Received: from localhost.localdomain (ovpn-116-90.gru2.redhat.com [10.97.116.90]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0C02E909FB; Mon, 3 Feb 2020 14:00:38 +0000 (UTC) Subject: Re: [PATCH 1/2] tests/acceptance: Extract boot_integratorcp() from test_integratorcp() To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20200131211102.29612-1-f4bug@amsat.org> <20200131211102.29612-2-f4bug@amsat.org> From: Wainer dos Santos Moschetta Message-ID: Date: Mon, 3 Feb 2020 12:00:37 -0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20200131211102.29612-2-f4bug@amsat.org> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: gXpCWI0rND6kduz-dujNbg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , Eduardo Habkost , "Dr . David Alan Gilbert" , qemu-arm@nongnu.org, Gerd Hoffmann , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 1/31/20 7:11 PM, Philippe Mathieu-Daud=C3=A9 wrote: > As we want to re-use this code, extract it as a new function. > Since we are using the PL011 serial console, add a Avocado tag > to ease filtering of tests. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > tests/acceptance/machine_arm_integratorcp.py | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) Reviewed-by: Wainer dos Santos Moschetta > > diff --git a/tests/acceptance/machine_arm_integratorcp.py b/tests/accepta= nce/machine_arm_integratorcp.py > index 4f9ab40f2f..748819916d 100644 > --- a/tests/acceptance/machine_arm_integratorcp.py > +++ b/tests/acceptance/machine_arm_integratorcp.py > @@ -19,12 +19,7 @@ class IntegratorMachine(Test): > =20 > timeout =3D 90 > =20 > - @skipUnless(os.getenv('AVOCADO_ALLOW_UNTRUSTED_CODE'), 'untrusted co= de') > - def test_integratorcp(self): > - """ > - :avocado: tags=3Darch:arm > - :avocado: tags=3Dmachine:integratorcp > - """ > + def boot_integratorcp(self): > kernel_url =3D ('https://github.com/zayac/qemu-arm/raw/master/' > 'arm-test/kernel/zImage.integrator') > kernel_hash =3D '0d7adba893c503267c946a3cbdc63b4b54f25468' > @@ -40,4 +35,13 @@ class IntegratorMachine(Test): > '-initrd', initrd_path, > '-append', 'printk.time=3D0 console=3DttyAMA0'= ) > self.vm.launch() > + > + @skipUnless(os.getenv('AVOCADO_ALLOW_UNTRUSTED_CODE'), 'untrusted co= de') > + def test_integratorcp(self): > + """ > + :avocado: tags=3Darch:arm > + :avocado: tags=3Dmachine:integratorcp > + :avocado: tags=3Ddevice:pl011 > + """ > + self.boot_integratorcp() > wait_for_console_pattern(self, 'Log in as root')