From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH v2] modules: update qom object module comment
Date: Wed, 23 Sep 2020 13:00:09 +0200 [thread overview]
Message-ID: <aa8ab87b-c881-6323-2c02-76afaf728fda@redhat.com> (raw)
In-Reply-To: <20200923103728.12026-1-kraxel@redhat.com>
On 9/23/20 12:37 PM, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> util/module.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/util/module.c b/util/module.c
> index 520986bd70ff..6eb1e917860e 100644
> --- a/util/module.c
> +++ b/util/module.c
> @@ -255,8 +255,10 @@ bool module_load_one(const char *prefix, const char *lib_name)
> * only a very few devices & objects.
> *
> * So with the expectation that this will be rather the exception than
> - * to rule and the list will not gain that many entries go with a
> + * the rule and the list will not gain that many entries, go with a
> * simple manually maintained list for now.
> + *
> + * The list must be sorted by module (module_load_qom_all() needs this).
> */
> static struct {
> const char *type;
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
prev parent reply other threads:[~2020-09-23 11:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 10:37 [PATCH v2] modules: update qom object module comment Gerd Hoffmann
2020-09-23 11:00 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa8ab87b-c881-6323-2c02-76afaf728fda@redhat.com \
--to=philmd@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).