* [PATCH v2] modules: update qom object module comment
@ 2020-09-23 10:37 Gerd Hoffmann
2020-09-23 11:00 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Gerd Hoffmann @ 2020-09-23 10:37 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
util/module.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/util/module.c b/util/module.c
index 520986bd70ff..6eb1e917860e 100644
--- a/util/module.c
+++ b/util/module.c
@@ -255,8 +255,10 @@ bool module_load_one(const char *prefix, const char *lib_name)
* only a very few devices & objects.
*
* So with the expectation that this will be rather the exception than
- * to rule and the list will not gain that many entries go with a
+ * the rule and the list will not gain that many entries, go with a
* simple manually maintained list for now.
+ *
+ * The list must be sorted by module (module_load_qom_all() needs this).
*/
static struct {
const char *type;
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] modules: update qom object module comment
2020-09-23 10:37 [PATCH v2] modules: update qom object module comment Gerd Hoffmann
@ 2020-09-23 11:00 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-09-23 11:00 UTC (permalink / raw)
To: Gerd Hoffmann, qemu-devel
On 9/23/20 12:37 PM, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> util/module.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/util/module.c b/util/module.c
> index 520986bd70ff..6eb1e917860e 100644
> --- a/util/module.c
> +++ b/util/module.c
> @@ -255,8 +255,10 @@ bool module_load_one(const char *prefix, const char *lib_name)
> * only a very few devices & objects.
> *
> * So with the expectation that this will be rather the exception than
> - * to rule and the list will not gain that many entries go with a
> + * the rule and the list will not gain that many entries, go with a
> * simple manually maintained list for now.
> + *
> + * The list must be sorted by module (module_load_qom_all() needs this).
> */
> static struct {
> const char *type;
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-23 11:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-23 10:37 [PATCH v2] modules: update qom object module comment Gerd Hoffmann
2020-09-23 11:00 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).