From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE329C761A6 for ; Tue, 28 Mar 2023 03:31:41 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ph03F-0006ne-3Z; Mon, 27 Mar 2023 23:31:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ph03D-0006mo-3Z for qemu-devel@nongnu.org; Mon, 27 Mar 2023 23:31:11 -0400 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ph03A-0008Fu-Ch for qemu-devel@nongnu.org; Mon, 27 Mar 2023 23:31:10 -0400 Received: by mail-pj1-x1033.google.com with SMTP id q102so9610641pjq.3 for ; Mon, 27 Mar 2023 20:31:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679974266; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XjJmA0F5k+ZbyBVXiv7bH/3W6sYN1kzcn8aHqfEsG0g=; b=zud3K50DtWdURgPQ0MvFtkedxX89AjpIT5GNjYu0duzMxKv7MZONzTtnU1RAVLBH6G a06JGd1ZYQPfAXNMurwPvSsdAKt/8uKcW9tJyPRq5Q7MNk4edE++dtLBTl+3CxBBXB0V 1t1xl+I4ERCEdTOaFn3W7fIMcXHg4+KWUPYAZrvgzC5GOD1dtYNeH53FHqHDEZlJPqmJ KRkTFMKkWl9m4CWB93JaAxfcNKNfBtZO6MaIfixPOV8UtL93SOMX9RQYojZINMbtRMeH 5pdQLPGBzGLzSukmtN+YZiswmuLb1kBqinHuo7u+k8Oh138+3+kkZu17XVYz4fuMDqEh dExg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679974266; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XjJmA0F5k+ZbyBVXiv7bH/3W6sYN1kzcn8aHqfEsG0g=; b=sXkHf7zMFGtAIJiKl2NdT5nohvWo/KH9p1QQ5gwqfCO628JX4ogEg7NX7FYIGiiBtU 8BGasTwF1VZywYH2IC9yhv6XlraHBIZF0i+PL+jIp1RGtwJdoI/G2sqmdiSMYWsw0SRI L2T+yE8IDNm8ZdghqYpvYSfKqb5uMgHNNuYhN7GjWcILkXqV9Ame8hHQDqassZHX6nOF zBUgb/3JjJCjzr5Gfg4kmHx0uvjq3muI+V43kMq6aTzjsyNJYFFtRONdmNC7nFK4W5nH omK8BBjA0MP6I1sJOAzHvny9nFA2mxUeLO2EU0vskbusPDrGbZ9bR8HUDcXOFHqZOIsL 1frA== X-Gm-Message-State: AAQBX9dVgWTCoUbnREIG1JEdGAVeu7Fugm9OwDfFCgm+L7ZVugjAjKmU 1XI3uBr2mckOU2hPjLivc2U8zg== X-Google-Smtp-Source: AKy350acnRDWRMTAAclLGe35pAhxJ6nUNKitFVHiae5vl64aNkHdSNzk0n3SAYeuPPUJIg/c8Pfxng== X-Received: by 2002:a17:903:1212:b0:1a2:56f4:d369 with SMTP id l18-20020a170903121200b001a256f4d369mr4522421plh.19.1679974266660; Mon, 27 Mar 2023 20:31:06 -0700 (PDT) Received: from ?IPV6:2602:ae:1544:6601:6705:aa17:3641:e634? ([2602:ae:1544:6601:6705:aa17:3641:e634]) by smtp.gmail.com with ESMTPSA id 19-20020a170902c21300b001a04ff0e2eesm19967923pll.58.2023.03.27.20.31.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Mar 2023 20:31:06 -0700 (PDT) Message-ID: Date: Mon, 27 Mar 2023 20:31:04 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 5/5] target/riscv: Add pointer mask support for instruction fetch Content-Language: en-US To: liweiwei , qemu-riscv@nongnu.org, qemu-devel@nongnu.org Cc: palmer@dabbelt.com, alistair.francis@wdc.com, bin.meng@windriver.com, dbarboza@ventanamicro.com, zhiwei_liu@linux.alibaba.com, wangjunqiang@iscas.ac.cn, lazyparser@gmail.com References: <20230327100027.61160-1-liweiwei@iscas.ac.cn> <20230327100027.61160-6-liweiwei@iscas.ac.cn> <8fed2551-a67d-cd53-f5a1-f089f980aa08@linaro.org> From: Richard Henderson In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1033; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1033.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 3/27/23 18:55, liweiwei wrote: > > On 2023/3/28 02:04, Richard Henderson wrote: >> On 3/27/23 03:00, Weiwei Li wrote: >>> @@ -1248,6 +1265,10 @@ bool riscv_cpu_tlb_fill(CPUState *cs, vaddr address, int size, >>>       qemu_log_mask(CPU_LOG_MMU, "%s ad %" VADDR_PRIx " rw %d mmu_idx %d\n", >>>                     __func__, address, access_type, mmu_idx); >>>   +    if (access_type == MMU_INST_FETCH) { >>> +        address = adjust_pc_address(env, address); >>> +    } >> >> Why do you want to do this so late, as opposed to earlier in cpu_get_tb_cpu_state? > > In this way, the pc for tb may be different from the reg pc. Then the pc register will be > wrong if sync from tb. Hmm, true. But you certainly cannot adjust the address in tlb_fill, as you'll be producing different result for read/write and exec. You could plausibly use a separate mmu_idx, but that's not ideal either. The best solution might be to implement pc-relative translation (CF_PCREL). At which point cpu_pc always has the correct results and we make relative adjustments to that. r~