From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH v2 01/11] hw/intc/armv7m_nvic: Don't hardcode M profile ID registers in NVIC
Date: Fri, 9 Feb 2018 12:28:29 -0800 [thread overview]
Message-ID: <aaa56b0f-ef7e-a617-8ffe-52bf55169491@linaro.org> (raw)
In-Reply-To: <20180209165810.6668-2-peter.maydell@linaro.org>
On 02/09/2018 08:58 AM, Peter Maydell wrote:
> Instead of hardcoding the values of M profile ID registers in the
> NVIC, use the fields in the CPU struct. This will allow us to
> give different M profile CPU types different ID register values.
>
> This commit includes the addition of the missing ID_ISAR5,
> which exists as RES0 in both v7M and v8M.
>
> (The values of the ID registers might be wrong for the M4 --
> this commit leaves the behaviour there unchanged.)
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/intc/armv7m_nvic.c | 30 ++++++++++++++++--------------
> target/arm/cpu.c | 28 ++++++++++++++++++++++++++++
> 2 files changed, 44 insertions(+), 14 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2018-02-09 20:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 16:57 [Qemu-devel] [PATCH v2 00/11] v8m: minor missing regs and bugfixes Peter Maydell
2018-02-09 16:58 ` [Qemu-devel] [PATCH v2 01/11] hw/intc/armv7m_nvic: Don't hardcode M profile ID registers in NVIC Peter Maydell
2018-02-09 20:28 ` Richard Henderson [this message]
2018-02-09 16:58 ` [Qemu-devel] [PATCH v2 02/11] hw/intc/armv7m_nvic: Fix ICSR PENDNMISET/CLR handling Peter Maydell
2018-02-09 20:30 ` Richard Henderson
2018-02-09 16:58 ` [Qemu-devel] [PATCH v2 03/11] hw/intc/armv7m_nvic: Implement M profile cache maintenance ops Peter Maydell
2018-02-09 20:34 ` Richard Henderson
2018-02-09 16:58 ` [Qemu-devel] [PATCH v2 04/11] hw/intc/armv7m_nvic: Implement v8M CPPWR register Peter Maydell
2018-02-09 20:37 ` Richard Henderson
2018-02-09 16:58 ` [Qemu-devel] [PATCH v2 05/11] hw/intc/armv7m_nvic: Implement cache ID registers Peter Maydell
2018-02-09 20:59 ` Richard Henderson
2018-02-09 16:58 ` [Qemu-devel] [PATCH v2 06/11] hw/intc/armv7m_nvic: Implement SCR Peter Maydell
2018-02-09 21:03 ` Richard Henderson
2018-02-09 16:58 ` [Qemu-devel] [PATCH v2 07/11] target/arm: Implement writing to CONTROL_NS for v8M Peter Maydell
2018-02-09 21:08 ` Richard Henderson
2018-02-09 16:58 ` [Qemu-devel] [PATCH v2 08/11] hw/intc/armv7m_nvic: Fix byte-to-interrupt number conversions Peter Maydell
2018-02-09 16:58 ` [Qemu-devel] [PATCH v2 09/11] target/arm: Add AIRCR to vmstate struct Peter Maydell
2018-02-09 21:12 ` Richard Henderson
2018-02-09 16:58 ` [Qemu-devel] [PATCH v2 10/11] target/arm: Migrate v7m.other_sp Peter Maydell
2018-02-09 21:13 ` Richard Henderson
2018-02-09 16:58 ` [Qemu-devel] [PATCH v2 11/11] target/arm: Implement v8M MSPLIM and PSPLIM registers Peter Maydell
2018-02-09 21:15 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaa56b0f-ef7e-a617-8ffe-52bf55169491@linaro.org \
--to=richard.henderson@linaro.org \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).