From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7B81E67A95 for ; Tue, 3 Mar 2026 08:42:35 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vxLK7-0001VZ-BG; Tue, 03 Mar 2026 03:41:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vxLJy-0001V3-56 for qemu-devel@nongnu.org; Tue, 03 Mar 2026 03:41:40 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vxLJv-0004vp-VI for qemu-devel@nongnu.org; Tue, 03 Mar 2026 03:41:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772527294; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=jNLMTe20pkeU7wDDrAsqxJeqYcp/WPyMMPtre3bI62I=; b=fFCU+BTSvMcw40/9d2OJEGYO8PTt2IkOL+k2ogYCHQ6gSan7I59J6sqKvwIYhtB00O1miq 7QNmDDDKO8phwduyBqt0GILKBy3hCii9xcsh/KAPCPKERfsDxruXa9SWgIkHRWCS4EIYXy ZhteU4zaoVkmaQ7RbSzBCZUPYYu2jg8= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-99-Y1J7jRnCPGy9r7DOOErYwA-1; Tue, 03 Mar 2026 03:41:30 -0500 X-MC-Unique: Y1J7jRnCPGy9r7DOOErYwA-1 X-Mimecast-MFC-AGG-ID: Y1J7jRnCPGy9r7DOOErYwA_1772527289 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 548141800342; Tue, 3 Mar 2026 08:41:29 +0000 (UTC) Received: from redhat.com (unknown [10.45.225.185]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9F6441800349; Tue, 3 Mar 2026 08:41:26 +0000 (UTC) Date: Tue, 3 Mar 2026 08:41:22 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Yodel Eldar Cc: qemu-devel@nongnu.org, Paolo Bonzini , Alex =?utf-8?Q?Benn=C3=A9e?= , Thomas Huth , Peter Maydell Subject: Re: [RFC PATCH v2] configure: Use clang for sanitizer builds or disable Werror Message-ID: References: <20260303012054.484837-1-yodel.eldar@yodel.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260303012054.484837-1-yodel.eldar@yodel.dev> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -5 X-Spam_score: -0.6 X-Spam_bar: / X-Spam_report: (-0.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.968, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.495, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Mar 02, 2026 at 07:20:54PM -0600, Yodel Eldar wrote: > From: Yodel Eldar > > Builds with --enable-{asan,tsan,safe-stack} fail under GCC, so use > clang if available, otherwise disable the treatment of warnings as > errors. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3006 > Suggested-by: Peter Maydell > Signed-off-by: Yodel Eldar > --- > Hi, > > The previous version only disabled Werror whenever `--skip-meson` wasn't > used and the build occurred in a git repo, but this change should > probably apply to all types of builds. So, let's use meson_option_add > to globally disable Werror instead; IIUC (and according to my testing), > this will override the value in config-meson.cross.new. > > I'm still not sure if we should be disabling Werror for ubsan, even > though it's not currently breaking builds with GCC; please let me know > what you think. > > Special thanks to Peter for looking into the cause of the reports around > this, for sharing the findings, and suggesting approaches to resolve it. > I couldn't pick one over the other, so I went with using clang when > available with Werror disable as a fallback; please let me know if you > think this is an XOR kind of policy decision. In the bug > > Link to RFCv1: > https://lore.kernel.org/qemu-devel/20260302210039.261325-1-yodel.eldar@yodel.dev/ > > Link to mentioned discussion: > https://lore.kernel.org/qemu-devel/CAFEAcA88hc4UsgpuPXBWpbeN0tW26159kPn7jx2J9erBA5DLBw@mail.gmail.com/ > > v2: > - Fix misnomer in commit message > - Simplify condition by using the same variable for all sanitizers > - Use meson_option_add to disable Werror > > Thanks, > Yodel > --- > configure | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/configure b/configure > index 5e114acea2..e457e8a17d 100755 > --- a/configure > +++ b/configure > @@ -762,6 +762,12 @@ for opt do > ;; > --wasm64-32bit-address-limit) > ;; > + --enable-asan) use_sanitizer="yes" > + ;; > + --enable-tsan) use_sanitizer="yes" > + ;; > + --enable-safe-stack) use_sanitizer="yes" > + ;; > # everything else has the same name in configure and meson > --*) meson_option_parse "$opt" "$optarg" > ;; > @@ -771,6 +777,18 @@ for opt do > esac > done > > +if test "$use_sanitizer" = "yes"; then > + if has clang; then > + echo "Sanitizer requested: setting compiler suite to clang" > + cc=clang > + cxx=clang++ > + host_cc=clang > + else > + echo "Sanitizer requested: disabling Werror for non-clang compilers" > + meson_option_add -Dwerror=false > + fi > +fi GCC documents the possibility of false positives, but I would consider that caveat to apply to CLang too. It may simply have different false positives or at a lower rate. I don't think it is acceptable to override the user's choice of compiler, and I'm not really a fan of auto-changing use of -Werror either. If using sanitizers, it is expected behaviour that there can be false positives, and if the user doesn't want the build to break as a result of that, then *the user* can choose to disable -Werror with the suitable configure warnings. So IMHO the issue above is not a bug - it is sanitizers doing what they are expected to do. If we want to inform the user of the possible fallout, then it would suffice to print a warning message at the end of meson: if sanitizers and -Werror warning("Note: sanitizers may produce false positives." "It is recommended to disable -Werror if requiring" "a complete build of QEMU without errors") endif With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|