From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11C2AC433FE for ; Tue, 15 Nov 2022 01:19:29 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouimq-0006vW-6G; Mon, 14 Nov 2022 18:22:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouiem-0001zn-LY; Mon, 14 Nov 2022 18:14:24 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouck7-0002yQ-Ru; Mon, 14 Nov 2022 11:55:33 -0500 Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.5) with ESMTP id 2AEGsloK013997; Mon, 14 Nov 2022 16:55:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=qp4fgrPxP7ot7YFt0KlLM8r4jx1sH4LxiiZLP4zGlyY=; b=T1Je63Qmf5IZY6PaFA+O/Cn08y8PM67M7Y/3jV2DTDeWdlaC5X2lIhoTFusyezzRgDTV RKokQnDMbt5PDLnxnEWpTRJmqvhbay8v/F1IbEt4DZ66CI11rlxppmA9kXL9xxR9rg42 EBNYKCsZ6yPHw6W2FgN+UOd8/C2+RNIF4AnfY//a83oTvJaFm2HxpEHyYCCfGLv32jCW GrRZdqUlVUhIq4Gmx1BCtM6mrVBejAavLcX5oe3hVTuU20oQi95k5aY2obg5i8iO72z0 2PiiclNrUKa/gtOk62vnxXzlJFtNHoydmNSYaDSBME9TdGJ3oDQuCPj7l+GaPoA/vtaC LA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3kusky00e8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Nov 2022 16:55:15 +0000 Received: from m0127361.ppops.net (m0127361.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2AEGtELj015466; Mon, 14 Nov 2022 16:55:14 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3kusky00dd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Nov 2022 16:55:14 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2AEGqiUX006239; Mon, 14 Nov 2022 16:55:12 GMT Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by ppma06ams.nl.ibm.com with ESMTP id 3kt2rjaw04-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Nov 2022 16:55:12 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2AEGtAk0393900 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Nov 2022 16:55:10 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 276B15204E; Mon, 14 Nov 2022 16:55:10 +0000 (GMT) Received: from [9.171.78.143] (unknown [9.171.78.143]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 5C98C5204F; Mon, 14 Nov 2022 16:55:09 +0000 (GMT) Message-ID: Date: Mon, 14 Nov 2022 17:55:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v1 5/9] hw/virtio: introduce virtio_device_should_start To: "Michael S. Tsirkin" Cc: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org, fam@euphon.net, berrange@redhat.com, f4bug@amsat.org, aurelien@aurel32.net, pbonzini@redhat.com, stefanha@redhat.com, crosa@redhat.com, Raphael Norwitz , Kevin Wolf , Hanna Reitz , "Dr. David Alan Gilbert" , Viresh Kumar , Mathieu Poirier , "open list:Block layer core" , "open list:virtiofs" References: <20221108092308.1717426-1-alex.bennee@linaro.org> <20221108092308.1717426-6-alex.bennee@linaro.org> <2277569a-c218-30d1-4d88-9b77d3604513@linux.ibm.com> <20221114113518-mutt-send-email-mst@kernel.org> Content-Language: en-US From: Christian Borntraeger In-Reply-To: <20221114113518-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed X-TM-AS-GCONF: 00 X-Proofpoint-GUID: MjSZYCCVARPNIOYf2TOgsDWD1McVA7Z7 X-Proofpoint-ORIG-GUID: 6it0ZKTgg1DEnjZ7OOnXpS3KR-YhQxJ2 Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-14_12,2022-11-11_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 clxscore=1015 mlxlogscore=999 malwarescore=0 suspectscore=0 mlxscore=0 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211140117 Received-SPF: pass client-ip=148.163.158.5; envelope-from=borntraeger@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Am 14.11.22 um 17:37 schrieb Michael S. Tsirkin: > On Mon, Nov 14, 2022 at 05:18:53PM +0100, Christian Borntraeger wrote: >> Am 08.11.22 um 10:23 schrieb Alex Bennée: >>> The previous fix to virtio_device_started revealed a problem in its >>> use by both the core and the device code. The core code should be able >>> to handle the device "starting" while the VM isn't running to handle >>> the restoration of migration state. To solve this dual use introduce a >>> new helper for use by the vhost-user backends who all use it to feed a >>> should_start variable. >>> >>> We can also pick up a change vhost_user_blk_set_status while we are at >>> it which follows the same pattern. >>> >>> Fixes: 9f6bcfd99f (hw/virtio: move vm_running check to virtio_device_started) >>> Fixes: 27ba7b027f (hw/virtio: add boilerplate for vhost-user-gpio device) >>> Signed-off-by: Alex Bennée >>> Cc: "Michael S. Tsirkin" >> >> Hmmm, is this >> commit 259d69c00b67c02a67f3bdbeeea71c2c0af76c35 >> Author: Alex Bennée >> AuthorDate: Mon Nov 7 12:14:07 2022 +0000 >> Commit: Michael S. Tsirkin >> CommitDate: Mon Nov 7 14:08:18 2022 -0500 >> >> hw/virtio: introduce virtio_device_should_start >> >> and older version? > > This is what got merged: > https://lore.kernel.org/r/20221107121407.1010913-1-alex.bennee%40linaro.org > This patch was sent after I merged the RFC. > I think the only difference is the commit log but I might be missing > something. > >> This does not seem to fix the regression that I have reported. > > This was applied on top of 9f6bcfd99f which IIUC does, right? > > QEMU master still fails for me for suspend/resume to disk: #0 0x000003ff8e3980a6 in __pthread_kill_implementation () at /lib64/libc.so.6 #1 0x000003ff8e348580 in raise () at /lib64/libc.so.6 #2 0x000003ff8e32b5c0 in abort () at /lib64/libc.so.6 #3 0x000003ff8e3409da in __assert_fail_base () at /lib64/libc.so.6 #4 0x000003ff8e340a4e in () at /lib64/libc.so.6 #5 0x000002aa1ffa8966 in vhost_vsock_common_pre_save (opaque=) at ../hw/virtio/vhost-vsock-common.c:203 #6 0x000002aa1fe5e0ee in vmstate_save_state_v (f=f@entry=0x2aa21bdc170, vmsd=0x2aa204ac5f0 , opaque=0x2aa21bac9f8, vmdesc=vmdesc@entry=0x3fddc08eb30, version_id=version_id@entry=0) at ../migration/vmstate.c:329 #7 0x000002aa1fe5ebf8 in vmstate_save_state (f=f@entry=0x2aa21bdc170, vmsd=, opaque=, vmdesc_id=vmdesc_id@entry=0x3fddc08eb30) at ../migration/vmstate.c:317 #8 0x000002aa1fe75bd0 in vmstate_save (f=f@entry=0x2aa21bdc170, se=se@entry=0x2aa21bdbe90, vmdesc=vmdesc@entry=0x3fddc08eb30) at ../migration/savevm.c:908 #9 0x000002aa1fe79584 in qemu_savevm_state_complete_precopy_non_iterable (f=f@entry=0x2aa21bdc170, in_postcopy=in_postcopy@entry=false, inactivate_disks=inactivate_disks@entry=true) at ../migration/savevm.c:1393 #10 0x000002aa1fe79a96 in qemu_savevm_state_complete_precopy (f=0x2aa21bdc170, iterable_only=iterable_only@entry=false, inactivate_disks=inactivate_disks@entry=true) at ../migration/savevm.c:1459 #11 0x000002aa1fe6d6ee in migration_completion (s=0x2aa218ef600) at ../migration/migration.c:3314 #12 migration_iteration_run (s=0x2aa218ef600) at ../migration/migration.c:3761 #13 migration_thread (opaque=opaque@entry=0x2aa218ef600) at ../migration/migration.c:3989 #14 0x000002aa201f0b8c in qemu_thread_start (args=) at ../util/qemu-thread-posix.c:505 #15 0x000003ff8e396248 in start_thread () at /lib64/libc.so.6 #16 0x000003ff8e41183e in thread_start () at /lib64/libc.so.6 Michael, your previous branch did work if I recall correctly.