From: Thomas Huth <thuth@redhat.com>
To: Collin Walling <walling@linux.ibm.com>,
qemu-devel@nongnu.org, qemu-s390x@nongnu.org, cohuck@redhat.com,
borntraeger@de.ibm.com
Cc: gor@linux.ibm.com, frankja@linux.ibm.com
Subject: Re: [Qemu-devel] [PATCH 1/4] pc-bios/s390-ccw: rename MAX_TABLE_ENTRIES to MAX_BOOT_ENTRIES
Date: Thu, 12 Apr 2018 20:34:31 +0200 [thread overview]
Message-ID: <aabf8550-46a7-a528-4bac-fa6f66be0520@redhat.com> (raw)
In-Reply-To: <1523372486-13190-2-git-send-email-walling@linux.ibm.com>
On 10.04.2018 17:01, Collin Walling wrote:
> The MAX_TABLE_ENTRIES constant has a name that is too generic. As we
> want to declare a limit for boot menu entries, let's rename it to a more
> fitting MAX_BOOT_ENTRIES and set its value to 31 (30 boot entries and
> 1 default entry). Also we move it from bootmap.h to s390-ccw.h to make
> it available for menu.c in a later patch.
>
> Signed-off-by: Collin Walling <walling@linux.ibm.com>
> ---
> pc-bios/s390-ccw/bootmap.c | 6 +++---
> pc-bios/s390-ccw/bootmap.h | 2 --
> pc-bios/s390-ccw/s390-ccw.h | 2 ++
> 3 files changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2018-04-12 18:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 15:01 [Qemu-devel] [PATCH 0/4] Small fixes for s390x QEMU boot menu Collin Walling
2018-04-10 15:01 ` [Qemu-devel] [PATCH 1/4] pc-bios/s390-ccw: rename MAX_TABLE_ENTRIES to MAX_BOOT_ENTRIES Collin Walling
2018-04-12 18:34 ` Thomas Huth [this message]
2018-04-10 15:01 ` [Qemu-devel] [PATCH 2/4] pc-bios/s390-ccw: fix loadparm initialization and int conversion Collin Walling
2018-04-12 18:57 ` Thomas Huth
2018-04-12 20:57 ` Collin Walling
2018-04-12 21:04 ` Farhan Ali
2018-04-13 4:11 ` Thomas Huth
2018-04-10 15:01 ` [Qemu-devel] [PATCH 3/4] pc-bios/s390-ccw: fix non-sequential boot entries (eckd) Collin Walling
2018-04-13 6:14 ` Thomas Huth
2018-04-13 14:56 ` [Qemu-devel] [qemu-s390x] " Collin Walling
2018-04-10 15:01 ` [Qemu-devel] [PATCH 4/4] pc-bios/s390-ccw: fix non-sequential boot entries (enum) Collin Walling
2018-04-13 7:55 ` Thomas Huth
-- strict thread matches above, loose matches on Subject: below --
2018-04-13 22:08 [Qemu-devel] [PATCH v2 0/4] Small fixes for s390x QEMU boot menu Collin Walling
2018-04-13 22:08 ` [Qemu-devel] [PATCH 1/4] pc-bios/s390-ccw: rename MAX_TABLE_ENTRIES to MAX_BOOT_ENTRIES Collin Walling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aabf8550-46a7-a528-4bac-fa6f66be0520@redhat.com \
--to=thuth@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=walling@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).