From: Eric Blake <eblake@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, thuth@redhat.com, armbru@redhat.com
Subject: Re: [PATCH] qemu-options: replace constant 1 with HAS_ARG
Date: Tue, 4 Feb 2020 11:29:27 -0600 [thread overview]
Message-ID: <aac4e7cc-50e0-6e36-1995-fee3f9f1747a@redhat.com> (raw)
In-Reply-To: <20200204165638.25051-1-jsnow@redhat.com>
On 2/4/20 10:56 AM, John Snow wrote:
> This is the only instance of a non-zero constant not using a symbolic
> constant.
> ---
> qemu-options.hx | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 224a8e8712..ff3e806977 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -1955,7 +1955,7 @@ STEXI
> Start in full screen.
> ETEXI
>
> -DEF("g", 1, QEMU_OPTION_g ,
> +DEF("g", HAS_ARG, QEMU_OPTION_g ,
> "-g WxH[xDEPTH] Set the initial graphical resolution and depth\n",
> QEMU_ARCH_PPC | QEMU_ARCH_SPARC | QEMU_ARCH_M68K)
> STEXI
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-02-04 17:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 16:56 [PATCH] qemu-options: replace constant 1 with HAS_ARG John Snow
2020-02-04 17:29 ` Eric Blake [this message]
2020-02-04 18:58 ` no-reply
2020-02-04 19:06 ` John Snow
2020-02-06 10:09 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aac4e7cc-50e0-6e36-1995-fee3f9f1747a@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).