From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, Eric Blake <eblake@redhat.com>
Cc: Fam Zheng <fam@euphon.net>, Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [RFC PATCH 1/2] scsi/utils: Add INVALID_PARAM_VALUE sense code definition
Date: Wed, 20 Jan 2021 17:04:22 +0100 [thread overview]
Message-ID: <aac76e13-e4c1-9e3b-25d3-33146ed6b1a5@redhat.com> (raw)
In-Reply-To: <20210120160101.nddbb5wjh47hvrj7@sirius.home.kraxel.org>
On 1/20/21 5:01 PM, Gerd Hoffmann wrote:
> Hi,
>
>>> +/* Illegal request, Invalid value in parameter list */
>>> +extern const struct SCSISense sense_code_INVALID_PARAM_VALUE;
>
>> Pre-existing: the term 'illegal' is suspect in computer science (the
>> code isn't breaking any laws);
>
> Indeed. It's named that way in the scsi specs though, and being
> consistent with that is a reasonable thing too ...
In v2 I renamed 'illegal' in the description comments but
not in the #definitions (which match the specs).
Regards,
Phil.
next prev parent reply other threads:[~2021-01-20 16:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 17:03 [RFC PATCH 0/2] hw/usb/dev-uas: Fix Clang 11 -Wgnu-variable-sized-type-not-at-end error Philippe Mathieu-Daudé
2021-01-18 17:03 ` [RFC PATCH 1/2] scsi/utils: Add INVALID_PARAM_VALUE sense code definition Philippe Mathieu-Daudé
2021-01-20 14:58 ` Eric Blake
2021-01-20 16:01 ` Gerd Hoffmann
2021-01-20 16:04 ` Philippe Mathieu-Daudé [this message]
2021-01-18 17:03 ` [RFC PATCH 2/2] hw/usb/dev-uas: Report command additional adb length as unsupported Philippe Mathieu-Daudé
2021-01-19 23:28 ` Philippe Mathieu-Daudé
2021-01-20 14:11 ` Eric Blake
2021-01-19 16:41 ` [RFC PATCH 0/2] hw/usb/dev-uas: Fix Clang 11 -Wgnu-variable-sized-type-not-at-end error Gerd Hoffmann
2021-01-19 16:49 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aac76e13-e4c1-9e3b-25d3-33146ed6b1a5@redhat.com \
--to=philmd@redhat.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).