From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K3cbT-0005qV-7R for qemu-devel@nongnu.org; Tue, 03 Jun 2008 15:55:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K3cbP-0005oD-Jb for qemu-devel@nongnu.org; Tue, 03 Jun 2008 15:55:28 -0400 Received: from [199.232.76.173] (port=36425 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K3cbP-0005o9-Bf for qemu-devel@nongnu.org; Tue, 03 Jun 2008 15:55:27 -0400 Received: from rv-out-0708.google.com ([209.85.198.249]:50934) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K3cbP-0000Jz-5z for qemu-devel@nongnu.org; Tue, 03 Jun 2008 15:55:27 -0400 Received: by rv-out-0708.google.com with SMTP id f25so1354726rvb.22 for ; Tue, 03 Jun 2008 12:55:24 -0700 (PDT) Message-ID: Date: Tue, 3 Jun 2008 12:55:24 -0700 From: "Marc Bevand" Subject: Re: [Qemu-devel] [PATCH] Remove dead-code (else-block) from block-qcow.c In-Reply-To: <484577E3.9020705@codemonkey.ws> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_5914_14037681.1212522924575" References: <484577E3.9020705@codemonkey.ws> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Vegard Nossum , qemu-devel@nongnu.org ------=_Part_5914_14037681.1212522924575 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline On Tue, Jun 3, 2008 at 9:57 AM, Anthony Liguori wrote: > > Please send the patch as an attachment or inlined. Here it is. (I originally wanted to inline it but I am currently stuck with MUAs that cannot be configured to NOT wrap text lines.) To answer Vegard's question, It's gmane that corrupted my email. -- Marc Bevand ------=_Part_5914_14037681.1212522924575 Content-Type: application/octet-stream; name=qemu-remove-dead-code.patch Content-Transfer-Encoding: base64 X-Attachment-Id: f_fh0wphjt0 Content-Disposition: attachment; filename=qemu-remove-dead-code.patch W1BBVENIXSBSZW1vdmUgZGVhZC1jb2RlIChlbHNlLWJsb2NrKSBmcm9tIGJsb2NrLXFjb3cuYwoK ImlmIChhbGxvY2F0ZSA9PSAxKSIgaXMgYWx3YXlzIHRydWUgYmVjYXVzZSB0aGUgdmFsdWUgb2Yg ImFsbG9jYXRlIiBpcwpjaGVja2VkIGEgZmV3IGxpbmVzIGFib3ZlLgoKUGF0Y2ggbWFkZSBhZ2Fp bnN0IFNWTidzIHJldiA0NjIyLgoKClNpZ25lZC1vZmYtYnk6IE1hcmMgQmV2YW5kIDxtLmJldmFu ZCA8YXQ+IGdtYWlsLmNvbT4KCkluZGV4OiBibG9jay1xY293LmMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gYmxv Y2stcWNvdy5jCShyZXZpc2lvbiA0NjIyKQorKysgYmxvY2stcWNvdy5jCSh3b3JraW5nIGNvcHkp CkBAIC0zMzksMzMgKzMzOSwyOCBAQAogICAgICAgICAgICAgICAgIHJldHVybiAtMTsKICAgICAg ICAgfSBlbHNlIHsKICAgICAgICAgICAgIGNsdXN0ZXJfb2Zmc2V0ID0gYmRydl9nZXRsZW5ndGgo cy0+aGQpOwotICAgICAgICAgICAgaWYgKGFsbG9jYXRlID09IDEpIHsKLSAgICAgICAgICAgICAg ICAvKiByb3VuZCB0byBjbHVzdGVyIHNpemUgKi8KLSAgICAgICAgICAgICAgICBjbHVzdGVyX29m ZnNldCA9IChjbHVzdGVyX29mZnNldCArIHMtPmNsdXN0ZXJfc2l6ZSAtIDEpICYKLSAgICAgICAg ICAgICAgICAgICAgfihzLT5jbHVzdGVyX3NpemUgLSAxKTsKLSAgICAgICAgICAgICAgICBiZHJ2 X3RydW5jYXRlKHMtPmhkLCBjbHVzdGVyX29mZnNldCArIHMtPmNsdXN0ZXJfc2l6ZSk7Ci0gICAg ICAgICAgICAgICAgLyogaWYgZW5jcnlwdGVkLCB3ZSBtdXN0IGluaXRpYWxpemUgdGhlIGNsdXN0 ZXIKLSAgICAgICAgICAgICAgICAgICBjb250ZW50IHdoaWNoIHdvbid0IGJlIHdyaXR0ZW4gKi8K LSAgICAgICAgICAgICAgICBpZiAocy0+Y3J5cHRfbWV0aG9kICYmCi0gICAgICAgICAgICAgICAg ICAgIChuX2VuZCAtIG5fc3RhcnQpIDwgcy0+Y2x1c3Rlcl9zZWN0b3JzKSB7Ci0gICAgICAgICAg ICAgICAgICAgIHVpbnQ2NF90IHN0YXJ0X3NlY3Q7Ci0gICAgICAgICAgICAgICAgICAgIHN0YXJ0 X3NlY3QgPSAob2Zmc2V0ICYgfihzLT5jbHVzdGVyX3NpemUgLSAxKSkgPj4gOTsKLSAgICAgICAg ICAgICAgICAgICAgbWVtc2V0KHMtPmNsdXN0ZXJfZGF0YSArIDUxMiwgMHgwMCwgNTEyKTsKLSAg ICAgICAgICAgICAgICAgICAgZm9yKGkgPSAwOyBpIDwgcy0+Y2x1c3Rlcl9zZWN0b3JzOyBpKysp IHsKLSAgICAgICAgICAgICAgICAgICAgICAgIGlmIChpIDwgbl9zdGFydCB8fCBpID49IG5fZW5k KSB7Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgZW5jcnlwdF9zZWN0b3JzKHMsIHN0YXJ0 X3NlY3QgKyBpLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBz LT5jbHVzdGVyX2RhdGEsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHMtPmNsdXN0ZXJfZGF0YSArIDUxMiwgMSwgMSwKLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgJnMtPmFlc19lbmNyeXB0X2tleSk7Ci0gICAgICAgICAgICAg ICAgICAgICAgICAgICAgaWYgKGJkcnZfcHdyaXRlKHMtPmhkLCBjbHVzdGVyX29mZnNldCArIGkg KiA1MTIsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHMtPmNs dXN0ZXJfZGF0YSwgNTEyKSAhPSA1MTIpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHJldHVybiAtMTsKLSAgICAgICAgICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgIC8qIHJv dW5kIHRvIGNsdXN0ZXIgc2l6ZSAqLworICAgICAgICAgICAgY2x1c3Rlcl9vZmZzZXQgPSAoY2x1 c3Rlcl9vZmZzZXQgKyBzLT5jbHVzdGVyX3NpemUgLSAxKSAmCisgICAgICAgICAgICAgICAgfihz LT5jbHVzdGVyX3NpemUgLSAxKTsKKyAgICAgICAgICAgIGJkcnZfdHJ1bmNhdGUocy0+aGQsIGNs dXN0ZXJfb2Zmc2V0ICsgcy0+Y2x1c3Rlcl9zaXplKTsKKyAgICAgICAgICAgIC8qIGlmIGVuY3J5 cHRlZCwgd2UgbXVzdCBpbml0aWFsaXplIHRoZSBjbHVzdGVyCisgICAgICAgICAgICAgICBjb250 ZW50IHdoaWNoIHdvbid0IGJlIHdyaXR0ZW4gKi8KKyAgICAgICAgICAgIGlmIChzLT5jcnlwdF9t ZXRob2QgJiYKKyAgICAgICAgICAgICAgICAobl9lbmQgLSBuX3N0YXJ0KSA8IHMtPmNsdXN0ZXJf c2VjdG9ycykgeworICAgICAgICAgICAgICAgIHVpbnQ2NF90IHN0YXJ0X3NlY3Q7CisgICAgICAg ICAgICAgICAgc3RhcnRfc2VjdCA9IChvZmZzZXQgJiB+KHMtPmNsdXN0ZXJfc2l6ZSAtIDEpKSA+ PiA5OworICAgICAgICAgICAgICAgIG1lbXNldChzLT5jbHVzdGVyX2RhdGEgKyA1MTIsIDB4MDAs IDUxMik7CisgICAgICAgICAgICAgICAgZm9yKGkgPSAwOyBpIDwgcy0+Y2x1c3Rlcl9zZWN0b3Jz OyBpKyspIHsKKyAgICAgICAgICAgICAgICAgICAgaWYgKGkgPCBuX3N0YXJ0IHx8IGkgPj0gbl9l bmQpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgIGVuY3J5cHRfc2VjdG9ycyhzLCBzdGFydF9z ZWN0ICsgaSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzLT5jbHVz dGVyX2RhdGEsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcy0+Y2x1 c3Rlcl9kYXRhICsgNTEyLCAxLCAxLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICZzLT5hZXNfZW5jcnlwdF9rZXkpOworICAgICAgICAgICAgICAgICAgICAgICAgaWYg KGJkcnZfcHdyaXRlKHMtPmhkLCBjbHVzdGVyX29mZnNldCArIGkgKiA1MTIsCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcy0+Y2x1c3Rlcl9kYXRhLCA1MTIpICE9IDUx MikKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gLTE7CiAgICAgICAgICAgICAg ICAgICAgIH0KICAgICAgICAgICAgICAgICB9Ci0gICAgICAgICAgICB9IGVsc2UgewotICAgICAg ICAgICAgICAgIGNsdXN0ZXJfb2Zmc2V0IHw9IFFDT1dfT0ZMQUdfQ09NUFJFU1NFRCB8Ci0gICAg ICAgICAgICAgICAgICAgICh1aW50NjRfdCljb21wcmVzc2VkX3NpemUgPDwgKDYzIC0gcy0+Y2x1 c3Rlcl9iaXRzKTsKICAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgICAgICAvKiB1cGRhdGUg TDIgdGFibGUgKi8K ------=_Part_5914_14037681.1212522924575--