From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 046E5C021A9 for ; Mon, 17 Feb 2025 20:02:49 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tk7Jl-000465-Kx; Mon, 17 Feb 2025 15:02:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tk7Jb-00045M-0C for qemu-devel@nongnu.org; Mon, 17 Feb 2025 15:02:04 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tk7JX-0003ya-1C for qemu-devel@nongnu.org; Mon, 17 Feb 2025 15:02:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739822515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=wXqJjfV+Nc9DrchdRrwBKZs1sdkyqO9zOiFQdd7ny7o=; b=Fro28vN65H6N9+fpnUSh/BD8R+sk9dkU2aU5whu0Z+GLlXablSfWLpsGle6Exg+duWtUBW HJdemsQ//yjKQHMxXIyOIJ7gIpD7GCMGp+7LoQLnowrEdh2PN/ciTui13H0TqsEjfpk/hK YDXXH0nt5rJK8teNIUoiKK8qsNXNZ/I= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-257-eeKdlLkrOEmFwlERAp5pLA-1; Mon, 17 Feb 2025 15:01:53 -0500 X-MC-Unique: eeKdlLkrOEmFwlERAp5pLA-1 X-Mimecast-MFC-AGG-ID: eeKdlLkrOEmFwlERAp5pLA_1739822512 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-38f36fcf4b3so1432716f8f.1 for ; Mon, 17 Feb 2025 12:01:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739822512; x=1740427312; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=wXqJjfV+Nc9DrchdRrwBKZs1sdkyqO9zOiFQdd7ny7o=; b=bhqhO8QcEQVi/Ot5gzRhAlDYIJZrj2wxExWZel4rmZZFdoiE6MIJR7ns40kt44Gja7 RZgQjUFN/5WmDSsAYS0NHiprdKoo9FDa2i4Db2QWDTI3HbHyu2xo03laLaGUxJrnOrr4 dm3Bvp/OCfMHV5Z1VZV+4WGzWVSqvybYExx+OA8MVfZaUH3jr4uLLl7Y6nUQVK8fM3k/ rviB+DeClj7Zat3xVkfh7BpFspOf3iEhyl3gqdgyNyh6q9e+M3h4GxMJnTNs0FTS5qcs x6WdGapzQCpy0a4lIE7kTc9Bnr1uu2m63KfliHiHwRwZ7eEIcCWMPy93K9YXBw2cFIRA QLrA== X-Forwarded-Encrypted: i=1; AJvYcCVfWtsbxCdvjjunBHmVm7BhlxynVjNGa0M1rEd12zMVAPmmPZm19lPgQKyqMCIBHQPfLcmVA5y088k2@nongnu.org X-Gm-Message-State: AOJu0YyFwtE1qdZFz+oXyi0IGFydOax5R8TVFRTfPi2fC1HwEuTY9p7Y 54Vc1c3zMqhnl+S8+bt/GWM7gYABVWZyYaN9+nm05A8FTzbTlfh7UuDMRFovT/z+BlJ7SLwVfL2 G3mrtOs17BgU234Gy4uqU/jPmErRJQT4ng1gWQj1zJpccqMdSmEGi X-Gm-Gg: ASbGncvTMyOrvNU4r+W7P1Hwc6F3no+ABtyKWmiyw1iRvnxTa8pU3QjHsDm5TM/XkPz KTWFOekJCb47bhqqZ6Js6hqsPRZZq1lSIkSkSHEPn7ahTW7Bxdqhp3LJ97dfaJQCuw/TzRQZuE7 5HhxCQGmGwbrxqBgHW5eMBkM8b+OzFhaTsaF0DWozfMbhbH/ilJwQO2ahSMm0v0L028f5HRLq+p ad6X5ZR9rBQBrje5y+QAggNJb3+1aw0dBY3tqO3nGKbo5zLT765lhin5gdAna+jHPFZeg81cJOk IH4Z0+LjTZ3qsLkmtcEqCCOcWeCMRYgi652E8+lYPM+beykAvTJWzjgpBIQxCT+kUTVLwmF9epO IRDcQ7AtgzqwweBXbluuvkGHyvU8sSQ== X-Received: by 2002:a5d:5f87:0:b0:38f:277a:4ec0 with SMTP id ffacd0b85a97d-38f33f11948mr7006892f8f.6.1739822512456; Mon, 17 Feb 2025 12:01:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IGf5GYWTAds4I1Xmy+LSYPOIkvGqrUdpfRr+M1jcw32kF4wFkmwYXXNtQgga1SmadAI6cuw8g== X-Received: by 2002:a5d:5f87:0:b0:38f:277a:4ec0 with SMTP id ffacd0b85a97d-38f33f11948mr7006866f8f.6.1739822512046; Mon, 17 Feb 2025 12:01:52 -0800 (PST) Received: from ?IPV6:2003:cb:c739:900:900f:3c9e:2f7b:5d0a? (p200300cbc7390900900f3c9e2f7b5d0a.dip0.t-ipconnect.de. [2003:cb:c739:900:900f:3c9e:2f7b:5d0a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38f258b4344sm13265857f8f.13.2025.02.17.12.01.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Feb 2025 12:01:50 -0800 (PST) Message-ID: Date: Mon, 17 Feb 2025 21:01:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/9] vhost-user: Add SHMEM_MAP/UNMAP requests To: Albert Esteve , qemu-devel@nongnu.org Cc: slp@redhat.com, stevensd@chromium.org, =?UTF-8?Q?Alex_Benn=C3=A9e?= , Stefano Garzarella , stefanha@redhat.com, hi@alyssa.is, mst@redhat.com, jasowang@redhat.com References: <20250217164012.246727-1-aesteve@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250217164012.246727-1-aesteve@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 17.02.25 17:40, Albert Esteve wrote: > Hi all, > Hi, looks like our debugging session was successfu :) One question below. > v3->v4 > - Change mmap strategy to use RAM blocks > and subregions. > - Add new bitfield to qmp feature map > - Followed most review comments from > last iteration. > - Merged documentation patch again with > this one. Makes more sense to > review them together after all. > - Add documentation for MEM_READ/WRITE > messages. > > The goal of this patch is to support > dynamic fd-backed memory maps initiated > from vhost-user backends. > There are many devices that could already > benefit of this feature, e.g., > virtiofs or virtio-gpu. > > After receiving the SHMEM_MAP/UNMAP request, > the frontend creates the RAMBlock form the > fd and maps it by adding it as a subregion > of the shared memory region container. > > The VIRTIO Shared Memory Region list is > declared in the `VirtIODevice` struct > to make it generic. > > TODO: There was a conversation on the > previous version around adding tests > to the patch (which I have acknowledged). > However, given the numerous changes > that the patch already has, I have > decided to send it early and collect > some feedback while I work on the > tests for the next iteration. > Given that I have been able to > test the implementation with > my local setup, I am more or less > confident that, at least, the code > is in a relatively sane state > so that no reviewing time is > wasted on broken patches. > > This patch also includes: > - SHMEM_CONFIG frontend request that is > specifically meant to allow generic > vhost-user-device frontend to be able to > query VIRTIO Shared Memory settings from the > backend (as this device is generic and agnostic > of the actual backend configuration). > > - MEM_READ/WRITE backend requests are > added to deal with a potential issue when having > multiple backends sharing a file descriptor. > When a backend calls SHMEM_MAP it makes > accessing to the region fail for other > backend as it is missing from their translation > table. So these requests are a fallback > for vhost-user memory translation fails. Can you elaborate what the issue here is? Why would SHMEM_MAP make accessing the region fail for other backends -- what makes this missing from their translation? -- Cheers, David / dhildenb