From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Max Reitz <mreitz@redhat.com>, Greg Kurz <groug@kaod.org>,
stefanha@redhat.com
Subject: Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)
Date: Thu, 4 Feb 2021 18:55:09 +0100 [thread overview]
Message-ID: <aadb42d5-ea06-609a-159f-ba66378d3134@redhat.com> (raw)
In-Reply-To: <573fa4c4-6092-09ac-be49-0cc18af72a1a@redhat.com>
On 04/02/21 18:42, Philippe Mathieu-Daudé wrote:
> On 2/4/21 3:40 PM, Paolo Bonzini wrote:
>> On 04/02/21 15:22, Wainer dos Santos Moschetta wrote:
>>>>> -F: docs/interop/virtfs-proxy-helper.rst
>>>>> +F: docs/tools/virtfs-proxy-helper.rst
>>>>
>>>> Unrelated, but Paolo once said helpers are not tools.
>>
>> I think helpers is not a good word. However, if an executable:
>>
>> - can be started directly by QEMU, or is not useful without an emulator
>>
>> - is usually too complex for a user to run manually
>>
>> then it should be documented in docs/interop (not docs/tools). Their
>> sources however can be in tools/, that's not a problem at all.
>
> I understand tools can be built/used standalone (no dependence),
> while helpers are companion of another binary, thus dependent on it:
>
> - we can build tools without emulator
> - it is probably pointless to build an helper without its helpee
> - some binaries can't be use without helpers
>
> Maybe "companion" is a better candidate to describe?
I don't think we use the word helper anymore in the build system, so
really the only thing left is whether the documentation goes in tools/
or interop/.
The sources can be in tools/ unconditionally if people decide that's
desirable, either with or without subdirectories. I didn't propose that
because the Meson change was big enough and it can be the decision of
individual maintainers.
Moving the individual tools is easy enough, since most of them are just
one source file, however moving the executables would require changes in
the tests and son on.
Paolo
next prev parent reply other threads:[~2021-02-04 18:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 13:54 [PATCH v2] MAINTAINERS: Fix the location of tools manuals Wainer dos Santos Moschetta
2021-02-04 13:59 ` Philippe Mathieu-Daudé
2021-02-04 14:22 ` [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals) Wainer dos Santos Moschetta
2021-02-04 14:31 ` Peter Maydell
2021-02-04 14:40 ` Kevin Wolf
2021-02-04 14:47 ` Daniel P. Berrangé
2021-02-04 14:50 ` Peter Maydell
2021-02-04 15:02 ` Paolo Bonzini
2021-02-04 15:06 ` Daniel P. Berrangé
2021-02-04 17:37 ` Philippe Mathieu-Daudé
2021-02-04 17:39 ` Paolo Bonzini
2021-02-04 15:04 ` Daniel P. Berrangé
2021-02-04 14:57 ` Kevin Wolf
2021-02-04 14:47 ` Peter Maydell
2021-02-04 14:40 ` Paolo Bonzini
2021-02-04 17:42 ` Philippe Mathieu-Daudé
2021-02-04 17:55 ` Paolo Bonzini [this message]
2021-02-04 18:24 ` Eric Blake
2021-02-04 20:57 ` John Snow
2021-03-09 17:41 ` [PATCH v2] MAINTAINERS: Fix the location of tools manuals Wainer dos Santos Moschetta
2021-03-09 19:48 ` Thomas Huth
2021-03-09 20:44 ` Laurent Vivier
2021-03-09 22:54 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aadb42d5-ea06-609a-159f-ba66378d3134@redhat.com \
--to=pbonzini@redhat.com \
--cc=dgilbert@redhat.com \
--cc=groug@kaod.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).