* [PATCH] usb: fix usb-host dependency check
@ 2021-07-21 8:17 Gerd Hoffmann
2021-07-21 8:21 ` Philippe Mathieu-Daudé
2021-07-21 9:45 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2021-07-21 8:17 UTC (permalink / raw)
To: qemu-devel; +Cc: Programmingkid, Gerd Hoffmann
Fixes: 627302afb2f8 ("usb: build usb-host as module")
Reported-by: Programmingkid <programmingkidx@gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/usb/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/meson.build b/hw/usb/meson.build
index 3ca61279374d..de853d780dd8 100644
--- a/hw/usb/meson.build
+++ b/hw/usb/meson.build
@@ -72,7 +72,7 @@ if usbredir.found()
endif
# usb pass-through
-if config_host.has_key('CONFIG_USB_LIBUSB')
+if libusb.found()
usbhost_ss = ss.source_set()
usbhost_ss.add(when: ['CONFIG_USB', libusb],
if_true: files('host-libusb.c'))
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] usb: fix usb-host dependency check
2021-07-21 8:17 [PATCH] usb: fix usb-host dependency check Gerd Hoffmann
@ 2021-07-21 8:21 ` Philippe Mathieu-Daudé
2021-07-21 9:45 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-07-21 8:21 UTC (permalink / raw)
To: Gerd Hoffmann, qemu-devel; +Cc: Programmingkid
On 7/21/21 10:17 AM, Gerd Hoffmann wrote:
> Fixes: 627302afb2f8 ("usb: build usb-host as module")
> Reported-by: Programmingkid <programmingkidx@gmail.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> hw/usb/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] usb: fix usb-host dependency check
2021-07-21 8:17 [PATCH] usb: fix usb-host dependency check Gerd Hoffmann
2021-07-21 8:21 ` Philippe Mathieu-Daudé
@ 2021-07-21 9:45 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2021-07-21 9:45 UTC (permalink / raw)
To: Gerd Hoffmann, qemu-devel, Programmingkid
On 21/07/21 10:17, Gerd Hoffmann wrote:
> Fixes: 627302afb2f8 ("usb: build usb-host as module")
> Reported-by: Programmingkid <programmingkidx@gmail.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> hw/usb/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/usb/meson.build b/hw/usb/meson.build
> index 3ca61279374d..de853d780dd8 100644
> --- a/hw/usb/meson.build
> +++ b/hw/usb/meson.build
> @@ -72,7 +72,7 @@ if usbredir.found()
> endif
>
> # usb pass-through
> -if config_host.has_key('CONFIG_USB_LIBUSB')
> +if libusb.found()
> usbhost_ss = ss.source_set()
> usbhost_ss.add(when: ['CONFIG_USB', libusb],
> if_true: files('host-libusb.c'))
>
Actually
Fixes: 90540f3289 ("configure, meson: convert libusb detection to
meson", 2021-06-25)
Sorry about that.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-21 9:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-21 8:17 [PATCH] usb: fix usb-host dependency check Gerd Hoffmann
2021-07-21 8:21 ` Philippe Mathieu-Daudé
2021-07-21 9:45 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).