From: Eric Blake <eblake@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org, Jason Wang <jasowang@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH v2 2/2] net: Drop the NetLegacy structure, always use Netdev instead
Date: Tue, 12 May 2020 10:51:11 -0500 [thread overview]
Message-ID: <aaf3efdc-072f-4b55-8bff-402be55b604b@redhat.com> (raw)
In-Reply-To: <ef4bd3f7-c023-d4c8-b4b6-2b8abe9e1cdb@redhat.com>
On 5/12/20 10:13 AM, Thomas Huth wrote:
>>> +++ b/qapi/net.json
>>> @@ -453,7 +453,7 @@
>>> # 'l2tpv3' - since 2.1
>>> ##
>>> { 'union': 'Netdev',
>>> - 'base': { 'id': 'str', 'type': 'NetClientDriver' },
>>> + 'base': { '*id': 'str', 'type': 'NetClientDriver' },
>>
>> I don't think we need to make 'id' optional.
>
> It's required for "-net" now.
But does -net generate it's own id if one is not provided? Can it still
be mandatory in the QAPI type, and just figure out how to guarantee that
the CLI parsing of -net provides a name early enough in the cycle to use
the QAPI type without making the member optional there?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-05-12 15:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 12:31 [PATCH v2 0/2] net: Drop legacy "name" from -net and remove NetLegacy Thomas Huth
2020-05-12 12:31 ` [PATCH v2 1/2] net: Drop the legacy "name" parameter from the -net option Thomas Huth
2020-05-12 14:26 ` Eric Blake
2020-05-12 14:50 ` Thomas Huth
2020-05-12 12:31 ` [PATCH v2 2/2] net: Drop the NetLegacy structure, always use Netdev instead Thomas Huth
2020-05-12 14:32 ` Eric Blake
2020-05-12 15:13 ` Thomas Huth
2020-05-12 15:51 ` Eric Blake [this message]
2020-05-13 8:40 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaf3efdc-072f-4b55-8bff-402be55b604b@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).