From: Laurent Vivier <laurent@vivier.eu>
To: Helge Deller <deller@gmx.de>, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/2] linux-user: Show 4th argument of rt_sigprocmask() in strace
Date: Mon, 30 Jan 2023 13:37:31 +0100 [thread overview]
Message-ID: <aaf8b01b-6c63-0aa7-a6b7-91990bf13eb5@vivier.eu> (raw)
In-Reply-To: <20230125135749.4594-2-deller@gmx.de>
Le 25/01/2023 à 14:57, Helge Deller a écrit :
> Add output for the missing 4th parameter (size_t sigsetsize).
>
> Signed-off-by: Helge Deller <deller@gmx.de>
> ---
> linux-user/strace.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/linux-user/strace.c b/linux-user/strace.c
> index 3157e4b420..e3aa994678 100644
> --- a/linux-user/strace.c
> +++ b/linux-user/strace.c
> @@ -3146,7 +3146,8 @@ print_rt_sigprocmask(CPUArchState *cpu_env, const struct syscallname *name,
> }
> qemu_log("%s,", how);
> print_pointer(arg1, 0);
> - print_pointer(arg2, 1);
> + print_pointer(arg2, 0);
> + print_raw_param("%d", arg3, 1);
Better with "%u" as size_t is unsigned.
Thanks,
Laurent
> print_syscall_epilogue(name);
> }
> #endif
> --
> 2.38.1
>
>
next prev parent reply other threads:[~2023-01-30 12:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 13:57 [PATCH 1/2] linux-user: Show SIGCHLD in clone() strace output Helge Deller
2023-01-25 13:57 ` [PATCH 2/2] linux-user: Show 4th argument of rt_sigprocmask() in strace Helge Deller
2023-01-30 12:37 ` Laurent Vivier [this message]
2023-01-25 14:18 ` [PATCH 1/2] linux-user: Show SIGCHLD in clone() strace output Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaf8b01b-6c63-0aa7-a6b7-91990bf13eb5@vivier.eu \
--to=laurent@vivier.eu \
--cc=deller@gmx.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).