From: Paolo Bonzini <pbonzini@redhat.com>
To: Yang Zhong <yang.zhong@intel.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, thuth@redhat.com, ehabkost@redhat.com,
sameo@linux.intel.com
Subject: Re: [Qemu-devel] [RFC PATCH v4 00/44] Support Kconfig in QEMU
Date: Thu, 24 Jan 2019 02:09:25 +0100 [thread overview]
Message-ID: <ab10ffce-c591-a08c-3ecf-145f1ef0cd07@redhat.com> (raw)
In-Reply-To: <20190123065618.3520-1-yang.zhong@intel.com>
On 23/01/19 07:55, Yang Zhong wrote:
> This Kconfig implementation is rebased from Paolo's branch
> https://github.com/bonzini/qemu/commits/kconfig
>
> I rebased most of patches except non-x86 ARCHs dependency definitions
> this time.
> https://github.com/yangzhon/qemu/commits/topic/upstream/Kconfig
>
> The current RFC patches only support
> (*) x86_64 platform build
> Once design is fixed, we can do other archs.
>
> (*) defconfig
> "randconfig" build has some issues, which are mostly related
> with CONFIG* in Kconfig.host abd configure. In randconfig mode,
> some CONFIG* has different setting value in config-host.mak and
> %/config-device.mak, which make QEMU build failure.
>
> (*) Kconfig in hw/ directory
>
> The current configure and build command are same with previous
> commands and if we want to disable or enable some features, like
> "tcg", we still need add "--enable/--disable-tcg" in configure
> command line. If we want to disable one emulation device, we can
> disable this in related Kconfig file in hw/ directory.
>
> The current build command:
> (*) ./configure --target-list=x86_64-softmmu
> (*) make -j8
>
> Since the Kconfig language replace traditional CONFIG_* in
> default-config/%-softmmu.mak, the %-softmmu.mak file only
> define embeded boards or machines, like 440fx and Q35 in x86_64
> platform. The Kconfig has already defined dependency topology
> between different Kconfig files, but there are still some issues
>
> (*) Kconfig for configure(config-host.mak)
> Some CONFIG* in configure need some logic to generate, those
> are hard to input this CONFIG* in Kconfig.host or Kconfig* file.
>
> (*) Kconfig for %config-target.mak
> The CONFIG* in %/config-target.mak file, this is still related
> with configure.
>
> (*) randconfig support issue.
>
> Before this RFC patches, we have talked Kconfig in another thread
> http://lists.nongnu.org/archive/html/qemu-devel/2018-09/msg02827.html
>
> Please give your comments on this RFC thread, many thanks!
I started looking at this, and found two bugs in current code
(unreachable devices that shouldn't be there - SERIAL_ISA for ARM,
ACPI_NVDIMM for MIPS). There are a few issues in that the script is not
Python 3-enabled and only x86 compiles, but they are easily fixed. A
slightly bigger thing is to make VFIO configuration more fine-grained
and express it with kconfig dependencies, but it's just a couple patches
in the same spirit as these ones. I'll look at randconfig next.
Paolo
next prev parent reply other threads:[~2019-01-24 1:15 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 6:55 [Qemu-devel] [RFC PATCH v4 00/44] Support Kconfig in QEMU Yang Zhong
2019-01-23 6:55 ` [Qemu-devel] [RFC PATCH v4 01/44] hw/pci-host/Makefile.objs: make CONFIGS clear for PCI EXPRESS Yang Zhong
2019-01-23 6:55 ` [Qemu-devel] [RFC PATCH v4 02/44] build: actually use CONFIG_PAM Yang Zhong
2019-01-23 6:55 ` [Qemu-devel] [RFC PATCH v4 03/44] hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards Yang Zhong
2019-01-23 6:55 ` [Qemu-devel] [RFC PATCH v4 04/44] hw/arm/Makefile.objs: CONFIG_VIRT created for virt board Yang Zhong
2019-01-23 21:06 ` Richard Henderson
2019-01-23 6:55 ` [Qemu-devel] [RFC PATCH v4 05/44] hw/m68k/Makefile.objs: Conditionally build boards Yang Zhong
2019-01-23 6:55 ` [Qemu-devel] [RFC PATCH v4 06/44] hw/microblaze/Makefile.objs: Create configs for petalogix and xilinx boards Yang Zhong
2019-01-23 15:20 ` Thomas Huth
2019-01-23 6:55 ` [Qemu-devel] [RFC PATCH v4 07/44] hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards Yang Zhong
2019-01-23 15:36 ` Thomas Huth
2019-01-23 6:55 ` [Qemu-devel] [RFC PATCH v4 08/44] hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_* Yang Zhong
2019-01-23 15:45 ` Thomas Huth
2019-01-23 6:55 ` [Qemu-devel] [RFC PATCH v4 09/44] hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and device Yang Zhong
2019-01-23 15:58 ` Thomas Huth
2019-01-23 6:55 ` [Qemu-devel] [RFC PATCH v4 10/44] hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created Yang Zhong
2019-01-23 6:55 ` [Qemu-devel] [RFC PATCH v4 11/44] hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst Yang Zhong
2019-01-23 6:55 ` [Qemu-devel] [RFC PATCH v4 12/44] hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga conditionally Yang Zhong
2019-01-23 6:55 ` [Qemu-devel] [RFC PATCH v4 13/44] hw/nios2/Makefile.objs: Conditionally build nios2 Yang Zhong
2019-01-23 6:55 ` [Qemu-devel] [RFC PATCH v4 14/44] hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards Yang Zhong
2019-01-23 16:11 ` Thomas Huth
2019-01-23 21:59 ` Alistair Francis
2019-01-23 6:55 ` [Qemu-devel] [RFC PATCH v4 15/44] hw/sparc64/Makefile.objs: Create CONFIG_* for sparc64 Yang Zhong
2019-01-23 6:55 ` [Qemu-devel] [RFC PATCH v4 16/44] hw/alpha/Makefile.objs: Create CONFIG_* for alpha Yang Zhong
2019-01-23 16:14 ` Thomas Huth
2019-01-23 21:11 ` Richard Henderson
2019-01-24 9:09 ` Thomas Huth
2019-01-24 10:52 ` Paolo Bonzini
2019-01-23 6:55 ` [Qemu-devel] [RFC PATCH v4 17/44] hw/cris/Makefile.objs: Create CONFIG_* for cris Yang Zhong
2019-01-23 16:17 ` Thomas Huth
2019-01-23 6:55 ` [Qemu-devel] [RFC PATCH v4 18/44] hw/hppa/Makefile.objs: Create CONFIG_* for hppa Yang Zhong
2019-01-23 16:23 ` Thomas Huth
2019-01-23 21:15 ` Richard Henderson
2019-01-23 6:55 ` [Qemu-devel] [RFC PATCH v4 19/44] hw/moxie/Makefile.objs: Conditionally build moxie Yang Zhong
2019-01-23 16:26 ` Thomas Huth
2019-01-23 21:16 ` Richard Henderson
2019-01-23 6:55 ` [Qemu-devel] [RFC PATCH v4 20/44] hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc Yang Zhong
2019-01-23 16:41 ` Thomas Huth
2019-01-23 6:55 ` [Qemu-devel] [RFC PATCH v4 21/44] hw/tricore/Makefile.objs: Create CONFIG_* for tricore Yang Zhong
2019-01-23 16:43 ` Thomas Huth
2019-01-23 6:55 ` [Qemu-devel] [RFC PATCH v4 22/44] minikconfig: add parser skeleton Yang Zhong
2019-01-23 6:55 ` [Qemu-devel] [RFC PATCH v4 23/44] minikconfig: add AST Yang Zhong
2019-01-23 6:55 ` [Qemu-devel] [RFC PATCH v4 24/44] minikconfig: add semantic analysis Yang Zhong
2019-01-23 6:55 ` [Qemu-devel] [RFC PATCH v4 25/44] hw/display: make edid configurable Yang Zhong
2019-01-23 6:56 ` [Qemu-devel] [RFC PATCH v4 26/44] kconfig: introduce kconfig files Yang Zhong
2019-01-24 14:06 ` Thomas Huth
2019-01-25 2:18 ` Yang Zhong
2019-01-23 6:56 ` [Qemu-devel] [RFC PATCH v4 27/44] build: switch to Kconfig Yang Zhong
2019-01-23 6:56 ` [Qemu-devel] [RFC PATCH v4 28/44] ide: express dependencies with Kconfig Yang Zhong
2019-01-23 6:56 ` [Qemu-devel] [RFC PATCH v4 29/44] hw/pci/Makefile.objs: make pcie configurable Yang Zhong
2019-01-23 14:23 ` Michael S. Tsirkin
2019-01-25 2:10 ` Yang Zhong
2019-01-25 2:43 ` Michael S. Tsirkin
2019-01-25 2:48 ` Yang Zhong
2019-01-23 6:56 ` [Qemu-devel] [RFC PATCH v4 30/44] build: convert pci.mak to Kconfig Yang Zhong
2019-01-23 21:19 ` Richard Henderson
2019-01-23 6:56 ` [Qemu-devel] [RFC PATCH v4 31/44] build: convert sound.mak " Yang Zhong
2019-01-23 6:56 ` [Qemu-devel] [RFC PATCH v4 32/44] build: convert usb.mak " Yang Zhong
2019-01-23 21:19 ` Richard Henderson
2019-01-23 6:56 ` [Qemu-devel] [RFC PATCH v4 33/44] scsi: express dependencies with Kconfig Yang Zhong
2019-01-23 6:56 ` [Qemu-devel] [RFC PATCH v4 34/44] bluetooth: " Yang Zhong
2019-01-23 6:56 ` [Qemu-devel] [RFC PATCH v4 35/44] isa: express dependencies with kconfig Yang Zhong
2019-01-24 12:23 ` Thomas Huth
2019-01-23 6:56 ` [Qemu-devel] [RFC PATCH v4 36/44] i386: express dependencies with Kconfig Yang Zhong
2019-01-23 6:56 ` [Qemu-devel] [RFC PATCH v4 37/44] i2c: " Yang Zhong
2019-01-23 6:56 ` [Qemu-devel] [RFC PATCH v4 38/44] ptimer: " Yang Zhong
2019-01-23 6:56 ` [Qemu-devel] [RFC PATCH v4 39/44] edid: express dependencies with kconfig Yang Zhong
2019-01-23 6:56 ` [Qemu-devel] [RFC PATCH v4 40/44] hyperv: " Yang Zhong
2019-01-23 6:56 ` [Qemu-devel] [RFC PATCH v4 41/44] virtio: make virtio dependencies with Kconfig Yang Zhong
2019-01-24 12:51 ` Thomas Huth
2019-01-24 13:33 ` Yang Zhong
2019-01-24 14:10 ` Paolo Bonzini
2019-01-23 6:56 ` [Qemu-devel] [RFC PATCH v4 42/44] i386-softmmu.mak: remove all CONFIG_* except boards definitions Yang Zhong
2019-01-23 6:56 ` [Qemu-devel] [RFC PATCH v4 43/44] minikconf: implement allyesconfig, allnoconfig, randconfig, defconfig Yang Zhong
2019-01-23 6:56 ` [Qemu-devel] [RFC PATCH v4 44/44] Makefile: only support defconfig Yang Zhong
2019-01-24 1:09 ` Paolo Bonzini [this message]
2019-01-24 2:00 ` [Qemu-devel] [RFC PATCH v4 00/44] Support Kconfig in QEMU Yang Zhong
2019-01-24 7:39 ` Paolo Bonzini
2019-01-24 2:38 ` BALATON Zoltan
2019-01-24 7:36 ` Paolo Bonzini
2019-01-31 22:15 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab10ffce-c591-a08c-3ecf-145f1ef0cd07@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sameo@linux.intel.com \
--cc=thuth@redhat.com \
--cc=yang.zhong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).