qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	qemu-block@nongnu.org
Cc: kwolf@redhat.com, den@openvz.org, jsnow@redhat.com,
	qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [PATCH v6 02/11] iotests/303: use dot slash for qcow2.py running
Date: Wed, 13 Jan 2021 16:38:03 -0600	[thread overview]
Message-ID: <ab146bc7-a018-095b-5c57-ece919606e08@redhat.com> (raw)
In-Reply-To: <20210109122631.167314-3-vsementsov@virtuozzo.com>

On 1/9/21 6:26 AM, Vladimir Sementsov-Ogievskiy wrote:
> If you run './check 303', check includes common.config which adjusts
> $PATH to include '.' first, and therefore finds qcow2.py on PATH.  But
> if you run './303' directly, there is nothing to adjust PATH, and if
> '.' is not already on your PATH by other means, the test fails because
> the executable is not found.  Adjust how we invoke the helper
> executable to avoid needing a PATH search in the first place.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>  tests/qemu-iotests/303 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/tests/qemu-iotests/303 b/tests/qemu-iotests/303
> index 6c21774483..11cd9eeb26 100755
> --- a/tests/qemu-iotests/303
> +++ b/tests/qemu-iotests/303
> @@ -56,7 +56,7 @@ qemu_img_create('-f', iotests.imgfmt, disk, '10M')
>  
>  add_bitmap(1, 0, 6, False)
>  add_bitmap(2, 6, 8, True)
> -dump = ['qcow2.py', disk, 'dump-header']
> +dump = ['./qcow2.py', disk, 'dump-header']
>  subprocess.run(dump)
>  # Dump the metadata in JSON format
>  dump.append('-j')
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org



  reply	other threads:[~2021-01-13 22:39 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-09 12:26 [PATCH v6 00/11] Rework iotests/check Vladimir Sementsov-Ogievskiy
2021-01-09 12:26 ` [PATCH v6 01/11] iotests/277: use dot slash for nbd-fault-injector.py running Vladimir Sementsov-Ogievskiy
2021-01-13 22:37   ` Eric Blake
2021-01-09 12:26 ` [PATCH v6 02/11] iotests/303: use dot slash for qcow2.py running Vladimir Sementsov-Ogievskiy
2021-01-13 22:38   ` Eric Blake [this message]
2021-01-09 12:26 ` [PATCH v6 03/11] iotests: fix some whitespaces in test output files Vladimir Sementsov-Ogievskiy
2021-01-13 22:51   ` Eric Blake
2021-01-09 12:26 ` [PATCH v6 04/11] iotests: make tests executable Vladimir Sementsov-Ogievskiy
2021-01-13 22:53   ` Eric Blake
2021-01-09 12:26 ` [PATCH v6 05/11] iotests/294: add shebang line Vladimir Sementsov-Ogievskiy
2021-01-13 22:54   ` Eric Blake
2021-01-09 12:26 ` [PATCH v6 06/11] iotests: define group in each iotest Vladimir Sementsov-Ogievskiy
2021-01-13 23:01   ` Eric Blake
2021-01-09 12:26 ` [PATCH v6 07/11] iotests: add findtests.py Vladimir Sementsov-Ogievskiy
2021-01-12 16:42   ` Kevin Wolf
2021-01-13 10:37     ` Vladimir Sementsov-Ogievskiy
2021-01-13 11:18       ` Kevin Wolf
2021-01-14  7:38     ` Vladimir Sementsov-Ogievskiy
2021-01-14 10:48       ` Kevin Wolf
2021-01-13 23:10   ` Eric Blake
2021-01-09 12:26 ` [PATCH v6 08/11] iotests: add testenv.py Vladimir Sementsov-Ogievskiy
2021-01-12 17:36   ` Kevin Wolf
2021-01-14  6:14     ` Vladimir Sementsov-Ogievskiy
2021-01-14  6:16       ` Vladimir Sementsov-Ogievskiy
2021-01-14  4:28   ` Vladimir Sementsov-Ogievskiy
2021-01-14 11:14     ` Kevin Wolf
2021-01-14 11:26       ` Vladimir Sementsov-Ogievskiy
2021-01-15 11:18   ` Kevin Wolf
2021-01-15 12:19     ` Vladimir Sementsov-Ogievskiy
2021-01-15 12:45       ` Kevin Wolf
2021-01-15 13:10         ` Vladimir Sementsov-Ogievskiy
2021-01-15 13:20           ` Kevin Wolf
2021-01-15 13:30             ` Vladimir Sementsov-Ogievskiy
2021-01-16 11:03               ` Vladimir Sementsov-Ogievskiy
2021-01-16 11:19                 ` Vladimir Sementsov-Ogievskiy
2021-01-18  9:59                 ` Kevin Wolf
2021-01-18 17:00                   ` Vladimir Sementsov-Ogievskiy
2021-01-09 12:26 ` [PATCH v6 09/11] iotests: add testrunner.py Vladimir Sementsov-Ogievskiy
2021-01-09 12:26 ` [PATCH v6 10/11] iotests: rewrite check into python Vladimir Sementsov-Ogievskiy
2021-01-12 17:41   ` Kevin Wolf
2021-01-13 23:20   ` Eric Blake
2021-01-14  0:18     ` John Snow
2021-01-09 12:26 ` [PATCH v6 11/11] iotests: rename and move 169 and 199 tests Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab146bc7-a018-095b-5c57-ece919606e08@redhat.com \
    --to=eblake@redhat.com \
    --cc=den@openvz.org \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).