Re: [PATCH v2 1/2] qga: replace slog() with standard GLib logging

["Daniel P. Berrangé" <berrange@redhat.com>]

On Wed, Mar 18, 2026 at 05:47:51PM +0200, Elizabeth Ashurov wrote:
> Replace qga-specific slog() calls with standard GLib logging APIs.
> Use g_info() for command execution messages and g_warning() for
> non-fatal failures, and remove the use of "syslog" as a log domain.
> 
> Rework ga_log() to route messages to the log file and
> syslog/Event Viewer, filtering by log level. Debug messages are
> excluded from syslog even with --debug.
> 
> - Default log level includes ERROR and CRITICAL
> - -v/--verbose enables WARNING, MESSAGE, and INFO

IMHO "WARNING" should be enabled by default too.

> - -g/--debug enables all levels including DEBUG

Since we can't use the natural '-d' short option, we can
probably do with only the the long option.

> 
> Signed-off-by: Elizabeth Ashurov <eashurov@redhat.com>
> ---
>  qga/commands-linux.c   |  6 ++---
>  qga/commands-posix.c   | 26 +++++++++---------
>  qga/commands-win32.c   | 60 +++++++++++++++++++++---------------------
>  qga/commands.c         | 29 ++++++--------------
>  qga/guest-agent-core.h |  1 -
>  qga/main.c             | 39 +++++++++++++++++++--------
>  6 files changed, 82 insertions(+), 79 deletions(-)


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|