From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: Devaraj Ranganna <devaraj.ranganna@linaro.org>,
Kumar Gala <kumar.gala@linaro.org>,
Kevin Townsend <kevin.townsend@linaro.org>,
Jimmy Brisson <jimmy.brisson@linaro.org>
Subject: Re: [PATCH 1/6] hw/arm/mps2-tz: Don't duplicate modelling of SRAM in AN524
Date: Mon, 24 May 2021 06:44:40 -0700 [thread overview]
Message-ID: <ab21f19f-76d2-0bdf-5f26-ff6082855285@linaro.org> (raw)
In-Reply-To: <20210510190844.17799-2-peter.maydell@linaro.org>
On 5/10/21 12:08 PM, Peter Maydell wrote:
> The SRAM at 0x2000_0000 is part of the SSE-200 itself, and we model
> it that way in hw/arm/armsse.c (along with the associated MPCs). We
> incorrectly also added an entry to the RAMInfo array for the AN524 in
> hw/arm/mps2-tz.c, which was pointless because the CPU would never see
> it. Delete it.
>
> The bug had no guest-visible effect because devices in the SSE-200
> take priority over those in the board model (armsse.c maps
> s->board_memory at priority -2).
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2021-05-24 13:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 19:08 [PATCH 0/6] hw/arm: Fix modelling of SSE-300 TCMs and SRAM Peter Maydell
2021-05-10 19:08 ` [PATCH 1/6] hw/arm/mps2-tz: Don't duplicate modelling of SRAM in AN524 Peter Maydell
2021-05-24 13:44 ` Richard Henderson [this message]
2021-05-10 19:08 ` [PATCH 2/6] hw/arm/mps2-tz: Make SRAM_ADDR_WIDTH board-specific Peter Maydell
2021-05-24 13:49 ` Richard Henderson
2021-05-10 19:08 ` [PATCH 3/6] hw/arm/armsse.c: Correct modelling of SSE-300 internal SRAMs Peter Maydell
2021-05-24 13:53 ` Richard Henderson
2021-05-10 19:08 ` [PATCH 4/6] hw/arm/armsse: Convert armsse_realize() to use ERRP_GUARD Peter Maydell
2021-05-24 13:55 ` Richard Henderson
2021-05-10 19:08 ` [PATCH 5/6] hw/arm/mps2-tz: Allow board to specify a boot RAM size Peter Maydell
2021-05-24 14:22 ` Richard Henderson
2021-05-10 19:08 ` [PATCH 6/6] hw/arm: Model TCMs in the SSE-300, not the AN547 Peter Maydell
2021-05-24 14:25 ` Richard Henderson
2021-05-10 19:14 ` [PATCH 0/6] hw/arm: Fix modelling of SSE-300 TCMs and SRAM Philippe Mathieu-Daudé
2021-05-10 19:22 ` Peter Maydell
2021-05-10 19:37 ` Philippe Mathieu-Daudé
2021-05-20 13:23 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab21f19f-76d2-0bdf-5f26-ff6082855285@linaro.org \
--to=richard.henderson@linaro.org \
--cc=devaraj.ranganna@linaro.org \
--cc=jimmy.brisson@linaro.org \
--cc=kevin.townsend@linaro.org \
--cc=kumar.gala@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).