qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Cc: schwab@linux-m68k.org, agraf@suse.de, gerg@uclinux.org
Subject: Re: [Qemu-devel] [PATCH v3 1/2] target-m68k: add abcd/sbcd/nbcd
Date: Tue, 8 Nov 2016 11:11:51 +0100	[thread overview]
Message-ID: <ab2a2bd7-a73b-407f-ea78-3c97b76029c9@twiddle.net> (raw)
In-Reply-To: <1478541561-16718-2-git-send-email-laurent@vivier.eu>

On 11/07/2016 06:59 PM, Laurent Vivier wrote:
> +    tcg_gen_movi_i32(QREG_CC_X, 0);
> +    tcg_gen_andi_i32(val, val, 0x100);
> +    tcg_gen_setcond_i32(TCG_COND_NE, QREG_CC_C, val, QREG_CC_X);

This is

   tcg_gen_shri_i32(QREG_CC_C, val, 8);
   tcg_gen_andi_i32(QREG_CC_C, QREG_CC_C, 1);

Otherwise,

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~

  reply	other threads:[~2016-11-08 10:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-07 17:59 [Qemu-devel] [PATCH v3 0/2] target-m68k: add movem, BCD and CAS instructions Laurent Vivier
2016-11-07 17:59 ` [Qemu-devel] [PATCH v3 1/2] target-m68k: add abcd/sbcd/nbcd Laurent Vivier
2016-11-08 10:11   ` Richard Henderson [this message]
2016-11-08 10:21     ` Laurent Vivier
2016-11-07 17:59 ` [Qemu-devel] [PATCH v3 2/2] target-m68k: add cas/cas2 ops Laurent Vivier
2016-11-08 10:26   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab2a2bd7-a73b-407f-ea78-3c97b76029c9@twiddle.net \
    --to=rth@twiddle.net \
    --cc=agraf@suse.de \
    --cc=gerg@uclinux.org \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).