From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48E64C3064D for ; Fri, 28 Jun 2024 08:04:38 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sN6a3-0006A0-JI; Fri, 28 Jun 2024 04:03:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sN6a1-000690-D1 for qemu-devel@nongnu.org; Fri, 28 Jun 2024 04:03:37 -0400 Received: from mail.ozlabs.org ([2404:9400:2221:ea00::3]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sN6Zy-0005tB-Vc for qemu-devel@nongnu.org; Fri, 28 Jun 2024 04:03:37 -0400 Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4W9ScP07t9z4wb7; Fri, 28 Jun 2024 18:03:33 +1000 (AEST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4W9ScM705Dz4w2Q; Fri, 28 Jun 2024 18:03:31 +1000 (AEST) Message-ID: Date: Fri, 28 Jun 2024 10:03:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v42 70/98] hw/sd/sdcard: Add sd_acmd_SEND_NUM_WR_BLOCKS handler (ACMD22) To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org References: <20240628070216.92609-1-philmd@linaro.org> <20240628070216.92609-71-philmd@linaro.org> Content-Language: en-US, fr From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= In-Reply-To: <20240628070216.92609-71-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2404:9400:2221:ea00::3; envelope-from=SRS0=GU6n=N6=kaod.org=clg@ozlabs.org; helo=mail.ozlabs.org X-Spam_score_int: -39 X-Spam_score: -4.0 X-Spam_bar: ---- X-Spam_report: (-4.0 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. > --- > hw/sd/sd.c | 23 ++++++++++------------- > 1 file changed, 10 insertions(+), 13 deletions(-) > > diff --git a/hw/sd/sd.c b/hw/sd/sd.c > index 5323a42df2..9d66c3715a 100644 > --- a/hw/sd/sd.c > +++ b/hw/sd/sd.c > @@ -263,7 +263,7 @@ static const char *sd_acmd_name(SDState *sd, uint8_t cmd) > [14] = "DPS_spec", [15] = "DPS_spec", > [16] = "DPS_spec", > [18] = "SECU_spec", > - [22] = "SEND_NUM_WR_BLOCKS", [23] = "SET_WR_BLK_ERASE_COUNT", > + [23] = "SET_WR_BLK_ERASE_COUNT", > [42] = "SET_CLR_CARD_DETECT", > [51] = "SEND_SCR", > [52] = "SECU_spec", [53] = "SECU_spec", > @@ -1689,6 +1689,13 @@ static sd_rsp_type_t sd_acmd_SD_STATUS(SDState *sd, SDRequest req) > sd->sd_status, sizeof(sd->sd_status)); > } > > +/* ACMD22 */ > +static sd_rsp_type_t sd_acmd_SEND_NUM_WR_BLOCKS(SDState *sd, SDRequest req) > +{ > + return sd_cmd_to_sendingdata(sd, req, 0, > + &sd->blk_written, sizeof(sd->blk_written)); > +} > + > static sd_rsp_type_t sd_normal_command(SDState *sd, SDRequest req) > { > uint64_t addr; > @@ -1797,18 +1804,6 @@ static sd_rsp_type_t sd_app_command(SDState *sd, > } > > switch (req.cmd) { > - case 22: /* ACMD22: SEND_NUM_WR_BLOCKS */ > - switch (sd->state) { > - case sd_transfer_state: > - return sd_cmd_to_sendingdata(sd, req, 0, > - &sd->blk_written, > - sizeof(sd->blk_written)); > - > - default: > - break; > - } > - break; > - > case 23: /* ACMD23: SET_WR_BLK_ERASE_COUNT */ > switch (sd->state) { > case sd_transfer_state: > @@ -2324,6 +2319,7 @@ static const SDProto sd_proto_spi = { > }, > .acmd = { > [13] = {8, sd_spi, "SD_STATUS", sd_acmd_SD_STATUS}, > + [22] = {8, sd_spi, "SEND_NUM_WR_BLOCKS", sd_acmd_SEND_NUM_WR_BLOCKS}, > [41] = {8, sd_spi, "SEND_OP_COND", spi_cmd_SEND_OP_COND}, > }, > }; > @@ -2382,6 +2378,7 @@ static const SDProto sd_proto_sd = { > .acmd = { > [6] = {8, sd_ac, "SET_BUS_WIDTH", sd_acmd_SET_BUS_WIDTH}, > [13] = {8, sd_adtc, "SD_STATUS", sd_acmd_SD_STATUS}, > + [22] = {8, sd_adtc, "SEND_NUM_WR_BLOCKS", sd_acmd_SEND_NUM_WR_BLOCKS}, > }, > }; >