From: Richard Henderson <richard.henderson@linaro.org>
To: Roman Kiryanov <rkir@google.com>
Cc: qemu-devel@nongnu.org, jansene@google.com,
JP Cottin <jpcottin@google.com>
Subject: Re: [PATCH] Make TARGET_PAGE_MASK typed as target_ulong
Date: Sun, 16 Jun 2024 11:10:31 -0700 [thread overview]
Message-ID: <ab2e2fe4-7ef3-49ef-a70d-df3595661837@linaro.org> (raw)
In-Reply-To: <CAOGAQeoSnVpy6Xhxb+pmHwwfjYsEqC8d-QhSt=Y_c7wsZMSN4w@mail.gmail.com>
On 6/16/24 10:40, Roman Kiryanov wrote:
> Hi Richard,
>
> thank you for looking into this.
>
>> No, this will cause failures, because we need this value to sign-extend to when the
>> context includes {u}int64_t, and target_ulong is uint32_t.
>
> I did not expect this, good catch. I see QEMU uses size_t as the
> return type in qemu_target_page_size which returns TARGET_PAGE_SIZE.
> Maybe use size_t for TARGET_PAGE_MASK everywhere (including
> qemu_target_page_mask) as well?
No, because size_t != uint64_t.
We still support 32-bit hosts.
r~
prev parent reply other threads:[~2024-06-16 18:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 19:29 [PATCH] Make TARGET_PAGE_MASK typed as target_ulong Roman Kiryanov
2024-06-15 23:59 ` Richard Henderson
2024-06-16 17:40 ` Roman Kiryanov
2024-06-16 18:10 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab2e2fe4-7ef3-49ef-a70d-df3595661837@linaro.org \
--to=richard.henderson@linaro.org \
--cc=jansene@google.com \
--cc=jpcottin@google.com \
--cc=qemu-devel@nongnu.org \
--cc=rkir@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).