From: Claudio Imbrenda <imbrenda@linux.vnet.ibm.com>
To: David Hildenbrand <dahi@daveh.de>, Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v1 2/2] gdbstub: Fix vCont behaviour
Date: Wed, 12 Oct 2016 15:55:18 +0200 [thread overview]
Message-ID: <ab3e7339-f989-9b93-ff46-f541ba41a25a@linux.vnet.ibm.com> (raw)
In-Reply-To: <20161012131525.GA9564@localhost>
On 12/10/16 15:15, David Hildenbrand wrote:
>>> + for (cx = 0; ccpus && ccpus[cx]; cx++) {
>>> + cpu_single_step(cpu, 0);
>
> This looks suspicious
why? we set all cpus to single step, since that is the default, and then
we clear the single-step property from all CPUs that should be restarted
in normal mode, then we restart all CPUs. Those in single-step will
indeed only perform one single step, the others will run freely (at
least until the first single-step CPU stops again).
>>> + }
>>> + CPU_FOREACH(cpu) {
>>> + cpu_resume(cpu);
>>> + }
>
> Claudio, did you have a look at how s->c_cpu is used later on? I remember that we
> have to take care of some query reply packages.
yes, that's set by the H packet and used by the c,s,m,etc packets. vCont
ignores it and doesn't change it
(see here https://sourceware.org/gdb/onlinedocs/gdb/Packets.html )
next prev parent reply other threads:[~2016-10-12 13:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 11:50 [Qemu-devel] [PATCH v1 0/2] Qemu: gdbstub: fix vCont and single-step Claudio Imbrenda
2016-10-10 11:50 ` [Qemu-devel] [PATCH v1 1/2] gdbstub: Fix single-step Claudio Imbrenda
2016-10-10 12:51 ` Christian Borntraeger
2016-10-10 14:36 ` Paolo Bonzini
2016-10-10 15:46 ` [Qemu-devel] [PATCH] kvm-all: don't use stale dbg_data->cpu Alex Bennée
2016-10-10 16:39 ` Paolo Bonzini
2016-10-10 17:18 ` Christian Borntraeger
2016-10-11 11:48 ` Claudio Imbrenda
2016-10-10 11:50 ` [Qemu-devel] [PATCH v1 2/2] gdbstub: Fix vCont behaviour Claudio Imbrenda
2016-10-11 8:18 ` Paolo Bonzini
2016-10-12 13:15 ` David Hildenbrand
2016-10-12 13:55 ` Claudio Imbrenda [this message]
2016-10-12 16:48 ` Paolo Bonzini
2016-10-12 18:38 ` David Hildenbrand
2016-10-13 7:49 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab3e7339-f989-9b93-ff46-f541ba41a25a@linux.vnet.ibm.com \
--to=imbrenda@linux.vnet.ibm.com \
--cc=dahi@daveh.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).