From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58863) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buK0H-0004UE-AB for qemu-devel@nongnu.org; Wed, 12 Oct 2016 09:55:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buK0D-0000QQ-5q for qemu-devel@nongnu.org; Wed, 12 Oct 2016 09:55:28 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:59312) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buK0C-0000Po-Up for qemu-devel@nongnu.org; Wed, 12 Oct 2016 09:55:25 -0400 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9CDsriO070167 for ; Wed, 12 Oct 2016 09:55:23 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 261p6u0u76-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 12 Oct 2016 09:55:23 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 12 Oct 2016 14:55:20 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id DFC7817D8063 for ; Wed, 12 Oct 2016 14:57:26 +0100 (BST) Received: from d06av09.portsmouth.uk.ibm.com (d06av09.portsmouth.uk.ibm.com [9.149.37.250]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u9CDtIRq25296968 for ; Wed, 12 Oct 2016 13:55:18 GMT Received: from d06av09.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u9CDtIIe031370 for ; Wed, 12 Oct 2016 07:55:18 -0600 References: <1476100224-19760-1-git-send-email-imbrenda@linux.vnet.ibm.com> <1476100224-19760-3-git-send-email-imbrenda@linux.vnet.ibm.com> <20161012131525.GA9564@localhost> From: Claudio Imbrenda Date: Wed, 12 Oct 2016 15:55:18 +0200 MIME-Version: 1.0 In-Reply-To: <20161012131525.GA9564@localhost> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Message-Id: Subject: Re: [Qemu-devel] [PATCH v1 2/2] gdbstub: Fix vCont behaviour List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand , Paolo Bonzini Cc: qemu-devel@nongnu.org On 12/10/16 15:15, David Hildenbrand wrote: >>> + for (cx = 0; ccpus && ccpus[cx]; cx++) { >>> + cpu_single_step(cpu, 0); > > This looks suspicious why? we set all cpus to single step, since that is the default, and then we clear the single-step property from all CPUs that should be restarted in normal mode, then we restart all CPUs. Those in single-step will indeed only perform one single step, the others will run freely (at least until the first single-step CPU stops again). >>> + } >>> + CPU_FOREACH(cpu) { >>> + cpu_resume(cpu); >>> + } > > Claudio, did you have a look at how s->c_cpu is used later on? I remember that we > have to take care of some query reply packages. yes, that's set by the H packet and used by the c,s,m,etc packets. vCont ignores it and doesn't change it (see here https://sourceware.org/gdb/onlinedocs/gdb/Packets.html )