From: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org,
Eduardo Habkost <ehabkost@redhat.com>,
Marcel Apfelbaum <marcel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 57/67] kvm: use include "kvm_i386.h" consistently
Date: Fri, 4 May 2018 08:40:55 +0300 [thread overview]
Message-ID: <ab437005-0e09-c5fb-c482-72bafda7a508@gmail.com> (raw)
In-Reply-To: <1525376963-79623-58-git-send-email-mst@redhat.com>
On 05/03/2018 10:51 PM, Michael S. Tsirkin wrote:
> Some places include kvm_i386.h, others target/i386/kvm_i386.h.
> Let's be consistent.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/i386/kvm/apic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/kvm/apic.c b/hw/i386/kvm/apic.c
> index 1df6d26..ce43c3c 100644
> --- a/hw/i386/kvm/apic.c
> +++ b/hw/i386/kvm/apic.c
> @@ -16,7 +16,7 @@
> #include "hw/pci/msi.h"
> #include "sysemu/hw_accel.h"
> #include "sysemu/kvm.h"
> -#include "target/i386/kvm_i386.h"
> +#include "kvm_i386.h"
>
> static inline void kvm_apic_set_reg(struct kvm_lapic_state *kapic,
> int reg_id, uint32_t val)
Reviewed-by: Marcel Apfelbaum<marcel.apfelbaum@gmail.com>
Thanks,
Marcel
next prev parent reply other threads:[~2018-05-04 5:41 UTC|newest]
Thread overview: 140+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
2018-05-03 19:50 ` [Qemu-devel] [PATCH 01/67] block: use local path for local headers Michael S. Tsirkin
2018-05-04 9:32 ` Daniel P. Berrangé
2018-05-03 19:50 ` [Qemu-devel] [PATCH 02/67] crypto: " Michael S. Tsirkin
2018-05-03 19:50 ` [Qemu-devel] [PATCH 03/67] hppa: " Michael S. Tsirkin
2018-05-04 16:29 ` Philippe Mathieu-Daudé
2018-05-03 19:50 ` [Qemu-devel] [PATCH 04/67] s390x: drop an unused include Michael S. Tsirkin
2018-05-04 0:24 ` Thomas Huth
2018-05-08 13:23 ` Cornelia Huck
2018-05-08 13:38 ` Thomas Huth
2018-05-08 13:45 ` Cornelia Huck
2018-05-08 13:50 ` Thomas Huth
2018-05-08 14:06 ` Philippe Mathieu-Daudé
2018-05-08 14:17 ` Thomas Huth
2018-05-03 19:50 ` [Qemu-devel] [PATCH 05/67] migration: drop an unused include, add a used one Michael S. Tsirkin
2018-05-03 20:02 ` Eric Blake
2018-05-03 20:15 ` Michael S. Tsirkin
2018-05-03 20:18 ` Eric Blake
2018-05-03 20:29 ` Michael S. Tsirkin
2018-05-03 20:45 ` Eric Blake
2018-05-03 19:50 ` [Qemu-devel] [PATCH 06/67] trace: use local path for local headers Michael S. Tsirkin
2018-05-04 8:10 ` Stefan Hajnoczi
2018-05-04 16:31 ` Philippe Mathieu-Daudé
2018-05-03 19:50 ` [Qemu-devel] [PATCH 07/67] display: " Michael S. Tsirkin
2018-05-04 16:33 ` Philippe Mathieu-Daudé
2018-05-03 19:50 ` [Qemu-devel] [PATCH 08/67] ide: " Michael S. Tsirkin
2018-05-03 19:50 ` [Qemu-devel] [PATCH 09/67] ioapic: fix up includes Michael S. Tsirkin
2018-05-03 19:50 ` [Qemu-devel] [PATCH 10/67] e1000e: use local path for local headers Michael S. Tsirkin
2018-05-03 19:50 ` [Qemu-devel] [PATCH 11/67] rocker: drop an unused include Michael S. Tsirkin
2018-05-08 12:58 ` Philippe Mathieu-Daudé
2018-05-03 19:50 ` [Qemu-devel] [PATCH 12/67] ppc: use local path for local headers Michael S. Tsirkin
2018-05-03 23:34 ` David Gibson
2018-05-03 19:50 ` [Qemu-devel] [PATCH 13/67] vhost-scsi: drop an unused include Michael S. Tsirkin
2018-05-08 12:59 ` Philippe Mathieu-Daudé
2018-05-03 19:50 ` [Qemu-devel] [PATCH 14/67] sd: fix up include Michael S. Tsirkin
2018-05-04 16:35 ` Philippe Mathieu-Daudé
2018-05-03 19:50 ` [Qemu-devel] [PATCH 15/67] usb: use local path for local headers Michael S. Tsirkin
2018-05-03 19:50 ` [Qemu-devel] [PATCH 16/67] migration: " Michael S. Tsirkin
2018-05-08 12:21 ` Juan Quintela
2018-05-08 13:12 ` Eric Blake
2018-05-08 14:28 ` Juan Quintela
2018-05-08 14:54 ` Eric Blake
2018-05-03 19:50 ` [Qemu-devel] [PATCH 17/67] colo: " Michael S. Tsirkin
2018-05-04 4:23 ` Zhang Chen
2018-05-03 19:50 ` [Qemu-devel] [PATCH 18/67] qga: " Michael S. Tsirkin
2018-05-08 12:45 ` Philippe Mathieu-Daudé
2018-05-03 19:50 ` [Qemu-devel] [PATCH 20/67] tests: relative include for child directory Michael S. Tsirkin
2018-05-08 12:22 ` Juan Quintela
2018-05-03 19:50 ` [Qemu-devel] [PATCH 19/67] xtensa: relative include for parent directory Michael S. Tsirkin
2018-05-03 19:50 ` [Qemu-devel] [PATCH 21/67] trace: use local path for local headers Michael S. Tsirkin
2018-05-04 8:09 ` Stefan Hajnoczi
2018-05-04 16:36 ` Philippe Mathieu-Daudé
2018-05-03 19:51 ` [Qemu-devel] [PATCH 22/67] ui: " Michael S. Tsirkin
2018-05-08 12:47 ` Philippe Mathieu-Daudé
2018-05-03 19:51 ` [Qemu-devel] [PATCH 23/67] slirp: add include directory headers Michael S. Tsirkin
2018-05-31 18:50 ` Samuel Thibault
2018-05-31 19:25 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 25/67] arch_init: sort architectures Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 24/67] net: add include directory headers Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 26/67] cpu: replace command line flags with preprocessor Michael S. Tsirkin
2018-05-03 20:08 ` Eric Blake
2018-05-04 0:35 ` Thomas Huth
2018-05-04 1:01 ` Michael S. Tsirkin
2018-05-04 1:11 ` Thomas Huth
2018-05-03 19:51 ` [Qemu-devel] [PATCH 27/67] replication: add include directory header Michael S. Tsirkin
2018-05-04 9:29 ` Daniel P. Berrangé
2018-05-04 14:52 ` Michael S. Tsirkin
2018-05-04 15:04 ` Daniel P. Berrangé
2018-05-03 19:51 ` [Qemu-devel] [PATCH 29/67] fsdev: add include directory headers Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 28/67] 9pfs: " Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 31/67] target/cris: add include directory header Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 30/67] audio: " Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 32/67] ui: " Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 33/67] hw/net: " Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 34/67] hw/ppc: add include directory headers Michael S. Tsirkin
2018-05-04 0:15 ` David Gibson
2018-05-04 2:39 ` Michael S. Tsirkin
2018-05-04 3:07 ` David Gibson
2018-05-03 19:51 ` [Qemu-devel] [PATCH 35/67] hw/usb: add include directory header Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 36/67] migration: add include directory headers Michael S. Tsirkin
2018-05-08 12:25 ` Juan Quintela
2018-05-08 12:56 ` Philippe Mathieu-Daudé
2018-05-11 17:23 ` Michael S. Tsirkin
2018-05-11 17:26 ` Daniel P. Berrangé
2018-05-03 19:51 ` [Qemu-devel] [PATCH 38/67] helper: replace command line flags with preprocessor Michael S. Tsirkin
2018-05-03 20:09 ` Eric Blake
2018-05-03 19:51 ` [Qemu-devel] [PATCH 37/67] tcg: add include directory headers Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 39/67] target: replace command line flags with preprocessor Michael S. Tsirkin
2018-05-03 20:11 ` Eric Blake
2018-05-03 20:15 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 40/67] trace: add include directory headers Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 41/67] tcg-pool.inc.c: replace command line flags with preprocessor Michael S. Tsirkin
2018-05-03 20:12 ` Eric Blake
2018-05-03 20:16 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 42/67] tcg: use include "tcg.h" consistently Michael S. Tsirkin
2018-05-04 5:40 ` Marcel Apfelbaum
2018-05-03 19:51 ` [Qemu-devel] [PATCH 43/67] translate-all: add include directory header Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 45/67] tcg: add include directory headers Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 44/67] tcg-ldst.inc.c: replace command line flags with preprocessor Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 46/67] cpu-qom: add include directory headers Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 47/67] tcg-op: use include "tcg.h" consistently Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 48/67] virtio-pci: add include directory header Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 50/67] hmp: " Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 49/67] kvm_XXX: add include directory headers Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 51/67] hyperv: add include directory header Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 52/67] target/arm: add include directory headers Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 53/67] target/ppc: " Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 54/67] amd_iommu: add include directory header Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 55/67] " Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 56/67] tcg: use include "tcg-gvec-desc.h.h" consistently Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 57/67] kvm: use include "kvm_i386.h" consistently Michael S. Tsirkin
2018-05-04 5:40 ` Marcel Apfelbaum [this message]
2018-05-03 19:51 ` [Qemu-devel] [PATCH 58/67] target/riscv: add include directory header Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 59/67] hw/ppc: add target headers explicitly Michael S. Tsirkin
2018-05-03 23:36 ` David Gibson
2018-05-03 19:51 ` [Qemu-devel] [PATCH 60/67] hw/s390x: add include directory headers Michael S. Tsirkin
2018-05-04 7:10 ` Cornelia Huck
2018-05-04 13:07 ` [Qemu-devel] cover letter cc's [was: [PATCH 60/67] hw/s390x: add include directory headers] Eric Blake
2018-05-04 13:26 ` Cornelia Huck
2018-05-04 13:32 ` Peter Maydell
2018-05-04 21:38 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 61/67] hw/net: add include directory header Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 62/67] kvm: use include "kvm_ppc.h" consistently Michael S. Tsirkin
2018-05-04 0:17 ` David Gibson
2018-05-04 2:44 ` Michael S. Tsirkin
2018-05-04 3:15 ` David Gibson
2018-05-03 19:51 ` [Qemu-devel] [PATCH 63/67] hw/s390x: use target headers explicitly Michael S. Tsirkin
2018-05-08 13:48 ` Cornelia Huck
2018-05-03 19:51 ` [Qemu-devel] [PATCH 64/67] target/s390x: add include directory header Michael S. Tsirkin
2018-05-08 13:50 ` Cornelia Huck
2018-05-03 19:51 ` [Qemu-devel] [PATCH 65/67] tcg: use include "translate-all.h" consistently Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 66/67] linux-user: add include directory header Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 67/67] make: simplify source include path Michael S. Tsirkin
2018-05-03 20:22 ` Eric Blake
2018-05-03 20:31 ` Michael S. Tsirkin
2018-05-03 20:58 ` [Qemu-devel] [PATCH 00/67] include path cleanup no-reply
2018-05-03 20:58 ` no-reply
2018-05-03 21:00 ` no-reply
2018-05-03 21:01 ` no-reply
2018-05-09 10:39 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab437005-0e09-c5fb-c482-72bafda7a508@gmail.com \
--to=marcel.apfelbaum@gmail.com \
--cc=ehabkost@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).