* [PATCH] hw/block/tc58128: Don't emit deprecation warning under qtest
@ 2024-02-06 15:41 Peter Maydell
2024-02-06 15:51 ` Philippe Mathieu-Daudé
2024-02-13 6:55 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Peter Maydell @ 2024-02-06 15:41 UTC (permalink / raw)
To: qemu-devel
Suppress the deprecation warning when we're running under qtest,
to avoid "make check" including warning messages in its output.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/block/tc58128.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/block/tc58128.c b/hw/block/tc58128.c
index 6944cf58fa4..0984e37417b 100644
--- a/hw/block/tc58128.c
+++ b/hw/block/tc58128.c
@@ -202,7 +202,9 @@ static sh7750_io_device tc58128 = {
int tc58128_init(struct SH7750State *s, const char *zone1, const char *zone2)
{
- warn_report_once("The TC58128 flash device is deprecated");
+ if (!qtest_enabled()) {
+ warn_report_once("The TC58128 flash device is deprecated");
+ }
init_dev(&tc58128_devs[0], zone1);
init_dev(&tc58128_devs[1], zone2);
return sh7750_register_io_device(s, &tc58128);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/block/tc58128: Don't emit deprecation warning under qtest
2024-02-06 15:41 [PATCH] hw/block/tc58128: Don't emit deprecation warning under qtest Peter Maydell
@ 2024-02-06 15:51 ` Philippe Mathieu-Daudé
2024-02-13 6:55 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-02-06 15:51 UTC (permalink / raw)
To: Peter Maydell, qemu-devel
On 6/2/24 16:41, Peter Maydell wrote:
> Suppress the deprecation warning when we're running under qtest,
> to avoid "make check" including warning messages in its output.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/block/tc58128.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/block/tc58128: Don't emit deprecation warning under qtest
2024-02-06 15:41 [PATCH] hw/block/tc58128: Don't emit deprecation warning under qtest Peter Maydell
2024-02-06 15:51 ` Philippe Mathieu-Daudé
@ 2024-02-13 6:55 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-02-13 6:55 UTC (permalink / raw)
To: Peter Maydell, qemu-devel
On 6/2/24 16:41, Peter Maydell wrote:
> Suppress the deprecation warning when we're running under qtest,
> to avoid "make check" including warning messages in its output.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/block/tc58128.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Patched queued, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-13 6:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-06 15:41 [PATCH] hw/block/tc58128: Don't emit deprecation warning under qtest Peter Maydell
2024-02-06 15:51 ` Philippe Mathieu-Daudé
2024-02-13 6:55 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).