Re: [PATCH v2 04/11] q800: implement compat_props to enable quirk_mode_page_apple_vendor for scsi-hd devices

[Laurent Vivier <laurent@vivier.eu>]

Le 24/04/2022 à 18:49, Mark Cave-Ayland a écrit :
> By default quirk_mode_page_apple_vendor should be enabled for all scsi-hd devices
> connected to the q800 machine to enable MacOS to detect and use them.
> 
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
>   hw/m68k/q800.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/hw/m68k/q800.c b/hw/m68k/q800.c
> index 099a758c6f..42bf7bb4f0 100644
> --- a/hw/m68k/q800.c
> +++ b/hw/m68k/q800.c
> @@ -686,6 +686,11 @@ static void q800_init(MachineState *machine)
>       }
>   }
>   
> +static GlobalProperty hw_compat_q800[] = {
> +    { "scsi-hd", "quirk_mode_page_apple_vendor", "on"},
> +};
> +static const size_t hw_compat_q800_len = G_N_ELEMENTS(hw_compat_q800);
> +
>   static void q800_machine_class_init(ObjectClass *oc, void *data)
>   {
>       MachineClass *mc = MACHINE_CLASS(oc);
> @@ -695,6 +700,7 @@ static void q800_machine_class_init(ObjectClass *oc, void *data)
>       mc->max_cpus = 1;
>       mc->block_default_type = IF_SCSI;
>       mc->default_ram_id = "m68k_mac.ram";
> +    compat_props_add(mc->compat_props, hw_compat_q800, hw_compat_q800_len);
>   }
>   
>   static const TypeInfo q800_machine_typeinfo = {

Reviewed-by: Laurent Vivier <laurent@vivier.eu>