* target/mips: Fix MIPS16e translation
@ 2025-04-12 19:40 Hauke Mehrtens
2025-04-14 10:23 ` Philippe Mathieu-Daudé
2025-04-25 10:44 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Hauke Mehrtens @ 2025-04-12 19:40 UTC (permalink / raw)
To: qemu-devel
Cc: arikalo, jiaxun.yang, aurelien, philmd, Hauke Mehrtens,
qemu-stable
Fix a wrong conversion to gen_op_addr_addi(). The framesize should be
added like it was done before.
This bug broke booting OpenWrt MIPS32 BE malta Linux system images
generated by OpenWrt.
Fixes: d0b24b7f50e1 ("target/mips: Use gen_op_addr_addi() when possible")
Cc: qemu-stable@nongnu.org
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
target/mips/tcg/mips16e_translate.c.inc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/mips/tcg/mips16e_translate.c.inc b/target/mips/tcg/mips16e_translate.c.inc
index a9af8f1e74..97da3456ea 100644
--- a/target/mips/tcg/mips16e_translate.c.inc
+++ b/target/mips/tcg/mips16e_translate.c.inc
@@ -306,7 +306,7 @@ static void gen_mips16_restore(DisasContext *ctx,
int astatic;
TCGv t0 = tcg_temp_new();
- gen_op_addr_addi(ctx, t0, cpu_gpr[29], -framesize);
+ gen_op_addr_addi(ctx, t0, cpu_gpr[29], framesize);
if (do_ra) {
decr_and_load(ctx, 31, t0);
@@ -386,7 +386,7 @@ static void gen_mips16_restore(DisasContext *ctx,
}
}
- gen_op_addr_addi(ctx, cpu_gpr[29], cpu_gpr[29], -framesize);
+ gen_op_addr_addi(ctx, cpu_gpr[29], cpu_gpr[29], framesize);
}
#if defined(TARGET_MIPS64)
--
2.49.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: target/mips: Fix MIPS16e translation
2025-04-12 19:40 target/mips: Fix MIPS16e translation Hauke Mehrtens
@ 2025-04-14 10:23 ` Philippe Mathieu-Daudé
2025-04-25 10:44 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-04-14 10:23 UTC (permalink / raw)
To: Hauke Mehrtens, qemu-devel; +Cc: arikalo, jiaxun.yang, aurelien, qemu-stable
On 12/4/25 21:40, Hauke Mehrtens wrote:
> Fix a wrong conversion to gen_op_addr_addi(). The framesize should be
> added like it was done before.
>
> This bug broke booting OpenWrt MIPS32 BE malta Linux system images
> generated by OpenWrt.
>
> Fixes: d0b24b7f50e1 ("target/mips: Use gen_op_addr_addi() when possible")
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
> target/mips/tcg/mips16e_translate.c.inc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Oops...
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: target/mips: Fix MIPS16e translation
2025-04-12 19:40 target/mips: Fix MIPS16e translation Hauke Mehrtens
2025-04-14 10:23 ` Philippe Mathieu-Daudé
@ 2025-04-25 10:44 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-04-25 10:44 UTC (permalink / raw)
To: Hauke Mehrtens, qemu-devel; +Cc: arikalo, jiaxun.yang, aurelien, qemu-stable
On 12/4/25 21:40, Hauke Mehrtens wrote:
> Fix a wrong conversion to gen_op_addr_addi(). The framesize should be
> added like it was done before.
>
> This bug broke booting OpenWrt MIPS32 BE malta Linux system images
> generated by OpenWrt.
>
> Fixes: d0b24b7f50e1 ("target/mips: Use gen_op_addr_addi() when possible")
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
> target/mips/tcg/mips16e_translate.c.inc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Patch queued, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-25 10:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-12 19:40 target/mips: Fix MIPS16e translation Hauke Mehrtens
2025-04-14 10:23 ` Philippe Mathieu-Daudé
2025-04-25 10:44 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).