qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Eric Auger <eric.auger@redhat.com>,
	eric.auger.pro@gmail.com, pbonzini@redhat.com,
	lvivier@redhat.com, qemu-arm@nongnu.org, qemu-devel@nongnu.org,
	jean-philippe@linaro.org
Subject: Re: [PATCH v5] tests: qtest: Add virtio-iommu test
Date: Tue, 2 Nov 2021 14:34:46 +0100	[thread overview]
Message-ID: <ab71888b-fd72-4b08-0d36-4add85ba6278@redhat.com> (raw)
In-Reply-To: <20211101184858.15223-1-eric.auger@redhat.com>

On 01/11/2021 19.48, Eric Auger wrote:
> Add the framework to test the virtio-iommu-pci device
> and tests exercising the attach/detach, map/unmap API.
> 
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> Tested-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> 
> ---
> 
> v4 -> v5:
> - remove printf and move a comment
> - Added Jean-Philippe's T-b and R-b
> ---
>   tests/qtest/libqos/meson.build    |   1 +
>   tests/qtest/libqos/virtio-iommu.c | 126 ++++++++++++
>   tests/qtest/libqos/virtio-iommu.h |  40 ++++
>   tests/qtest/meson.build           |   1 +
>   tests/qtest/virtio-iommu-test.c   | 326 ++++++++++++++++++++++++++++++
>   5 files changed, 494 insertions(+)
>   create mode 100644 tests/qtest/libqos/virtio-iommu.c
>   create mode 100644 tests/qtest/libqos/virtio-iommu.h
>   create mode 100644 tests/qtest/virtio-iommu-test.c

There's another failure on Travis-CI:

  https://app.travis-ci.com/github/huth/qemu/jobs/546268575#L7240

  ERROR:../tests/qtest/virtio-iommu-test.c:38:pci_config:
  assertion failed (domain_range_end == 32): (536870912 == 32)

536870912 is 0x20000000, so this is likely an endianess issue?

  Thomas



  parent reply	other threads:[~2021-11-02 13:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-01 18:48 [PATCH v5] tests: qtest: Add virtio-iommu test Eric Auger
2021-11-02 12:58 ` Thomas Huth
2021-11-04 17:36   ` Eric Auger
2021-11-02 13:34 ` Thomas Huth [this message]
2021-11-04 17:40   ` Eric Auger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab71888b-fd72-4b08-0d36-4add85ba6278@redhat.com \
    --to=thuth@redhat.com \
    --cc=eric.auger.pro@gmail.com \
    --cc=eric.auger@redhat.com \
    --cc=jean-philippe@linaro.org \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).