From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E05AC433F5 for ; Mon, 18 Oct 2021 09:33:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3FDED61027 for ; Mon, 18 Oct 2021 09:33:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3FDED61027 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:40002 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcP1h-0004TH-5f for qemu-devel@archiver.kernel.org; Mon, 18 Oct 2021 05:33:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48280) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcOzl-0002RM-8U for qemu-devel@nongnu.org; Mon, 18 Oct 2021 05:31:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:50430) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcOzi-0002E4-S9 for qemu-devel@nongnu.org; Mon, 18 Oct 2021 05:31:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634549506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GFp8z2+3qQ/fZHLQdSG5ejdRjo57+r6l289Jf1cbwig=; b=eRa+p9UZqzb/V3/NEmS1wo6h/moII7vohM7/F6ykvA2w8/tPKc02+a7I/ZM/SmhAc54uxq yya33Ju2I9Mu38P1pqmP8cnanZtlZ1ACdF7nvJj9GXVhnvycfbE8lL7NfA3UUO8WHyW2dv yPgxS2eRD4gHM8LFB7bcxMD67zZOvUg= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-278-4cJp5s4WNF6YJjwQPHEaZg-1; Mon, 18 Oct 2021 05:31:45 -0400 X-MC-Unique: 4cJp5s4WNF6YJjwQPHEaZg-1 Received: by mail-wr1-f70.google.com with SMTP id 75-20020adf82d1000000b00160cbb0f800so8606657wrc.22 for ; Mon, 18 Oct 2021 02:31:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=GFp8z2+3qQ/fZHLQdSG5ejdRjo57+r6l289Jf1cbwig=; b=jFNO4lvMyWdwtu0wHzuxOdRSzfT/nv6WyThDgyaDciy+Le6eP08wbb/BKCmVLNZCnx faHbjlzRXdMKcPC88f7Cek5yYub0YFIhenG+Eo002Fmc6SVHIXTnpB45a+4RNDsIejs8 Av/KiZyIFsQTMZtpaXXg/o6umKWOtla/f3j9dUw+mQIwIDMMuo/ENcXMyIEP4CSS5M0C bW1nYZmWktNr1JfLU10OoAheLCPzU/SnZhr1aUdp1wdOI0h0N+jWZAMMT2qRSEa3vyyd N0oBd2wJab8avwOP5dBBLyf3TsEjneXHyeYM08W3XvKF1+v0k9Rk6uaFhH2m/s/0HxGs falA== X-Gm-Message-State: AOAM530qhvxbEASwvA3d2XUtXRI1yYMG45CffePy7KjwN1X1aW85MFqU DOzWrpTJMJnm+pFjEHc+xV4LB7zTb3hS1cpegaVgTlQn8k71Dl3dpBwVmxMyr5Ralk/EKdfQ5xo VKT+gGYKwBaTIcKERyOXoRj5+l9yTe77eriRIPSJ780PcoTClnt22+UvSyy8moWCq X-Received: by 2002:a05:600c:4e91:: with SMTP id f17mr29288866wmq.180.1634549503494; Mon, 18 Oct 2021 02:31:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwvFULAOAfxPBHQK5c/jUVZXU2BH7TtkOgNm9qKDOu72DJaD+qNs1zc/oOkHT3vK5jgK571Qg== X-Received: by 2002:a05:600c:4e91:: with SMTP id f17mr29288848wmq.180.1634549503261; Mon, 18 Oct 2021 02:31:43 -0700 (PDT) Received: from [192.168.1.36] (213.red-81-36-146.dynamicip.rima-tde.net. [81.36.146.213]) by smtp.gmail.com with ESMTPSA id 10sm16199319wme.27.2021.10.18.02.31.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Oct 2021 02:31:42 -0700 (PDT) Message-ID: Date: Mon, 18 Oct 2021 11:31:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH 2/2] roms/edk2: Only initialize required submodules To: qemu-devel@nongnu.org References: <20211018092354.2637731-1-philmd@redhat.com> <20211018092354.2637731-3-philmd@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20211018092354.2637731-3-philmd@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.049, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Alex_Benn=c3=a9e?= , Thomas Huth , Richard Henderson , Gerd Hoffmann , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/18/21 11:23, Philippe Mathieu-Daudé wrote: > The EDK2 firmware images built to test QEMU do not require > the following submodules: > > - MdeModulePkg/Universal/RegularExpressionDxe/oniguruma > - UnitTestFrameworkPkg/Library/CmockaLib/cmocka > > The only submodules required are: > > - ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3 > - BaseTools/Source/C/BrotliCompress/brotli > - CryptoPkg/Library/OpensslLib/openssl > - MdeModulePkg/Library/BrotliCustomDecompressLib/brotli > > Adapt the buildsys machinery to only initialize the required > submodules. > > Signed-off-by: Philippe Mathieu-Daudé > --- > .gitlab-ci.d/edk2.yml | 4 ++++ > roms/Makefile.edk2 | 7 ++++++- > scripts/make-release | 7 ++++++- > 3 files changed, 16 insertions(+), 2 deletions(-) > # See notes on the ".NOTPARALLEL" target and the "+" indicator in > diff --git a/scripts/make-release b/scripts/make-release > index a2a8cda33c0..a9ff933a4ca 100755 > --- a/scripts/make-release > +++ b/scripts/make-release > @@ -27,7 +27,12 @@ git submodule update --init > # don't necessarily have much control over how a submodule handles its > # submodule dependencies, so we continue to handle these on a case-by-case > # basis for now. > -(cd roms/edk2 && git submodule update --init) > +(cd roms/edk2 && \ > + git submodule update --init \ Hmm I forgot the '--' separator here. > + ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3 \ > + BaseTools/Source/C/BrotliCompress/brotli \ > + CryptoPkg/Library/OpensslLib/openssl \ > + MdeModulePkg/Library/BrotliCustomDecompressLib/brotli) > popd > tar --exclude=.git -cjf ${destination}.tar.bz2 ${destination} > rm -rf ${destination} >