From: Max Reitz <mreitz@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
ehabkost@redhat.com, qemu-block@nongnu.org, philmd@redhat.com,
armbru@redhat.com
Subject: Re: [PATCH v8 04/11] iotests: replace mutable list default args
Date: Tue, 24 Mar 2020 15:35:00 +0100 [thread overview]
Message-ID: <ab79f328-8ba8-48a3-4e8c-3a0e01ef060f@redhat.com> (raw)
In-Reply-To: <20200317004105.27059-5-jsnow@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 523 bytes --]
On 17.03.20 01:40, John Snow wrote:
> It's bad hygiene: if we modify this list, it will be modified across all
> invocations.
>
> (Remaining bad usages are fixed in a subsequent patch which changes the
> function signature anyway.)
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> tests/qemu-iotests/iotests.py | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-03-24 14:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 0:40 [PATCH v8 00/11] iotests: use python logging John Snow
2020-03-17 0:40 ` [PATCH v8 01/11] iotests: do a light delinting John Snow
2020-03-24 13:56 ` Max Reitz
2020-03-17 0:40 ` [PATCH v8 02/11] iotests: don't use 'format' for drive_add John Snow
2020-03-17 0:40 ` [PATCH v8 03/11] iotests: ignore import warnings from pylint John Snow
2020-03-17 10:38 ` Philippe Mathieu-Daudé
2020-03-24 14:02 ` Max Reitz
2020-03-17 0:40 ` [PATCH v8 04/11] iotests: replace mutable list default args John Snow
2020-03-24 14:35 ` Max Reitz [this message]
2020-03-17 0:40 ` [PATCH v8 05/11] iotests: add pylintrc file John Snow
2020-03-24 14:47 ` Max Reitz
2020-03-17 0:41 ` [PATCH v8 06/11] iotests: drop Python 3.4 compatibility code John Snow
2020-03-24 14:54 ` Max Reitz
2020-03-24 16:57 ` John Snow
2020-03-17 0:41 ` [PATCH v8 07/11] iotests: limit line length to 79 chars John Snow
2020-03-17 10:36 ` Philippe Mathieu-Daudé
2020-03-17 13:48 ` John Snow
2020-03-24 15:02 ` Max Reitz
2020-03-24 15:12 ` Max Reitz
2020-03-24 17:09 ` John Snow
2020-03-24 17:38 ` Max Reitz
2020-03-17 0:41 ` [PATCH v8 08/11] iotests: add script_initialize John Snow
2020-03-17 0:41 ` [PATCH v8 09/11] iotest 258: use script_main John Snow
2020-03-17 0:41 ` [PATCH v8 10/11] iotests: Mark verify functions as private John Snow
2020-03-17 0:41 ` [PATCH v8 11/11] iotests: use python logging for iotests.log() John Snow
2020-03-24 16:14 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab79f328-8ba8-48a3-4e8c-3a0e01ef060f@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).