From: "Andreas Färber" <afaerber@suse.de>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/2] tests: A few check-qom-proplist fixes
Date: Tue, 18 Oct 2016 00:07:30 +0200 [thread overview]
Message-ID: <ab7c888d-3108-ff99-566b-ee8217d92ac4@suse.de> (raw)
In-Reply-To: <20161017210237.GB3275@thinpad.lan.raisama.net>
Am 17.10.2016 um 23:02 schrieb Eduardo Habkost:
> Ping?
>
> Markus, do you want to merge this through your tree?
>
> On Tue, Oct 11, 2016 at 09:37:45AM -0300, Eduardo Habkost wrote:
>> A few fixes on check-qom-proplist that will ensure we test both
>> class properties and object properties, and catch errors when
>> registering properties in test code.
>>
>> Eduardo Habkost (2):
>> tests: check-qom-proplist: Remove "bv" class property from class
This part I didn't quite understand from looking at the patch, but...
>> tests: check-qom-proplist: Use &error_abort to catch errors
For this one:
Reviewed-by: Andreas Färber <afaerber@suse.de>
Regards,
Andreas
>> tests/check-qom-proplist.c | 10 +++-------
>> 1 file changed, 3 insertions(+), 7 deletions(-)
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2016-10-17 22:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 12:37 [Qemu-devel] [PATCH 0/2] tests: A few check-qom-proplist fixes Eduardo Habkost
2016-10-11 12:37 ` [Qemu-devel] [PATCH 1/2] tests: check-qom-proplist: Remove "bv" class property from class Eduardo Habkost
2016-10-11 12:39 ` Daniel P. Berrange
2016-10-11 12:37 ` [Qemu-devel] [PATCH 2/2] tests: check-qom-proplist: Use &error_abort to catch errors Eduardo Habkost
2016-10-11 12:40 ` Daniel P. Berrange
2016-10-17 21:02 ` [Qemu-devel] [PATCH 0/2] tests: A few check-qom-proplist fixes Eduardo Habkost
2016-10-17 22:07 ` Andreas Färber [this message]
2016-10-18 13:58 ` Eduardo Habkost
2016-10-25 18:40 ` Eduardo Habkost
2016-11-03 16:51 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab7c888d-3108-ff99-566b-ee8217d92ac4@suse.de \
--to=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).