From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, imammedo@redhat.com,
alex.williamson@redhat.com, qemu-devel@nongnu.org,
armbru@redhat.com
Subject: Re: [PATCH 2/2] qom: use correct field name when getting/setting alias properties
Date: Wed, 21 Jul 2021 11:51:55 +0200 [thread overview]
Message-ID: <ab9bb88a-ccb8-6242-5960-2eb1a43f0c56@redhat.com> (raw)
In-Reply-To: <20210720010005.vegqnbb5qhfxh7ow@redhat.com>
On 20/07/21 03:00, Eric Blake wrote:
> Deceptively simple; all the work was in the previous patch writing up
> the forwarding visitor. I still wonder if Kevin's QAPI aliases will
> do this more gracefully, but if we're trying to justify this as a bug
> fix worthy of 6.1, this is certainly a smaller approach than Kevin's.
>
> Reviewed-by: Eric Blake<eblake@redhat.com>
As discussed on IRC, this is unrelated to QAPI aliases; QOM alias
properties typically target a property *on a different object*.
This is a regression, so it certainly has to be fixed in 6.1 one way or
the other.
Paolo
next prev parent reply other threads:[~2021-07-21 9:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 10:40 [PATCH 0/2] qapi/qom: use correct field name when getting/setting alias properties Paolo Bonzini
2021-07-19 10:40 ` [PATCH 1/2] qapi: introduce forwarding visitor Paolo Bonzini
2021-07-20 0:54 ` Eric Blake
2021-07-22 14:02 ` Markus Armbruster
2021-07-22 15:08 ` Paolo Bonzini
2021-07-22 15:34 ` Markus Armbruster
2021-07-23 9:49 ` Paolo Bonzini
2021-07-19 10:40 ` [PATCH 2/2] qom: use correct field name when getting/setting alias properties Paolo Bonzini
2021-07-19 11:51 ` Philippe Mathieu-Daudé
2021-07-20 1:00 ` Eric Blake
2021-07-21 9:51 ` Paolo Bonzini [this message]
2021-07-21 14:43 ` Markus Armbruster
2021-07-20 15:54 ` [PATCH 0/2] qapi/qom: " Markus Armbruster
2021-07-21 11:50 ` Paolo Bonzini
2021-07-22 13:25 ` Markus Armbruster
2021-07-22 13:36 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab9bb88a-ccb8-6242-5960-2eb1a43f0c56@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=imammedo@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).