From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41505) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1behpB-0002nj-Tv for qemu-devel@nongnu.org; Tue, 30 Aug 2016 08:07:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1behp5-0004Eg-RD for qemu-devel@nongnu.org; Tue, 30 Aug 2016 08:07:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49602) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1behp5-0004EW-Lp for qemu-devel@nongnu.org; Tue, 30 Aug 2016 08:07:23 -0400 References: <20160823094537.8782-1-marcandre.lureau@redhat.com> From: Paolo Bonzini Message-ID: Date: Tue, 30 Aug 2016 14:07:18 +0200 MIME-Version: 1.0 In-Reply-To: <20160823094537.8782-1-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-2.7 0/2] Fix net socket connect regressions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , qemu-devel@nongnu.org Cc: jasowang@redhat.com, berrange@redhat.com, ashijeetacharya@gmail.com, crobinso@redhat.com On 23/08/2016 11:45, Marc-Andr=C3=A9 Lureau wrote: > Hi, >=20 > Commit 7e8449594c929 introduced multiple regressions. The most > important is that the socket is actually not the one connected, due to > wrong usage of socket_connect(). I fixed that along with some leak > fixes, that could eventually be splitted. >=20 > Secondly, connect is no longer non-blocking. The second patch is my > attempt to fix it. >=20 > Fixes: > https://bugzilla.redhat.com/show_bug.cgi?id=3D1368447 I'll send a revert, and your patch for 2.8. Paolo