From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34549) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ez6uz-0008Ha-JD for qemu-devel@nongnu.org; Thu, 22 Mar 2018 16:34:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ez6uy-0004nV-I7 for qemu-devel@nongnu.org; Thu, 22 Mar 2018 16:34:37 -0400 References: <1521642402-197739-1-git-send-email-mst@redhat.com> <20180321153439.GC3898@localhost.localdomain> <20180321175452-mutt-send-email-mst@kernel.org> <20180321162203.GE3898@localhost.localdomain> <20180322211902-mutt-send-email-mst@kernel.org> From: Paolo Bonzini Message-ID: Date: Thu, 22 Mar 2018 21:33:29 +0100 MIME-Version: 1.0 In-Reply-To: <20180322211902-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] qemu: replace "" with <> in headers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Kevin Wolf Cc: qemu-devel@nongnu.org, "=?UTF-8?Q?Daniel_P._Berrang=c3=a9?=" , Thomas Huth , Laurent Vivier , Peter Maydell , Dmitry Fleytman , Ronnie Sahlberg , Li Zhijian , David Hildenbrand , Jeff Cody , Zhang Chen , BALATON Zoltan , Keith Busch , Max Filippov , Gerd Hoffmann , Jiri Pirko , Subbaraya Sundeep , Eric Blake , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang , Ben Warren , Marcel Apfelbaum , Yongbok Kim , Markus Armbruster , Stefan Berger , Christian Borntraeger , kvm@vger.kernel.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Shannon Zhao , Anthony Perard , Liu Yuan , David Gibson , Andrzej Zaborowski , Jason Wang , Artyom Tarasenko , Riku Voipio , Fam Zheng , Eduardo Habkost , Corey Minyard , Amit Shah , Pavel Dovgalyuk , Stefan Weil , Xie Changlong , Alistair Francis , Peter Lieven , "Dr. David Alan Gilbert" , Greg Kurz , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Alex Williamson , qemu-arm@nongnu.org, Peter Chubb , Yuval Shaia , Stefan Hajnoczi , xen-devel@lists.xenproject.org, John Snow , Richard Henderson , qemu-block@nongnu.org, Peter Crosthwaite , Hitoshi Mitake , Wen Congyang , qemu-s390x@nongnu.org, Cornelia Huck , "Richard W.M. Jones" , Juan Quintela , Max Reitz , Michael Walle , qemu-ppc@nongnu.org, =?UTF-8?Q?Andreas_F=c3=a4rber?= , Igor Mammedov , Hannes Reinecke , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= On 22/03/2018 20:29, Michael S. Tsirkin wrote: > On Wed, Mar 21, 2018 at 05:22:03PM +0100, Kevin Wolf wrote: >>> It's all still very much a non-standard convention and so less robust >>> than prefixing file name with a project-specifix prefix. >> I've always had the impression that it's by far the most common >> convention, to the point that I'd blindly assume it when joining a new >> project. >=20 > Any examples? GCC - https://github.com/gcc-mirror/gcc/blob/master/gcc/reload.c Libvirt - https://github.com/libvirt/libvirt/blob/master/src/util/virproc= ess.c SDL - https://github.com/SDL-mirror/SDL/blob/master/src/core/unix/SDL_pol= l.c Anything but Linux really. I find verbose and unnecessary. The only advantage of your proposal is that files included from the source directory would b= e clearly noticeable. That said, it's easy to add a checkpatch.pl rule tha= t detects when ".../..." is used on a file not under include/. Paolo