From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45155) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5sR9-0001QL-QL for qemu-devel@nongnu.org; Thu, 26 May 2016 06:22:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5sR5-0007c6-DI for qemu-devel@nongnu.org; Thu, 26 May 2016 06:22:43 -0400 Sender: Paolo Bonzini References: <1463024905-28401-1-git-send-email-bharata@linux.vnet.ibm.com> <1463024905-28401-3-git-send-email-bharata@linux.vnet.ibm.com> From: Paolo Bonzini Message-ID: Date: Thu, 26 May 2016 12:22:23 +0200 MIME-Version: 1.0 In-Reply-To: <1463024905-28401-3-git-send-email-bharata@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [for-2.7 PATCH v3 02/15] exec: Do vmstate unregistration from cpu_exec_exit() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao , qemu-devel@nongnu.org Cc: mjrosato@linux.vnet.ibm.com, thuth@redhat.com, pkrempa@redhat.com, ehabkost@redhat.com, aik@ozlabs.ru, armbru@redhat.com, agraf@suse.de, borntraeger@de.ibm.com, qemu-ppc@nongnu.org, imammedo@redhat.com, mdroth@linux.vnet.ibm.com, afaerber@suse.de, david@gibson.dropbear.id.au On 12/05/2016 05:48, Bharata B Rao wrote: > cpu_exec_init() does vmstate_register for the CPU device. This needs to be > undone from cpu_exec_exit(). This change is needed to support CPU hot > removal. > > Signed-off-by: Bharata B Rao > Reviewed-by: Thomas Huth > Reviewed-by: David Gibson > --- > exec.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/exec.c b/exec.c > index da1f09a..32bd5df 100644 > --- a/exec.c > +++ b/exec.c > @@ -635,6 +635,8 @@ static void cpu_release_index(CPUState *cpu) > > void cpu_exec_exit(CPUState *cpu) > { > + CPUClass *cc = CPU_GET_CLASS(cpu); > + > #if defined(CONFIG_USER_ONLY) > cpu_list_lock(); > #endif > @@ -652,6 +654,13 @@ void cpu_exec_exit(CPUState *cpu) > #if defined(CONFIG_USER_ONLY) > cpu_list_unlock(); > #endif > + > + if (cc->vmsd != NULL) { > + vmstate_unregister(NULL, cc->vmsd, cpu); > + } > + if (qdev_get_vmsd(DEVICE(cpu)) == NULL) { > + vmstate_unregister(NULL, &vmstate_cpu_common, cpu); > + } > } > > void cpu_exec_init(CPUState *cpu, Error **errp) > Acked-by: Paolo Bonzini