From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4499DC433DB for ; Mon, 18 Jan 2021 10:09:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1449221FF for ; Mon, 18 Jan 2021 10:09:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1449221FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49160 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1RTG-0006ae-NA for qemu-devel@archiver.kernel.org; Mon, 18 Jan 2021 05:09:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53548) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1R8F-0000zY-D9 for qemu-devel@nongnu.org; Mon, 18 Jan 2021 04:47:31 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:58622) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l1R8B-0001Cv-PR for qemu-devel@nongnu.org; Mon, 18 Jan 2021 04:47:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610963247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h3fuvZp+lrDwiaB7C6iDX8zQyy7iI1p6lhJanq5+GG8=; b=ANp00R6aCxuF8cTfuZbGqEnYgYcLze/DVu+vMAU0vc6XTBSAuBj2ApUxihKrzUQV0614Jc Effy28Z7hY14h93rwd2HlRkMwoOt/zU0p6NJchhebDlKNllUY2KICAMPNO5k2y4C49AOJg +3BvlCwcvsxkqw3/pee1lkTpndMHLGY= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-472-8mvhGSxFN2OKkItYGupj5w-1; Mon, 18 Jan 2021 04:47:25 -0500 X-MC-Unique: 8mvhGSxFN2OKkItYGupj5w-1 Received: by mail-wm1-f72.google.com with SMTP id h21so4233000wmq.7 for ; Mon, 18 Jan 2021 01:47:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=h3fuvZp+lrDwiaB7C6iDX8zQyy7iI1p6lhJanq5+GG8=; b=FKyD9tItuaR/Fw842+L3tUprdSaVIihl2KcWiGGIMXEXI6IYd6NrKipN0HZ3C0J1P2 QRwBLGKPd5u1UwSEowf23yu38AgqZNGv/l/0zMbl4J1bWQPpP1q+HsFwYIb/oSN+dFRl rIpByHCzNA8cBruK5+VQTtQOaUmhGcvnlqmuHu1xpf1zh/IbpAdtCbPpHSy1JVoTizYy 2UmrRFfvguWuQ5SbMFKkEvJMihdUidRApS3s7cHDWPQ8gK+c6FmsTmpP4dc+szuYhfOK 6Oi0dLZzThdlNOmrXOwXFNsDFtzqKaih+EOtY+M+/uS1SP8ThT2571QDVnwDmUsxrjyd LfGA== X-Gm-Message-State: AOAM5336/Xgo8fT38Pj/T365eu+4g1fMBUOm9FErf6vKl9uTNj7IMccO RkNbYQyVCHybd1v1iDH7GAN6+iv1D6ml2isYcFojZ8xZSprF1Za6Bj1tLpbp9MT9cQttSgFWI/3 BCYE2uEzlNE8WRJE= X-Received: by 2002:a7b:c09a:: with SMTP id r26mr4844297wmh.64.1610963244290; Mon, 18 Jan 2021 01:47:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJy8COcCkXe8PQWeE8FIzffZ9MNBL4S35PWLxiBL8vLCQnUOMhWx4vouHjd3jlolTgo5leIwvQ== X-Received: by 2002:a7b:c09a:: with SMTP id r26mr4844288wmh.64.1610963244180; Mon, 18 Jan 2021 01:47:24 -0800 (PST) Received: from [192.168.1.36] (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id g5sm29664539wro.60.2021.01.18.01.47.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Jan 2021 01:47:23 -0800 (PST) Subject: Re: [PATCH v2 6/9] tests: Rename PAGE_SIZE definitions To: Jiaxun Yang , qemu-devel@nongnu.org References: <20210118063808.12471-1-jiaxun.yang@flygoat.com> <20210118063808.12471-7-jiaxun.yang@flygoat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Mon, 18 Jan 2021 10:47:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210118063808.12471-7-jiaxun.yang@flygoat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.189, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.252, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Laurent Vivier , Thomas Huth , Viktor Prutyanov , kvm@vger.kernel.org, Alistair Francis , Greg Kurz , Wainer dos Santos Moschetta , Max Reitz , qemu-ppc@nongnu.org, Kevin Wolf , Paolo Bonzini , qemu-block@nongnu.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 1/18/21 7:38 AM, Jiaxun Yang wrote: > As per POSIX specification of limits.h [1], OS libc may define > PAGE_SIZE in limits.h. > > Self defined PAGE_SIZE is frequently used in tests, to prevent > collosion of definition, we give PAGE_SIZE definitons reasonable > prefixs. > > [1]: https://pubs.opengroup.org/onlinepubs/7908799/xsh/limits.h.html > > Signed-off-by: Jiaxun Yang > Reviewed-by: Thomas Huth > --- > tests/migration/stress.c | 10 ++--- > tests/qtest/libqos/malloc-pc.c | 4 +- > tests/qtest/libqos/malloc-spapr.c | 4 +- > tests/qtest/m25p80-test.c | 54 +++++++++++----------- > tests/tcg/multiarch/system/memory.c | 6 +-- > tests/test-xbzrle.c | 70 ++++++++++++++--------------- > 6 files changed, 74 insertions(+), 74 deletions(-) ... > diff --git a/tests/tcg/multiarch/system/memory.c b/tests/tcg/multiarch/system/memory.c > index d124502d73..eb0ec6f8eb 100644 > --- a/tests/tcg/multiarch/system/memory.c > +++ b/tests/tcg/multiarch/system/memory.c > @@ -20,12 +20,12 @@ > # error "Target does not specify CHECK_UNALIGNED" > #endif > > -#define PAGE_SIZE 4096 /* nominal 4k "pages" */ > -#define TEST_SIZE (PAGE_SIZE * 4) /* 4 pages */ > +#define MEM_PAGE_SIZE 4096 /* nominal 4k "pages" */ > +#define TEST_SIZE (MEM_PAGE_SIZE * 4) /* 4 pages */ Clearer renaming TEST_PAGE_SIZE and TEST_MEM_SIZE. If possible using TEST_PAGE_SIZE / TEST_MEM_SIZE: Reviewed-by: Philippe Mathieu-Daudé > > #define ARRAY_SIZE(x) ((sizeof(x) / sizeof((x)[0]))) > > -__attribute__((aligned(PAGE_SIZE))) > +__attribute__((aligned(MEM_PAGE_SIZE))) > static uint8_t test_data[TEST_SIZE];