From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUGHg-0006aZ-Rr for qemu-devel@nongnu.org; Mon, 01 Aug 2016 12:41:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUGHc-0007nb-Dl for qemu-devel@nongnu.org; Mon, 01 Aug 2016 12:41:43 -0400 References: <1470027888-24381-1-git-send-email-famz@redhat.com> From: John Snow Message-ID: Date: Mon, 1 Aug 2016 12:41:37 -0400 MIME-Version: 1.0 In-Reply-To: <1470027888-24381-1-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] curl: Cast fd to int for DPRINTF List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel , QEMU Trivial On 08/01/2016 01:04 AM, Fam Zheng wrote: > Currently "make docker-test-mingw@fedora" has a warning like: > > /tmp/qemu-test/src/block/curl.c: In function 'curl_sock_cb': > /tmp/qemu-test/src/block/curl.c:172:6: warning: format '%d' expects > argument of type 'int', but argument 4 has type 'curl_socket_t {aka long > long unsigned int}' > DPRINTF("CURL (AIO): Sock action %d on fd %d\n", action, fd); > ^ > cc1: all warnings being treated as errors > > Cast to int to suppress it. > > Signed-off-by: Fam Zheng > --- > block/curl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/curl.c b/block/curl.c > index da9f5e8..426fb4d 100644 > --- a/block/curl.c > +++ b/block/curl.c > @@ -169,7 +169,7 @@ static int curl_sock_cb(CURL *curl, curl_socket_t fd, int action, > state->sock_fd = fd; > s = state->s; > > - DPRINTF("CURL (AIO): Sock action %d on fd %d\n", action, fd); > + DPRINTF("CURL (AIO): Sock action %d on fd %d\n", action, (int)fd); > switch (action) { > case CURL_POLL_IN: > aio_set_fd_handler(s->aio_context, fd, false, > Is curl_socket_t always of type long long unsigned int? why not use %llu ? (...Yeah, I know, we're probably not going to be dealing with FDs above 2-4 billion, just curious...) --js Benefit of doubt (this cast is almost certain to never do the wrong thing, and even if it did, it's just a dprintf) Reviewed-by: John Snow