From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: "Kevin Wolf" <kwolf@redhat.com>, "Max Reitz" <mreitz@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qdev: Constify data pointed by few arguments and local variables
Date: Mon, 6 Mar 2017 13:57:07 +0100 [thread overview]
Message-ID: <abddfd7f-d40e-eb4b-cbd4-0a1542d264ae@redhat.com> (raw)
In-Reply-To: <20170306120948.GV2778@thinpad.lan.raisama.net>
On 06/03/2017 13:09, Eduardo Habkost wrote:
>>
>> -void qdev_prop_set_macaddr(DeviceState *dev, const char *name, uint8_t *value)
>> +void qdev_prop_set_macaddr(DeviceState *dev, const char *name,
>> + const uint8_t *value)
> This one makes sense to me.
Indeed. Krzysztof, you could extract this one and send it to
qemu-trivial@nongnu.org.
Thanks,
Paolo
next prev parent reply other threads:[~2017-03-06 12:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-05 21:46 [Qemu-devel] [PATCH] qdev: Constify data pointed by few arguments and local variables Krzysztof Kozlowski
2017-03-06 12:09 ` Eduardo Habkost
2017-03-06 12:57 ` Paolo Bonzini [this message]
2017-03-08 16:22 ` Krzysztof Kozlowski
2017-03-08 18:57 ` Eduardo Habkost
2017-03-08 19:06 ` Krzysztof Kozlowski
2017-03-08 19:22 ` Eduardo Habkost
2017-03-08 19:34 ` Krzysztof Kozlowski
2017-03-08 19:53 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abddfd7f-d40e-eb4b-cbd4-0a1542d264ae@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=krzk@kernel.org \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).